mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	nilfs2: initialize "struct nilfs_binfo_dat"->bi_pad field
nilfs_btree_assign_p() and nilfs_direct_assign_p() are not initializing "struct nilfs_binfo_dat"->bi_pad field, causing uninit-value reports when being passed to CRC function. Link: https://lkml.kernel.org/r/20230326152146.15872-1-konishi.ryusuke@gmail.com Reported-by: syzbot <syzbot+048585f3f4227bb2b49b@syzkaller.appspotmail.com> Link: https://syzkaller.appspot.com/bug?extid=048585f3f4227bb2b49b Reported-by: Dipanjan Das <mail.dipanjan.das@gmail.com> Link: https://lkml.kernel.org/r/CANX2M5bVbzRi6zH3PTcNE_31TzerstOXUa9Bay4E6y6dX23_pg@mail.gmail.com Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> Cc: Alexander Potapenko <glider@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
		
							parent
							
								
									6be49d100c
								
							
						
					
					
						commit
						7397031622
					
				
					 2 changed files with 2 additions and 0 deletions
				
			
		| 
						 | 
					@ -2219,6 +2219,7 @@ static int nilfs_btree_assign_p(struct nilfs_bmap *btree,
 | 
				
			||||||
	/* on-disk format */
 | 
						/* on-disk format */
 | 
				
			||||||
	binfo->bi_dat.bi_blkoff = cpu_to_le64(key);
 | 
						binfo->bi_dat.bi_blkoff = cpu_to_le64(key);
 | 
				
			||||||
	binfo->bi_dat.bi_level = level;
 | 
						binfo->bi_dat.bi_level = level;
 | 
				
			||||||
 | 
						memset(binfo->bi_dat.bi_pad, 0, sizeof(binfo->bi_dat.bi_pad));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	return 0;
 | 
						return 0;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -314,6 +314,7 @@ static int nilfs_direct_assign_p(struct nilfs_bmap *direct,
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	binfo->bi_dat.bi_blkoff = cpu_to_le64(key);
 | 
						binfo->bi_dat.bi_blkoff = cpu_to_le64(key);
 | 
				
			||||||
	binfo->bi_dat.bi_level = 0;
 | 
						binfo->bi_dat.bi_level = 0;
 | 
				
			||||||
 | 
						memset(binfo->bi_dat.bi_pad, 0, sizeof(binfo->bi_dat.bi_pad));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	return 0;
 | 
						return 0;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue