mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 10:40:15 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

cxgb3/l2t: Fix undefined behaviour

Browse source 
The use of zero-sized array causes undefined behaviour when it is not
the last member in a structure. As it happens to be in this case.

Also, the current code makes use of a language extension to the C90
standard, but the preferred mechanism to declare variable-length
types such as this one is a flexible array member, introduced in
C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last. Which is beneficial
to cultivate a high-quality code.

Fixes: e48f129c2f ("[SCSI] cxgb3i: convert cdev->l2opt to use rcu to prevent NULL dereference")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva 2019-03-29 10:27:26 -05:00 committed by David S. Miller
parent a2c7023f70
commit 7649773293
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/chelsio/cxgb3/l2t.h
View file

@ -75,8 +75,8 @@ struct l2t_data {
struct l2t_entry *rover; /* starting point for next allocation */ struct l2t_entry *rover; /* starting point for next allocation */
atomic_t nfree; /* number of free entries */ atomic_t nfree; /* number of free entries */
rwlock_t lock; rwlock_t lock;
struct l2t_entry l2tab[0];
struct rcu_head rcu_head; /* to handle rcu cleanup */ struct rcu_head rcu_head; /* to handle rcu cleanup */
struct l2t_entry l2tab[];
}; };
typedef void (*arp_failure_handler_func)(struct t3cdev * dev, typedef void (*arp_failure_handler_func)(struct t3cdev * dev,