mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	drm/sun4i: Remove useless atomic_check
The atomic_check callback is optional, and we don't implement anything in some parts of our drivers. Let's remove it. Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
This commit is contained in:
		
							parent
							
								
									f4c08112ad
								
							
						
					
					
						commit
						7d1a2bf41f
					
				
					 3 changed files with 0 additions and 23 deletions
				
			
		| 
						 | 
					@ -25,12 +25,6 @@ struct sun4i_plane_desc {
 | 
				
			||||||
	       uint32_t                nformats;
 | 
						       uint32_t                nformats;
 | 
				
			||||||
};
 | 
					};
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static int sun4i_backend_layer_atomic_check(struct drm_plane *plane,
 | 
					 | 
				
			||||||
					    struct drm_plane_state *state)
 | 
					 | 
				
			||||||
{
 | 
					 | 
				
			||||||
	return 0;
 | 
					 | 
				
			||||||
}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
static void sun4i_backend_layer_atomic_disable(struct drm_plane *plane,
 | 
					static void sun4i_backend_layer_atomic_disable(struct drm_plane *plane,
 | 
				
			||||||
					       struct drm_plane_state *old_state)
 | 
										       struct drm_plane_state *old_state)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
| 
						 | 
					@ -53,7 +47,6 @@ static void sun4i_backend_layer_atomic_update(struct drm_plane *plane,
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static const struct drm_plane_helper_funcs sun4i_backend_layer_helper_funcs = {
 | 
					static const struct drm_plane_helper_funcs sun4i_backend_layer_helper_funcs = {
 | 
				
			||||||
	.atomic_check	= sun4i_backend_layer_atomic_check,
 | 
					 | 
				
			||||||
	.atomic_disable	= sun4i_backend_layer_atomic_disable,
 | 
						.atomic_disable	= sun4i_backend_layer_atomic_disable,
 | 
				
			||||||
	.atomic_update	= sun4i_backend_layer_atomic_update,
 | 
						.atomic_update	= sun4i_backend_layer_atomic_update,
 | 
				
			||||||
};
 | 
					};
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -128,13 +128,6 @@ static struct drm_connector_funcs sun4i_rgb_con_funcs = {
 | 
				
			||||||
	.atomic_destroy_state	= drm_atomic_helper_connector_destroy_state,
 | 
						.atomic_destroy_state	= drm_atomic_helper_connector_destroy_state,
 | 
				
			||||||
};
 | 
					};
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static int sun4i_rgb_atomic_check(struct drm_encoder *encoder,
 | 
					 | 
				
			||||||
				  struct drm_crtc_state *crtc_state,
 | 
					 | 
				
			||||||
				  struct drm_connector_state *conn_state)
 | 
					 | 
				
			||||||
{
 | 
					 | 
				
			||||||
	return 0;
 | 
					 | 
				
			||||||
}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder)
 | 
					static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	struct sun4i_rgb *rgb = drm_encoder_to_sun4i_rgb(encoder);
 | 
						struct sun4i_rgb *rgb = drm_encoder_to_sun4i_rgb(encoder);
 | 
				
			||||||
| 
						 | 
					@ -182,7 +175,6 @@ static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder,
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static struct drm_encoder_helper_funcs sun4i_rgb_enc_helper_funcs = {
 | 
					static struct drm_encoder_helper_funcs sun4i_rgb_enc_helper_funcs = {
 | 
				
			||||||
	.atomic_check	= sun4i_rgb_atomic_check,
 | 
					 | 
				
			||||||
	.mode_set	= sun4i_rgb_encoder_mode_set,
 | 
						.mode_set	= sun4i_rgb_encoder_mode_set,
 | 
				
			||||||
	.disable	= sun4i_rgb_encoder_disable,
 | 
						.disable	= sun4i_rgb_encoder_disable,
 | 
				
			||||||
	.enable		= sun4i_rgb_encoder_enable,
 | 
						.enable		= sun4i_rgb_encoder_enable,
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -341,13 +341,6 @@ static void sun4i_tv_mode_to_drm_mode(const struct tv_mode *tv_mode,
 | 
				
			||||||
	mode->vtotal = mode->vsync_end  + tv_mode->vback_porch;
 | 
						mode->vtotal = mode->vsync_end  + tv_mode->vback_porch;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static int sun4i_tv_atomic_check(struct drm_encoder *encoder,
 | 
					 | 
				
			||||||
				 struct drm_crtc_state *crtc_state,
 | 
					 | 
				
			||||||
				 struct drm_connector_state *conn_state)
 | 
					 | 
				
			||||||
{
 | 
					 | 
				
			||||||
	return 0;
 | 
					 | 
				
			||||||
}
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
static void sun4i_tv_disable(struct drm_encoder *encoder)
 | 
					static void sun4i_tv_disable(struct drm_encoder *encoder)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	struct sun4i_tv *tv = drm_encoder_to_sun4i_tv(encoder);
 | 
						struct sun4i_tv *tv = drm_encoder_to_sun4i_tv(encoder);
 | 
				
			||||||
| 
						 | 
					@ -489,7 +482,6 @@ static void sun4i_tv_mode_set(struct drm_encoder *encoder,
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static struct drm_encoder_helper_funcs sun4i_tv_helper_funcs = {
 | 
					static struct drm_encoder_helper_funcs sun4i_tv_helper_funcs = {
 | 
				
			||||||
	.atomic_check	= sun4i_tv_atomic_check,
 | 
					 | 
				
			||||||
	.disable	= sun4i_tv_disable,
 | 
						.disable	= sun4i_tv_disable,
 | 
				
			||||||
	.enable		= sun4i_tv_enable,
 | 
						.enable		= sun4i_tv_enable,
 | 
				
			||||||
	.mode_set	= sun4i_tv_mode_set,
 | 
						.mode_set	= sun4i_tv_mode_set,
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue