mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock
The commit093c8812de("cgroup: rstat: Cleanup flushing functions and locking") during cleanup accidentally changed the code to call cgroup_rstat_updated_list() without cgroup_rstat_lock which is required. Fix it. Fixes:093c8812de("cgroup: rstat: Cleanup flushing functions and locking") Reported-by: Jakub Kicinski <kuba@kernel.org> Reported-by: Breno Leitao <leitao@debian.org> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com> Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca4@linux.ibm.com/ Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev> Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
		
							parent
							
								
									e8a457b735
								
							
						
					
					
						commit
						7d6c63c319
					
				
					 1 changed files with 2 additions and 1 deletions
				
			
		| 
						 | 
					@ -318,10 +318,11 @@ __bpf_kfunc void cgroup_rstat_flush(struct cgroup *cgrp)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	might_sleep();
 | 
						might_sleep();
 | 
				
			||||||
	for_each_possible_cpu(cpu) {
 | 
						for_each_possible_cpu(cpu) {
 | 
				
			||||||
		struct cgroup *pos = cgroup_rstat_updated_list(cgrp, cpu);
 | 
							struct cgroup *pos;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		/* Reacquire for each CPU to avoid disabling IRQs too long */
 | 
							/* Reacquire for each CPU to avoid disabling IRQs too long */
 | 
				
			||||||
		__cgroup_rstat_lock(cgrp, cpu);
 | 
							__cgroup_rstat_lock(cgrp, cpu);
 | 
				
			||||||
 | 
							pos = cgroup_rstat_updated_list(cgrp, cpu);
 | 
				
			||||||
		for (; pos; pos = pos->rstat_flush_next) {
 | 
							for (; pos; pos = pos->rstat_flush_next) {
 | 
				
			||||||
			struct cgroup_subsys_state *css;
 | 
								struct cgroup_subsys_state *css;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue