mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	xfrm6: release dev before returning error
We forget to call dev_put() on error path in xfrm6_fill_dst(), its caller doesn't handle this. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Cong Wang <amwang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
		
							parent
							
								
									5dbd506843
								
							
						
					
					
						commit
						84c4a9dfbf
					
				
					 1 changed files with 3 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -103,8 +103,10 @@ static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device *dev,
 | 
			
		|||
	dev_hold(dev);
 | 
			
		||||
 | 
			
		||||
	xdst->u.rt6.rt6i_idev = in6_dev_get(dev);
 | 
			
		||||
	if (!xdst->u.rt6.rt6i_idev)
 | 
			
		||||
	if (!xdst->u.rt6.rt6i_idev) {
 | 
			
		||||
		dev_put(dev);
 | 
			
		||||
		return -ENODEV;
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	rt6_transfer_peer(&xdst->u.rt6, rt);
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue