mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-02 17:49:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

sched/topology: Simplify build_overlap_sched_groups()

Browse source 
Now that the first group will always be the previous domain of this
@cpu this can be simplified.

In fact, writing the code now removed should've been a big clue I was
doing it wrong :/

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Peter Zijlstra 2017-04-14 17:32:07 +02:00 committed by Ingo Molnar
parent 0372dd2736
commit 91eaed0d61
1 changed files with 2 additions and 11 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
kernel/sched/topology.c
View file

@ -557,7 +557,7 @@ static void init_overlap_sched_group(struct sched_domain *sd,
static int static int
build_overlap_sched_groups(struct sched_domain *sd, int cpu) build_overlap_sched_groups(struct sched_domain *sd, int cpu)
{ {
struct sched_group *first = NULL, *last = NULL, *groups = NULL, *sg; struct sched_group *first = NULL, *last = NULL, *sg;
const struct cpumask *span = sched_domain_span(sd); const struct cpumask *span = sched_domain_span(sd);
struct cpumask *covered = sched_domains_tmpmask; struct cpumask *covered = sched_domains_tmpmask;
struct sd_data *sdd = sd->private; struct sd_data *sdd = sd->private;
@ -587,15 +587,6 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
init_overlap_sched_group(sd, sg, i); init_overlap_sched_group(sd, sg, i);
/*
* Make sure the first group of this domain contains the
* canonical balance CPU. Otherwise the sched_domain iteration
* breaks. See update_sg_lb_stats().
*/
if ((!groups && cpumask_test_cpu(cpu, sg_span)) ||
group_balance_cpu(sg) == cpu)
groups = sg;
if (!first) if (!first)
first = sg; first = sg;
if (last) if (last)
@ -603,7 +594,7 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
last = sg; last = sg;
last->next = first; last->next = first;
} }
sd->groups = groups; sd->groups = first;
return 0; return 0;