mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-03 01:59:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

xfs: don't bother returning errors from xfs_file_release

Browse source 
While ->release returns int, the only caller ignores the return value.
As we're only doing cleanup work there isn't much of a point in
return a value to start with, so just document the situation instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
This commit is contained in:
Christoph Hellwig 2024-08-13 09:39:36 +02:00 committed by Chandan Babu R
parent 5d3ca62611
commit 98e44e2bc0
1 changed files with 9 additions and 9 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

18
fs/xfs/xfs_file.c
View file

@ -1175,6 +1175,10 @@ xfs_dir_open(
return error; return error;
} }
/*
* Don't bother propagating errors. We're just doing cleanup, and the caller
* ignores the return value anyway.
*/
STATIC int STATIC int
xfs_file_release( xfs_file_release(
struct inode *inode, struct inode *inode,
@ -1182,7 +1186,6 @@ xfs_file_release(
{ {
struct xfs_inode *ip = XFS_I(inode); struct xfs_inode *ip = XFS_I(inode);
struct xfs_mount *mp = ip->i_mount; struct xfs_mount *mp = ip->i_mount;
int error;
/* If this is a read-only mount, don't generate I/O */ /* If this is a read-only mount, don't generate I/O */
if (xfs_is_readonly(mp)) if (xfs_is_readonly(mp))
@ -1200,11 +1203,8 @@ xfs_file_release(
if (!xfs_is_shutdown(mp) && if (!xfs_is_shutdown(mp) &&
xfs_iflags_test_and_clear(ip, XFS_ITRUNCATED)) { xfs_iflags_test_and_clear(ip, XFS_ITRUNCATED)) {
xfs_iflags_clear(ip, XFS_IDIRTY_RELEASE); xfs_iflags_clear(ip, XFS_IDIRTY_RELEASE);
if (ip->i_delayed_blks > 0) { if (ip->i_delayed_blks > 0)
error = filemap_flush(inode->i_mapping); filemap_flush(inode->i_mapping);
if (error)
return error;
}
} }
/* /*
@ -1238,14 +1238,14 @@ xfs_file_release(
* dirty close we will still remove the speculative * dirty close we will still remove the speculative
* allocation, but after that we will leave it in place. * allocation, but after that we will leave it in place.
*/ */
error = xfs_free_eofblocks(ip); xfs_free_eofblocks(ip);
if (!error && ip->i_delayed_blks) if (ip->i_delayed_blks)
xfs_iflags_set(ip, XFS_IDIRTY_RELEASE); xfs_iflags_set(ip, XFS_IDIRTY_RELEASE);
} }
xfs_iunlock(ip, XFS_IOLOCK_EXCL); xfs_iunlock(ip, XFS_IOLOCK_EXCL);
} }
return error; return 0;
} }
STATIC int STATIC int