mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	PM: sleep: Fix runtime PM based cpuidle support
In the cpuidle-psci case, runtime PM in combination with the generic PM domain (genpd), may be used when entering/exiting a shared idlestate. More precisely, genpd relies on runtime PM to be enabled for the attached device (in this case it belongs to a CPU), to properly manage the reference counting of its PM domain. This works fine most of the time, but during system suspend in dpm_suspend_late(), the PM core disables runtime PM for all devices. Beyond this point, calls to pm_runtime_get_sync() to runtime resume a device may fail and therefore it could also mess up the reference counting in genpd. To fix this problem, let's call wake_up_all_idle_cpus() in dpm_suspend_late(), prior to disabling runtime PM. In this way a device that belongs to a CPU, becomes runtime resumed through cpuidle-psci and stays like that, because the runtime PM usage count has been bumped in device_prepare(). Diagnosed-by: Maulik Shah <mkshah@codeaurora.org> Suggested-by: Rafael J. Wysocki <rafael@kernel.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
		
							parent
							
								
									833db72142
								
							
						
					
					
						commit
						a2bd7be12b
					
				
					 1 changed files with 1 additions and 0 deletions
				
			
		|  | @ -1463,6 +1463,7 @@ int dpm_suspend_late(pm_message_t state) | ||||||
| 	int error = 0; | 	int error = 0; | ||||||
| 
 | 
 | ||||||
| 	trace_suspend_resume(TPS("dpm_suspend_late"), state.event, true); | 	trace_suspend_resume(TPS("dpm_suspend_late"), state.event, true); | ||||||
|  | 	wake_up_all_idle_cpus(); | ||||||
| 	mutex_lock(&dpm_list_mtx); | 	mutex_lock(&dpm_list_mtx); | ||||||
| 	pm_transition = state; | 	pm_transition = state; | ||||||
| 	async_error = 0; | 	async_error = 0; | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue
	
	 Ulf Hansson
						Ulf Hansson