mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 10:40:15 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

GPU-DRM-Savage: Use memdup_user() rather than duplicating

Browse source 
Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/021efa32-c259-e799-a80e-630972291815@users.sourceforge.net
This commit is contained in:
Markus Elfring 2016-08-18 18:12:03 +02:00 committed by Daniel Vetter
parent 1832040d01
commit a6e3918bcd
1 changed files with 3 additions and 9 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/gpu/drm/savage/savage_state.c
View file

@ -1001,15 +1001,9 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_
cmdbuf->cmd_addr = kcmd_addr; cmdbuf->cmd_addr = kcmd_addr;
} }
if (cmdbuf->vb_size) { if (cmdbuf->vb_size) {
kvb_addr = kmalloc(cmdbuf->vb_size, GFP_KERNEL); kvb_addr = memdup_user(cmdbuf->vb_addr, cmdbuf->vb_size);
if (kvb_addr == NULL) { if (IS_ERR(kvb_addr)) {
ret = -ENOMEM; ret = PTR_ERR(kvb_addr);
goto done;
}
if (copy_from_user(kvb_addr, cmdbuf->vb_addr,
cmdbuf->vb_size)) {
ret = -EFAULT;
goto done; goto done;
} }
cmdbuf->vb_addr = kvb_addr; cmdbuf->vb_addr = kvb_addr;