mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	bpfilter: check if $(CC) can link static libc in Kconfig
On Fedora, linking static glibc requires the glibc-static RPM package,
which is not part of the glibc-devel package.
CONFIG_CC_CAN_LINK does not check the capability of static linking,
so you can enable CONFIG_BPFILTER_UMH, then fail to build:
    HOSTLD  net/bpfilter/bpfilter_umh
  /usr/bin/ld: cannot find -lc
  collect2: error: ld returned 1 exit status
Add CONFIG_CC_CAN_LINK_STATIC, and make CONFIG_BPFILTER_UMH depend
on it.
Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
			
			
This commit is contained in:
		
							parent
							
								
									9371f86ecb
								
							
						
					
					
						commit
						b1183b6dca
					
				
					 2 changed files with 6 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -49,6 +49,11 @@ config CC_CAN_LINK
 | 
			
		|||
	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(m64-flag)) if 64BIT
 | 
			
		||||
	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) $(m32-flag))
 | 
			
		||||
 | 
			
		||||
config CC_CAN_LINK_STATIC
 | 
			
		||||
	bool
 | 
			
		||||
	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) -static $(m64-flag)) if 64BIT
 | 
			
		||||
	default $(success,$(srctree)/scripts/cc-can-link.sh $(CC) -static $(m32-flag))
 | 
			
		||||
 | 
			
		||||
config CC_HAS_ASM_GOTO
 | 
			
		||||
	def_bool $(success,$(srctree)/scripts/gcc-goto.sh $(CC))
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -9,7 +9,7 @@ menuconfig BPFILTER
 | 
			
		|||
if BPFILTER
 | 
			
		||||
config BPFILTER_UMH
 | 
			
		||||
	tristate "bpfilter kernel module with user mode helper"
 | 
			
		||||
	depends on CC_CAN_LINK
 | 
			
		||||
	depends on CC_CAN_LINK_STATIC
 | 
			
		||||
	default m
 | 
			
		||||
	help
 | 
			
		||||
	  This builds bpfilter kernel module with embedded user mode helper
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue