mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	bpf: move user_size out of bpf_test_init
Rely on data_size_in in bpf_test_init routine signature. This is a preliminary patch to introduce xdp frags selftest Acked-by: Toke Hoiland-Jorgensen <toke@redhat.com> Acked-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Link: https://lore.kernel.org/r/6b48d38ed3d60240d7d6bb15e6fa7fabfac8dfb2.1642758637.git.lorenzo@kernel.org Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
		
							parent
							
								
									d99173027d
								
							
						
					
					
						commit
						be3d72a289
					
				
					 1 changed files with 7 additions and 6 deletions
				
			
		| 
						 | 
					@ -367,11 +367,10 @@ BTF_SET_START(test_sk_ret_null_kfunc_ids)
 | 
				
			||||||
BTF_ID(func, bpf_kfunc_call_test_acquire)
 | 
					BTF_ID(func, bpf_kfunc_call_test_acquire)
 | 
				
			||||||
BTF_SET_END(test_sk_ret_null_kfunc_ids)
 | 
					BTF_SET_END(test_sk_ret_null_kfunc_ids)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static void *bpf_test_init(const union bpf_attr *kattr, u32 size,
 | 
					static void *bpf_test_init(const union bpf_attr *kattr, u32 user_size,
 | 
				
			||||||
			   u32 headroom, u32 tailroom)
 | 
								   u32 size, u32 headroom, u32 tailroom)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	void __user *data_in = u64_to_user_ptr(kattr->test.data_in);
 | 
						void __user *data_in = u64_to_user_ptr(kattr->test.data_in);
 | 
				
			||||||
	u32 user_size = kattr->test.data_size_in;
 | 
					 | 
				
			||||||
	void *data;
 | 
						void *data;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (size < ETH_HLEN || size > PAGE_SIZE - headroom - tailroom)
 | 
						if (size < ETH_HLEN || size > PAGE_SIZE - headroom - tailroom)
 | 
				
			||||||
| 
						 | 
					@ -699,7 +698,8 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,
 | 
				
			||||||
	if (kattr->test.flags || kattr->test.cpu)
 | 
						if (kattr->test.flags || kattr->test.cpu)
 | 
				
			||||||
		return -EINVAL;
 | 
							return -EINVAL;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	data = bpf_test_init(kattr, size, NET_SKB_PAD + NET_IP_ALIGN,
 | 
						data = bpf_test_init(kattr, kattr->test.data_size_in,
 | 
				
			||||||
 | 
								     size, NET_SKB_PAD + NET_IP_ALIGN,
 | 
				
			||||||
			     SKB_DATA_ALIGN(sizeof(struct skb_shared_info)));
 | 
								     SKB_DATA_ALIGN(sizeof(struct skb_shared_info)));
 | 
				
			||||||
	if (IS_ERR(data))
 | 
						if (IS_ERR(data))
 | 
				
			||||||
		return PTR_ERR(data);
 | 
							return PTR_ERR(data);
 | 
				
			||||||
| 
						 | 
					@ -908,7 +908,8 @@ int bpf_prog_test_run_xdp(struct bpf_prog *prog, const union bpf_attr *kattr,
 | 
				
			||||||
	/* XDP have extra tailroom as (most) drivers use full page */
 | 
						/* XDP have extra tailroom as (most) drivers use full page */
 | 
				
			||||||
	max_data_sz = 4096 - headroom - tailroom;
 | 
						max_data_sz = 4096 - headroom - tailroom;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	data = bpf_test_init(kattr, max_data_sz, headroom, tailroom);
 | 
						data = bpf_test_init(kattr, kattr->test.data_size_in,
 | 
				
			||||||
 | 
								     max_data_sz, headroom, tailroom);
 | 
				
			||||||
	if (IS_ERR(data)) {
 | 
						if (IS_ERR(data)) {
 | 
				
			||||||
		ret = PTR_ERR(data);
 | 
							ret = PTR_ERR(data);
 | 
				
			||||||
		goto free_ctx;
 | 
							goto free_ctx;
 | 
				
			||||||
| 
						 | 
					@ -994,7 +995,7 @@ int bpf_prog_test_run_flow_dissector(struct bpf_prog *prog,
 | 
				
			||||||
	if (size < ETH_HLEN)
 | 
						if (size < ETH_HLEN)
 | 
				
			||||||
		return -EINVAL;
 | 
							return -EINVAL;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	data = bpf_test_init(kattr, size, 0, 0);
 | 
						data = bpf_test_init(kattr, kattr->test.data_size_in, size, 0, 0);
 | 
				
			||||||
	if (IS_ERR(data))
 | 
						if (IS_ERR(data))
 | 
				
			||||||
		return PTR_ERR(data);
 | 
							return PTR_ERR(data);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue