mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	RDS: Heap OOB write in rds_message_alloc_sgs()
When args->nr_local is 0, nr_pages gets also 0 due some size calculation via rds_rm_size(), which is later used to allocate pages for DMA, this bug produces a heap Out-Of-Bound write access to a specific memory region. Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
		
							parent
							
								
									c0bace7984
								
							
						
					
					
						commit
						c095508770
					
				
					 1 changed files with 3 additions and 0 deletions
				
			
		| 
						 | 
					@ -525,6 +525,9 @@ int rds_rdma_extra_size(struct rds_rdma_args *args)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	local_vec = (struct rds_iovec __user *)(unsigned long) args->local_vec_addr;
 | 
						local_vec = (struct rds_iovec __user *)(unsigned long) args->local_vec_addr;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						if (args->nr_local == 0)
 | 
				
			||||||
 | 
							return -EINVAL;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	/* figure out the number of pages in the vector */
 | 
						/* figure out the number of pages in the vector */
 | 
				
			||||||
	for (i = 0; i < args->nr_local; i++) {
 | 
						for (i = 0; i < args->nr_local; i++) {
 | 
				
			||||||
		if (copy_from_user(&vec, &local_vec[i],
 | 
							if (copy_from_user(&vec, &local_vec[i],
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue