mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

vsock: always call vsock_init_tables()

Browse source 
Although CONFIG_VSOCKETS_DIAG depends on CONFIG_VSOCKETS,
vsock_init_tables() is not always called, it is called only
if other modules call its caller. Therefore if we only
enable CONFIG_VSOCKETS_DIAG, it would crash kernel on uninitialized
vsock_bind_table.

This patch fixes it by moving vsock_init_tables() to its own
module_init().

Fixes: 413a4317ac ("VSOCK: add sock_diag interface")
Reported-by: syzkaller bot
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Cong Wang 2017-10-24 15:30:37 -07:00 committed by David S. Miller
parent 3c91b0c1de
commit c1eef220c1
1 changed files with 4 additions and 3 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
net/vmw_vsock/af_vsock.c
View file

@ -195,7 +195,7 @@ static int vsock_auto_bind(struct vsock_sock *vsk)
return __vsock_bind(sk, &local_addr); return __vsock_bind(sk, &local_addr);
} }
static void vsock_init_tables(void) static int __init vsock_init_tables(void)
{ {
int i; int i;
@ -204,6 +204,7 @@ static void vsock_init_tables(void)
for (i = 0; i < ARRAY_SIZE(vsock_connected_table); i++) for (i = 0; i < ARRAY_SIZE(vsock_connected_table); i++)
INIT_LIST_HEAD(&vsock_connected_table[i]); INIT_LIST_HEAD(&vsock_connected_table[i]);
return 0;
} }
static void __vsock_insert_bound(struct list_head *list, static void __vsock_insert_bound(struct list_head *list,
@ -1957,8 +1958,6 @@ int __vsock_core_init(const struct vsock_transport *t, struct module *owner)
vsock_proto.owner = owner; vsock_proto.owner = owner;
transport = t; transport = t;
vsock_init_tables();
vsock_device.minor = MISC_DYNAMIC_MINOR; vsock_device.minor = MISC_DYNAMIC_MINOR;
err = misc_register(&vsock_device); err = misc_register(&vsock_device);
if (err) { if (err) {
@ -2019,6 +2018,8 @@ const struct vsock_transport *vsock_core_get_transport(void)
} }
EXPORT_SYMBOL_GPL(vsock_core_get_transport); EXPORT_SYMBOL_GPL(vsock_core_get_transport);
module_init(vsock_init_tables);
MODULE_AUTHOR("VMware, Inc."); MODULE_AUTHOR("VMware, Inc.");
MODULE_DESCRIPTION("VMware Virtual Socket Family"); MODULE_DESCRIPTION("VMware Virtual Socket Family");
MODULE_VERSION("1.0.2.0-k"); MODULE_VERSION("1.0.2.0-k");