mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	vfs: Check attribute names in posix acl xattr handers
The get and set operations of the POSIX ACL xattr handlers failed to check the attribute names, so all names with "system.posix_acl_access" or "system.posix_acl_default" as a prefix were accepted. Reject invalid names from now on. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
		
							parent
							
								
									7c7afc440c
								
							
						
					
					
						commit
						c361016ade
					
				
					 1 changed files with 4 additions and 0 deletions
				
			
		| 
						 | 
				
			
			@ -768,6 +768,8 @@ posix_acl_xattr_get(struct dentry *dentry, const char *name,
 | 
			
		|||
	struct posix_acl *acl;
 | 
			
		||||
	int error;
 | 
			
		||||
 | 
			
		||||
	if (strcmp(name, "") != 0)
 | 
			
		||||
		return -EINVAL;
 | 
			
		||||
	if (!IS_POSIXACL(d_backing_inode(dentry)))
 | 
			
		||||
		return -EOPNOTSUPP;
 | 
			
		||||
	if (d_is_symlink(dentry))
 | 
			
		||||
| 
						 | 
				
			
			@ -793,6 +795,8 @@ posix_acl_xattr_set(struct dentry *dentry, const char *name,
 | 
			
		|||
	struct posix_acl *acl = NULL;
 | 
			
		||||
	int ret;
 | 
			
		||||
 | 
			
		||||
	if (strcmp(name, "") != 0)
 | 
			
		||||
		return -EINVAL;
 | 
			
		||||
	if (!IS_POSIXACL(inode))
 | 
			
		||||
		return -EOPNOTSUPP;
 | 
			
		||||
	if (!inode->i_op->set_acl)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue