mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-10-31 16:48:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fsdax: switch dax_iomap_rw to use iomap_iter

Browse source 
Switch the dax_iomap_rw implementation to use iomap_iter.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
This commit is contained in:
Christoph Hellwig 2021-08-10 18:33:13 -07:00 committed by Darrick J. Wong
parent 3d99a1ce38
commit ca289e0b95
1 changed files with 24 additions and 25 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

49
fs/dax.c
View file

@ -1103,20 +1103,21 @@ s64 dax_iomap_zero(loff_t pos, u64 length, struct iomap *iomap)
return size; return size;
} }
static loff_t static loff_t dax_iomap_iter(const struct iomap_iter *iomi,
dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *data, struct iov_iter *iter)
struct iomap *iomap, struct iomap *srcmap)
{ {
const struct iomap *iomap = &iomi->iomap;
loff_t length = iomap_length(iomi);
loff_t pos = iomi->pos;
struct block_device *bdev = iomap->bdev; struct block_device *bdev = iomap->bdev;
struct dax_device *dax_dev = iomap->dax_dev; struct dax_device *dax_dev = iomap->dax_dev;
struct iov_iter *iter = data;
loff_t end = pos + length, done = 0; loff_t end = pos + length, done = 0;
ssize_t ret = 0; ssize_t ret = 0;
size_t xfer; size_t xfer;
int id; int id;
if (iov_iter_rw(iter) == READ) { if (iov_iter_rw(iter) == READ) {
end = min(end, i_size_read(inode)); end = min(end, i_size_read(iomi->inode));
if (pos >= end) if (pos >= end)
return 0; return 0;
@ -1133,7 +1134,7 @@ dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
* written by write(2) is visible in mmap. * written by write(2) is visible in mmap.
*/ */
if (iomap->flags & IOMAP_F_NEW) { if (iomap->flags & IOMAP_F_NEW) {
invalidate_inode_pages2_range(inode->i_mapping, invalidate_inode_pages2_range(iomi->inode->i_mapping,
pos >> PAGE_SHIFT, pos >> PAGE_SHIFT,
(end - 1) >> PAGE_SHIFT); (end - 1) >> PAGE_SHIFT);
} }
@ -1209,31 +1210,29 @@ ssize_t
dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter, dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,
const struct iomap_ops *ops) const struct iomap_ops *ops)
{ {
struct address_space *mapping = iocb->ki_filp->f_mapping; struct iomap_iter iomi = {
struct inode *inode = mapping->host; .inode = iocb->ki_filp->f_mapping->host,
loff_t pos = iocb->ki_pos, ret = 0, done = 0; .pos = iocb->ki_pos,
unsigned flags = 0; .len = iov_iter_count(iter),
};
loff_t done = 0;
int ret;
if (iov_iter_rw(iter) == WRITE) { if (iov_iter_rw(iter) == WRITE) {
lockdep_assert_held_write(&inode->i_rwsem); lockdep_assert_held_write(&iomi.inode->i_rwsem);
flags |= IOMAP_WRITE; iomi.flags |= IOMAP_WRITE;
} else { } else {
lockdep_assert_held(&inode->i_rwsem); lockdep_assert_held(&iomi.inode->i_rwsem);
} }
if (iocb->ki_flags & IOCB_NOWAIT) if (iocb->ki_flags & IOCB_NOWAIT)
flags |= IOMAP_NOWAIT; iomi.flags |= IOMAP_NOWAIT;
while (iov_iter_count(iter)) { while ((ret = iomap_iter(&iomi, ops)) > 0)
ret = iomap_apply(inode, pos, iov_iter_count(iter), flags, ops, iomi.processed = dax_iomap_iter(&iomi, iter);
iter, dax_iomap_actor);
if (ret <= 0)
break;
pos += ret;
done += ret;
}
iocb->ki_pos += done; done = iomi.pos - iocb->ki_pos;
iocb->ki_pos = iomi.pos;
return done ? done : ret; return done ? done : ret;
} }
EXPORT_SYMBOL_GPL(dax_iomap_rw); EXPORT_SYMBOL_GPL(dax_iomap_rw);
@ -1307,7 +1306,7 @@ static vm_fault_t dax_iomap_pte_fault(struct vm_fault *vmf, pfn_t *pfnp,
} }
/* /*
* Note that we don't bother to use iomap_apply here: DAX required * Note that we don't bother to use iomap_iter here: DAX required
* the file system block size to be equal the page size, which means * the file system block size to be equal the page size, which means
* that we never have to deal with more than a single extent here. * that we never have to deal with more than a single extent here.
*/ */
@ -1561,7 +1560,7 @@ static vm_fault_t dax_iomap_pmd_fault(struct vm_fault *vmf, pfn_t *pfnp,
} }
/* /*
* Note that we don't use iomap_apply here. We aren't doing I/O, only * Note that we don't use iomap_iter here. We aren't doing I/O, only
* setting up a mapping, so really we're using iomap_begin() as a way * setting up a mapping, so really we're using iomap_begin() as a way
* to look up our filesystem block. * to look up our filesystem block.
*/ */