mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	drm/todo: Add entry to rename drm_atomic_state
The name of the structure drm_atomic_state is confusing. Let's add an entry to our todo list to rename it. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://lore.kernel.org/r/20231214100917.277842-5-mripard@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
This commit is contained in:
		
							parent
							
								
									ab9fabeae4
								
							
						
					
					
						commit
						d0ac5722da
					
				
					 1 changed files with 23 additions and 0 deletions
				
			
		| 
						 | 
				
			
			@ -120,6 +120,29 @@ Contact: Daniel Vetter, respective driver maintainers
 | 
			
		|||
 | 
			
		||||
Level: Advanced
 | 
			
		||||
 | 
			
		||||
Rename drm_atomic_state
 | 
			
		||||
-----------------------
 | 
			
		||||
 | 
			
		||||
The KMS framework uses two slightly different definitions for the ``state``
 | 
			
		||||
concept. For a given object (plane, CRTC, encoder, etc., so
 | 
			
		||||
``drm_$OBJECT_state``), the state is the entire state of that object. However,
 | 
			
		||||
at the device level, ``drm_atomic_state`` refers to a state update for a
 | 
			
		||||
limited number of objects.
 | 
			
		||||
 | 
			
		||||
The state isn't the entire device state, but only the full state of some
 | 
			
		||||
objects in that device. This is confusing to newcomers, and
 | 
			
		||||
``drm_atomic_state`` should be renamed to something clearer like
 | 
			
		||||
``drm_atomic_commit``.
 | 
			
		||||
 | 
			
		||||
In addition to renaming the structure itself, it would also imply renaming some
 | 
			
		||||
related functions (``drm_atomic_state_alloc``, ``drm_atomic_state_get``,
 | 
			
		||||
``drm_atomic_state_put``, ``drm_atomic_state_init``,
 | 
			
		||||
``__drm_atomic_state_free``, etc.).
 | 
			
		||||
 | 
			
		||||
Contact: Maxime Ripard <mripard@kernel.org>
 | 
			
		||||
 | 
			
		||||
Level: Advanced
 | 
			
		||||
 | 
			
		||||
Fallout from atomic KMS
 | 
			
		||||
-----------------------
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue