mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

mm/truncate: Replace page_mapped() call in invalidate_inode_page()

Browse source 
folio_mapped() is expensive because it has to check each page's mapcount
field.  A cheaper check is whether there are any extra references to
the page, other than the one we own, one from the page private data and
the ones held by the page cache.

The call to remove_mapping() will fail in any case if it cannot freeze
the refcount, but failing here avoids cycling the i_pages spinlock.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
This commit is contained in:
Matthew Wilcox (Oracle) 2022-02-12 17:43:16 -05:00
parent 4418481396
commit e41c81d0d3
1 changed files with 3 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
mm/truncate.c
View file

@ -287,7 +287,9 @@ int invalidate_inode_page(struct page *page)
return 0; return 0;
if (folio_test_dirty(folio) || folio_test_writeback(folio)) if (folio_test_dirty(folio) || folio_test_writeback(folio))
return 0; return 0;
if (page_mapped(page)) /* The refcount will be elevated if any page in the folio is mapped */
if (folio_ref_count(folio) >
folio_nr_pages(folio) + folio_has_private(folio) + 1)
return 0; return 0;
if (folio_has_private(folio) && !filemap_release_folio(folio, 0)) if (folio_has_private(folio) && !filemap_release_folio(folio, 0))
return 0; return 0;