mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	selftests: vm: pkeys: fix multilib builds for x86
This ensures that both 32-bit and 64-bit binaries are generated when this is built on a x86_64 system. Most of the changes have been borrowed from tools/testing/selftests/x86/Makefile. Signed-off-by: Sandipan Das <sandipan@linux.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Tested-by: Dave Hansen <dave.hansen@intel.com> Acked-by: Dave Hansen <dave.hansen@intel.com> Cc: "Desnes A. Nunes do Rosario" <desnesn@linux.vnet.ibm.com> Cc: Florian Weimer <fweimer@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Ram Pai <linuxram@us.ibm.com> Cc: Thiago Jung Bauermann <bauerman@linux.ibm.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Michal Hocko <mhocko@kernel.org> Cc: Michal Suchanek <msuchanek@suse.de> Cc: Shuah Khan <shuah@kernel.org> Link: http://lkml.kernel.org/r/0326a442214d7a1b970d38296e63df3b217f5912.1585646528.git.sandipan@linux.ibm.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
		
							parent
							
								
									473c3cc86c
								
							
						
					
					
						commit
						f21fda8f64
					
				
					 1 changed files with 73 additions and 1 deletions
				
			
		| 
						 | 
					@ -15,7 +15,6 @@ TEST_GEN_FILES += map_fixed_noreplace
 | 
				
			||||||
TEST_GEN_FILES += map_populate
 | 
					TEST_GEN_FILES += map_populate
 | 
				
			||||||
TEST_GEN_FILES += mlock-random-test
 | 
					TEST_GEN_FILES += mlock-random-test
 | 
				
			||||||
TEST_GEN_FILES += mlock2-tests
 | 
					TEST_GEN_FILES += mlock2-tests
 | 
				
			||||||
TEST_GEN_FILES += protection_keys
 | 
					 | 
				
			||||||
TEST_GEN_FILES += mremap_dontunmap
 | 
					TEST_GEN_FILES += mremap_dontunmap
 | 
				
			||||||
TEST_GEN_FILES += on-fault-limit
 | 
					TEST_GEN_FILES += on-fault-limit
 | 
				
			||||||
TEST_GEN_FILES += thuge-gen
 | 
					TEST_GEN_FILES += thuge-gen
 | 
				
			||||||
| 
						 | 
					@ -23,6 +22,30 @@ TEST_GEN_FILES += transhuge-stress
 | 
				
			||||||
TEST_GEN_FILES += userfaultfd
 | 
					TEST_GEN_FILES += userfaultfd
 | 
				
			||||||
TEST_GEN_FILES += khugepaged
 | 
					TEST_GEN_FILES += khugepaged
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(ARCH),x86_64)
 | 
				
			||||||
 | 
					CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_program.c -m32)
 | 
				
			||||||
 | 
					CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c)
 | 
				
			||||||
 | 
					CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					TARGETS := protection_keys
 | 
				
			||||||
 | 
					BINARIES_32 := $(TARGETS:%=%_32)
 | 
				
			||||||
 | 
					BINARIES_64 := $(TARGETS:%=%_64)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(CAN_BUILD_WITH_NOPIE),1)
 | 
				
			||||||
 | 
					CFLAGS += -no-pie
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(CAN_BUILD_I386),1)
 | 
				
			||||||
 | 
					TEST_GEN_FILES += $(BINARIES_32)
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(CAN_BUILD_X86_64),1)
 | 
				
			||||||
 | 
					TEST_GEN_FILES += $(BINARIES_64)
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					else
 | 
				
			||||||
 | 
					TEST_GEN_FILES += protection_keys
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
ifneq (,$(filter $(MACHINE),arm64 ia64 mips64 parisc64 ppc64 ppc64le riscv64 s390x sh64 sparc64 x86_64))
 | 
					ifneq (,$(filter $(MACHINE),arm64 ia64 mips64 parisc64 ppc64 ppc64le riscv64 s390x sh64 sparc64 x86_64))
 | 
				
			||||||
TEST_GEN_FILES += va_128TBswitch
 | 
					TEST_GEN_FILES += va_128TBswitch
 | 
				
			||||||
TEST_GEN_FILES += virtual_address_range
 | 
					TEST_GEN_FILES += virtual_address_range
 | 
				
			||||||
| 
						 | 
					@ -38,6 +61,55 @@ include ../lib.mk
 | 
				
			||||||
 | 
					
 | 
				
			||||||
$(OUTPUT)/hmm-tests: LDLIBS += -lhugetlbfs -lpthread
 | 
					$(OUTPUT)/hmm-tests: LDLIBS += -lhugetlbfs -lpthread
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(ARCH),x86_64)
 | 
				
			||||||
 | 
					BINARIES_32 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_32))
 | 
				
			||||||
 | 
					BINARIES_64 := $(patsubst %,$(OUTPUT)/%,$(BINARIES_64))
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					define gen-target-rule-32
 | 
				
			||||||
 | 
					$(1) $(1)_32: $(OUTPUT)/$(1)_32
 | 
				
			||||||
 | 
					.PHONY: $(1) $(1)_32
 | 
				
			||||||
 | 
					endef
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					define gen-target-rule-64
 | 
				
			||||||
 | 
					$(1) $(1)_64: $(OUTPUT)/$(1)_64
 | 
				
			||||||
 | 
					.PHONY: $(1) $(1)_64
 | 
				
			||||||
 | 
					endef
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(CAN_BUILD_I386),1)
 | 
				
			||||||
 | 
					$(BINARIES_32): CFLAGS += -m32
 | 
				
			||||||
 | 
					$(BINARIES_32): LDLIBS += -lrt -ldl -lm
 | 
				
			||||||
 | 
					$(BINARIES_32): %_32: %.c
 | 
				
			||||||
 | 
						$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@
 | 
				
			||||||
 | 
					$(foreach t,$(TARGETS),$(eval $(call gen-target-rule-32,$(t))))
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					ifeq ($(CAN_BUILD_X86_64),1)
 | 
				
			||||||
 | 
					$(BINARIES_64): CFLAGS += -m64
 | 
				
			||||||
 | 
					$(BINARIES_64): LDLIBS += -lrt -ldl
 | 
				
			||||||
 | 
					$(BINARIES_64): %_64: %.c
 | 
				
			||||||
 | 
						$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(notdir $^) $(LDLIBS) -o $@
 | 
				
			||||||
 | 
					$(foreach t,$(TARGETS),$(eval $(call gen-target-rule-64,$(t))))
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					# x86_64 users should be encouraged to install 32-bit libraries
 | 
				
			||||||
 | 
					ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),01)
 | 
				
			||||||
 | 
					all: warn_32bit_failure
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					warn_32bit_failure:
 | 
				
			||||||
 | 
						@echo "Warning: you seem to have a broken 32-bit build" 2>&1;		\
 | 
				
			||||||
 | 
						echo  "environment. This will reduce test coverage of 64-bit" 2>&1;	\
 | 
				
			||||||
 | 
						echo  "kernels. If you are using a Debian-like distribution," 2>&1;	\
 | 
				
			||||||
 | 
						echo  "try:"; 2>&1;							\
 | 
				
			||||||
 | 
						echo  "";								\
 | 
				
			||||||
 | 
						echo  "  apt-get install gcc-multilib libc6-i386 libc6-dev-i386";	\
 | 
				
			||||||
 | 
						echo  "";								\
 | 
				
			||||||
 | 
						echo  "If you are using a Fedora-like distribution, try:";		\
 | 
				
			||||||
 | 
						echo  "";								\
 | 
				
			||||||
 | 
						echo  "  yum install glibc-devel.*i686";				\
 | 
				
			||||||
 | 
						exit 0;
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
$(OUTPUT)/userfaultfd: LDLIBS += -lpthread
 | 
					$(OUTPUT)/userfaultfd: LDLIBS += -lpthread
 | 
				
			||||||
 | 
					
 | 
				
			||||||
$(OUTPUT)/mlock-random-test: LDLIBS += -lcap
 | 
					$(OUTPUT)/mlock-random-test: LDLIBS += -lcap
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue