mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 02:30:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fs/libfs.c: fix simple_attr_write() on 32bit machines

Browse source 
Assume that /sys/kernel/debug/dummy64 is debugfs file created by
debugfs_create_x64().

	# cd /sys/kernel/debug
	# echo 0x1234567812345678 > dummy64
	# cat dummy64
	0x0000000012345678

	# echo 0x80000000 > dummy64
	# cat dummy64
	0xffffffff80000000

A value larger than INT_MAX cannot be written to the debugfs file created
by debugfs_create_u64 or debugfs_create_x64 on 32bit machine.  Because
simple_attr_write() uses simple_strtol() for the conversion.

To fix this, use simple_strtoll() instead.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Akinobu Mita 2011-07-19 08:49:25 -07:00 committed by Linus Torvalds
parent e501f29c72
commit f7b88631a8
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
fs/libfs.c
View file

@ -822,7 +822,7 @@ ssize_t simple_attr_write(struct file *file, const char __user *buf,
goto out; goto out;
attr->set_buf[size] = '\0'; attr->set_buf[size] = '\0';
val = simple_strtol(attr->set_buf, NULL, 0); val = simple_strtoll(attr->set_buf, NULL, 0);
ret = attr->set(attr->data, val); ret = attr->set(attr->data, val);
if (ret == 0) if (ret == 0)
ret = len; /* on success, claim we got the whole input */ ret = len; /* on success, claim we got the whole input */