mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-03 10:10:33 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/vc4: vec: Switch to drmm_kzalloc

Browse source 
Our internal structure that stores the DRM entities structure is allocated
through a device-managed kzalloc.

This means that this will eventually be freed whenever the device is
removed. In our case, the most likely source of removal is that the main
device is going to be unbound, and component_unbind_all() is being run.

However, it occurs while the DRM device is still registered, which will
create dangling pointers, eventually resulting in use-after-free.

Switch to a DRM-managed allocation to keep our structure until the DRM
driver doesn't need it anymore.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-57-maxime@cerno.tech
This commit is contained in:
Maxime Ripard 2022-07-11 19:39:26 +02:00
parent 9780315b06
commit fe7289e218
No known key found for this signature in database
GPG key ID: E3EF0D6F671851C5
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/gpu/drm/vc4/vc4_vec.c
View file

@ -509,7 +509,7 @@ static int vc4_vec_bind(struct device *dev, struct device *master, void *data)
if (ret) if (ret)
return ret; return ret;
vec = devm_kzalloc(dev, sizeof(*vec), GFP_KERNEL); vec = drmm_kzalloc(drm, sizeof(*vec), GFP_KERNEL);
if (!vec) if (!vec)
return -ENOMEM; return -ENOMEM;