mirror of
https://github.com/torvalds/linux.git
synced 2025-11-03 01:59:51 +02:00
Since commit41b4b11da0("drm: Add valid clones check") setting the `possible_clones` values is a hard requirement for cloning. `vkms` supports cloning for writeback connectors in order to capture CRTC content, however that broke with said commit. Writeback connectors are created on a per-CRTC basis, thus mark every non-writeback connector that is compatible with a given CRTC as possible clone - and vice-versa. Using a default configuration, the corresponding `drm_info` output changes from: ├───Encoders │ ├───Encoder 0 │ │ ├───Object ID: 40 │ │ ├───Type: virtual │ │ ├───CRTCS: {0} │ │ └───Clones: {0} │ └───Encoder 1 │ ├───Object ID: 41 │ ├───Type: virtual │ ├───CRTCS: {0} │ └───Clones: {1} into: ├───Encoders │ ├───Encoder 0 │ │ ├───Object ID: 44 │ │ ├───Type: virtual │ │ ├───CRTCS: {0} │ │ └───Clones: {0, 1} │ └───Encoder 1 │ ├───Object ID: 50 │ ├───Type: virtual │ ├───CRTCS: {0} │ └───Clones: {0, 1} Fixes:dbd9d80c1b("drm/vkms: Add support for writeback") Signed-off-by: Robert Mader <robert.mader@collabora.com> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com> Link: https://lore.kernel.org/r/20250718121442.490634-1-robert.mader@collabora.com [fixed Fixes line and changed to: to into: to avoid checkpatch warnings] Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
124 lines
3.5 KiB
C
124 lines
3.5 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
|
|
#include "vkms_config.h"
|
|
#include "vkms_connector.h"
|
|
#include "vkms_drv.h"
|
|
#include <drm/drm_managed.h>
|
|
|
|
int vkms_output_init(struct vkms_device *vkmsdev)
|
|
{
|
|
struct drm_device *dev = &vkmsdev->drm;
|
|
struct vkms_config_plane *plane_cfg;
|
|
struct vkms_config_crtc *crtc_cfg;
|
|
struct vkms_config_encoder *encoder_cfg;
|
|
struct vkms_config_connector *connector_cfg;
|
|
int ret;
|
|
int writeback;
|
|
|
|
if (!vkms_config_is_valid(vkmsdev->config))
|
|
return -EINVAL;
|
|
|
|
vkms_config_for_each_plane(vkmsdev->config, plane_cfg) {
|
|
enum drm_plane_type type;
|
|
|
|
type = vkms_config_plane_get_type(plane_cfg);
|
|
|
|
plane_cfg->plane = vkms_plane_init(vkmsdev, type);
|
|
if (IS_ERR(plane_cfg->plane)) {
|
|
DRM_DEV_ERROR(dev->dev, "Failed to init vkms plane\n");
|
|
return PTR_ERR(plane_cfg->plane);
|
|
}
|
|
}
|
|
|
|
vkms_config_for_each_crtc(vkmsdev->config, crtc_cfg) {
|
|
struct vkms_config_plane *primary, *cursor;
|
|
|
|
primary = vkms_config_crtc_primary_plane(vkmsdev->config, crtc_cfg);
|
|
cursor = vkms_config_crtc_cursor_plane(vkmsdev->config, crtc_cfg);
|
|
|
|
crtc_cfg->crtc = vkms_crtc_init(dev, &primary->plane->base,
|
|
cursor ? &cursor->plane->base : NULL);
|
|
if (IS_ERR(crtc_cfg->crtc)) {
|
|
DRM_ERROR("Failed to allocate CRTC\n");
|
|
return PTR_ERR(crtc_cfg->crtc);
|
|
}
|
|
|
|
/* Initialize the writeback component */
|
|
if (vkms_config_crtc_get_writeback(crtc_cfg)) {
|
|
writeback = vkms_enable_writeback_connector(vkmsdev, crtc_cfg->crtc);
|
|
if (writeback)
|
|
DRM_ERROR("Failed to init writeback connector\n");
|
|
}
|
|
}
|
|
|
|
vkms_config_for_each_plane(vkmsdev->config, plane_cfg) {
|
|
struct vkms_config_crtc *possible_crtc;
|
|
unsigned long idx = 0;
|
|
|
|
vkms_config_plane_for_each_possible_crtc(plane_cfg, idx, possible_crtc) {
|
|
plane_cfg->plane->base.possible_crtcs |=
|
|
drm_crtc_mask(&possible_crtc->crtc->crtc);
|
|
}
|
|
}
|
|
|
|
vkms_config_for_each_encoder(vkmsdev->config, encoder_cfg) {
|
|
struct vkms_config_crtc *possible_crtc;
|
|
unsigned long idx = 0;
|
|
|
|
encoder_cfg->encoder = drmm_kzalloc(dev, sizeof(*encoder_cfg->encoder), GFP_KERNEL);
|
|
if (!encoder_cfg->encoder) {
|
|
DRM_ERROR("Failed to allocate encoder\n");
|
|
return -ENOMEM;
|
|
}
|
|
ret = drmm_encoder_init(dev, encoder_cfg->encoder, NULL,
|
|
DRM_MODE_ENCODER_VIRTUAL, NULL);
|
|
if (ret) {
|
|
DRM_ERROR("Failed to init encoder\n");
|
|
return ret;
|
|
}
|
|
|
|
encoder_cfg->encoder->possible_clones |=
|
|
drm_encoder_mask(encoder_cfg->encoder);
|
|
|
|
vkms_config_encoder_for_each_possible_crtc(encoder_cfg, idx, possible_crtc) {
|
|
encoder_cfg->encoder->possible_crtcs |=
|
|
drm_crtc_mask(&possible_crtc->crtc->crtc);
|
|
|
|
if (vkms_config_crtc_get_writeback(possible_crtc)) {
|
|
struct drm_encoder *wb_encoder =
|
|
&possible_crtc->crtc->wb_encoder;
|
|
|
|
encoder_cfg->encoder->possible_clones |=
|
|
drm_encoder_mask(wb_encoder);
|
|
wb_encoder->possible_clones |=
|
|
drm_encoder_mask(encoder_cfg->encoder);
|
|
}
|
|
}
|
|
}
|
|
|
|
vkms_config_for_each_connector(vkmsdev->config, connector_cfg) {
|
|
struct vkms_config_encoder *possible_encoder;
|
|
unsigned long idx = 0;
|
|
|
|
connector_cfg->connector = vkms_connector_init(vkmsdev);
|
|
if (IS_ERR(connector_cfg->connector)) {
|
|
DRM_ERROR("Failed to init connector\n");
|
|
return PTR_ERR(connector_cfg->connector);
|
|
}
|
|
|
|
vkms_config_connector_for_each_possible_encoder(connector_cfg,
|
|
idx,
|
|
possible_encoder) {
|
|
ret = drm_connector_attach_encoder(&connector_cfg->connector->base,
|
|
possible_encoder->encoder);
|
|
if (ret) {
|
|
DRM_ERROR("Failed to attach connector to encoder\n");
|
|
return ret;
|
|
}
|
|
}
|
|
}
|
|
|
|
drm_mode_config_reset(dev);
|
|
|
|
return 0;
|
|
}
|