mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	 d95f0c4e5b
			
		
	
	
		d95f0c4e5b
		
	
	
	
	
		
			
			The chip needs to be powered up before calling tsc200x_stop_scan() which communicates with it; move the call to enable the regulator earlier in tsc200x_probe(). At the same time switch to using devm_regulator_get_enable() to simplify error handling. This also makes sure that regulator is not shut off too early when unbinding the driver. Link: https://lore.kernel.org/r/20240711172719.1248373-1-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
		
			
				
	
	
		
			73 lines
		
	
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			73 lines
		
	
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0-or-later
 | |
| /*
 | |
|  * TSC2004 touchscreen driver
 | |
|  *
 | |
|  * Copyright (C) 2015 QWERTY Embedded Design
 | |
|  * Copyright (C) 2015 EMAC Inc.
 | |
|  */
 | |
| 
 | |
| #include <linux/module.h>
 | |
| #include <linux/input.h>
 | |
| #include <linux/of.h>
 | |
| #include <linux/i2c.h>
 | |
| #include <linux/regmap.h>
 | |
| #include "tsc200x-core.h"
 | |
| 
 | |
| static const struct input_id tsc2004_input_id = {
 | |
| 	.bustype = BUS_I2C,
 | |
| 	.product = 2004,
 | |
| };
 | |
| 
 | |
| static int tsc2004_cmd(struct device *dev, u8 cmd)
 | |
| {
 | |
| 	u8 tx = TSC200X_CMD | TSC200X_CMD_12BIT | cmd;
 | |
| 	s32 data;
 | |
| 	struct i2c_client *i2c = to_i2c_client(dev);
 | |
| 
 | |
| 	data = i2c_smbus_write_byte(i2c, tx);
 | |
| 	if (data < 0) {
 | |
| 		dev_err(dev, "%s: failed, command: %x i2c error: %d\n",
 | |
| 			__func__, cmd, data);
 | |
| 		return data;
 | |
| 	}
 | |
| 
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static int tsc2004_probe(struct i2c_client *i2c)
 | |
| 
 | |
| {
 | |
| 	return tsc200x_probe(&i2c->dev, i2c->irq, &tsc2004_input_id,
 | |
| 			     devm_regmap_init_i2c(i2c, &tsc200x_regmap_config),
 | |
| 			     tsc2004_cmd);
 | |
| }
 | |
| 
 | |
| static const struct i2c_device_id tsc2004_idtable[] = {
 | |
| 	{ "tsc2004" },
 | |
| 	{ }
 | |
| };
 | |
| MODULE_DEVICE_TABLE(i2c, tsc2004_idtable);
 | |
| 
 | |
| #ifdef CONFIG_OF
 | |
| static const struct of_device_id tsc2004_of_match[] = {
 | |
| 	{ .compatible = "ti,tsc2004" },
 | |
| 	{ /* sentinel */ }
 | |
| };
 | |
| MODULE_DEVICE_TABLE(of, tsc2004_of_match);
 | |
| #endif
 | |
| 
 | |
| static struct i2c_driver tsc2004_driver = {
 | |
| 	.driver = {
 | |
| 		.name		= "tsc2004",
 | |
| 		.dev_groups	= tsc200x_groups,
 | |
| 		.of_match_table	= of_match_ptr(tsc2004_of_match),
 | |
| 		.pm		= pm_sleep_ptr(&tsc200x_pm_ops),
 | |
| 	},
 | |
| 	.id_table       = tsc2004_idtable,
 | |
| 	.probe          = tsc2004_probe,
 | |
| };
 | |
| module_i2c_driver(tsc2004_driver);
 | |
| 
 | |
| MODULE_AUTHOR("Michael Welling <mwelling@ieee.org>");
 | |
| MODULE_DESCRIPTION("TSC2004 Touchscreen Driver");
 | |
| MODULE_LICENSE("GPL");
 |