mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	 b0531cdba5
			
		
	
	
		b0531cdba5
		
	
	
	
	
		
			
			Similar to previous commit2a934fdb01("media: v4l2-dev: fix error handling in __video_register_device()"), the release hook should be set before device_register(). Otherwise, when device_register() return error and put_device() try to callback the release function, the below warning may happen. ------------[ cut here ]------------ WARNING: CPU: 1 PID: 4760 at drivers/base/core.c:2567 device_release+0x1bd/0x240 drivers/base/core.c:2567 Modules linked in: CPU: 1 UID: 0 PID: 4760 Comm: syz.4.914 Not tainted 6.17.0-rc3+ #1 NONE RIP: 0010:device_release+0x1bd/0x240 drivers/base/core.c:2567 Call Trace: <TASK> kobject_cleanup+0x136/0x410 lib/kobject.c:689 kobject_release lib/kobject.c:720 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0xe9/0x130 lib/kobject.c:737 put_device+0x24/0x30 drivers/base/core.c:3797 pps_register_cdev+0x2da/0x370 drivers/pps/pps.c:402 pps_register_source+0x2f6/0x480 drivers/pps/kapi.c:108 pps_tty_open+0x190/0x310 drivers/pps/clients/pps-ldisc.c:57 tty_ldisc_open+0xa7/0x120 drivers/tty/tty_ldisc.c:432 tty_set_ldisc+0x333/0x780 drivers/tty/tty_ldisc.c:563 tiocsetd drivers/tty/tty_io.c:2429 [inline] tty_ioctl+0x5d1/0x1700 drivers/tty/tty_io.c:2728 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:598 [inline] __se_sys_ioctl fs/ioctl.c:584 [inline] __x64_sys_ioctl+0x194/0x210 fs/ioctl.c:584 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0x5f/0x2a0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x76/0x7e </TASK> Before commitc79a39dc8d("pps: Fix a use-after-free"), pps_register_cdev() call device_create() to create pps->dev, which will init dev->release to device_create_release(). Now the comment is outdated, just remove it. Thanks for the reminder from Calvin Owens, 'kfree_pps' should be removed in pps_register_source() to avoid a double free in the failure case. Link: https://lore.kernel.org/all/20250827065010.3208525-1-wangliang74@huawei.com/ Fixes:c79a39dc8d("pps: Fix a use-after-free") Signed-off-by: Wang Liang <wangliang74@huawei.com> Reviewed-By: Calvin Owens <calvin@wbinvd.org> Link: https://lore.kernel.org/r/20250830075023.3498174-1-wangliang74@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
		
			
				
	
	
		
			220 lines
		
	
	
	
		
			5.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			220 lines
		
	
	
	
		
			5.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0-or-later
 | |
| /*
 | |
|  * kernel API
 | |
|  *
 | |
|  * Copyright (C) 2005-2009   Rodolfo Giometti <giometti@linux.it>
 | |
|  */
 | |
| 
 | |
| #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 | |
| 
 | |
| #include <linux/kernel.h>
 | |
| #include <linux/module.h>
 | |
| #include <linux/init.h>
 | |
| #include <linux/sched.h>
 | |
| #include <linux/time.h>
 | |
| #include <linux/timex.h>
 | |
| #include <linux/spinlock.h>
 | |
| #include <linux/fs.h>
 | |
| #include <linux/pps_kernel.h>
 | |
| #include <linux/slab.h>
 | |
| 
 | |
| #include "kc.h"
 | |
| 
 | |
| /*
 | |
|  * Local functions
 | |
|  */
 | |
| 
 | |
| static void pps_add_offset(struct pps_ktime *ts, struct pps_ktime *offset)
 | |
| {
 | |
| 	ts->nsec += offset->nsec;
 | |
| 	while (ts->nsec >= NSEC_PER_SEC) {
 | |
| 		ts->nsec -= NSEC_PER_SEC;
 | |
| 		ts->sec++;
 | |
| 	}
 | |
| 	while (ts->nsec < 0) {
 | |
| 		ts->nsec += NSEC_PER_SEC;
 | |
| 		ts->sec--;
 | |
| 	}
 | |
| 	ts->sec += offset->sec;
 | |
| }
 | |
| 
 | |
| static void pps_echo_client_default(struct pps_device *pps, int event,
 | |
| 		void *data)
 | |
| {
 | |
| 	dev_info(&pps->dev, "echo %s %s\n",
 | |
| 		event & PPS_CAPTUREASSERT ? "assert" : "",
 | |
| 		event & PPS_CAPTURECLEAR ? "clear" : "");
 | |
| }
 | |
| 
 | |
| /*
 | |
|  * Exported functions
 | |
|  */
 | |
| 
 | |
| /* pps_register_source - add a PPS source in the system
 | |
|  * @info: the PPS info struct
 | |
|  * @default_params: the default PPS parameters of the new source
 | |
|  *
 | |
|  * This function is used to add a new PPS source in the system. The new
 | |
|  * source is described by info's fields and it will have, as default PPS
 | |
|  * parameters, the ones specified into default_params.
 | |
|  *
 | |
|  * The function returns, in case of success, the PPS device. Otherwise
 | |
|  * ERR_PTR(errno).
 | |
|  */
 | |
| 
 | |
| struct pps_device *pps_register_source(struct pps_source_info *info,
 | |
| 		int default_params)
 | |
| {
 | |
| 	struct pps_device *pps;
 | |
| 	int err;
 | |
| 
 | |
| 	/* Sanity checks */
 | |
| 	if ((info->mode & default_params) != default_params) {
 | |
| 		pr_err("%s: unsupported default parameters\n",
 | |
| 					info->name);
 | |
| 		err = -EINVAL;
 | |
| 		goto pps_register_source_exit;
 | |
| 	}
 | |
| 	if ((info->mode & (PPS_TSFMT_TSPEC | PPS_TSFMT_NTPFP)) == 0) {
 | |
| 		pr_err("%s: unspecified time format\n",
 | |
| 					info->name);
 | |
| 		err = -EINVAL;
 | |
| 		goto pps_register_source_exit;
 | |
| 	}
 | |
| 
 | |
| 	/* Allocate memory for the new PPS source struct */
 | |
| 	pps = kzalloc(sizeof(struct pps_device), GFP_KERNEL);
 | |
| 	if (pps == NULL) {
 | |
| 		err = -ENOMEM;
 | |
| 		goto pps_register_source_exit;
 | |
| 	}
 | |
| 
 | |
| 	/* These initializations must be done before calling idr_alloc()
 | |
| 	 * in order to avoid reces into pps_event().
 | |
| 	 */
 | |
| 	pps->params.api_version = PPS_API_VERS;
 | |
| 	pps->params.mode = default_params;
 | |
| 	pps->info = *info;
 | |
| 
 | |
| 	/* check for default echo function */
 | |
| 	if ((pps->info.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)) &&
 | |
| 			pps->info.echo == NULL)
 | |
| 		pps->info.echo = pps_echo_client_default;
 | |
| 
 | |
| 	init_waitqueue_head(&pps->queue);
 | |
| 	spin_lock_init(&pps->lock);
 | |
| 
 | |
| 	/* Create the char device */
 | |
| 	err = pps_register_cdev(pps);
 | |
| 	if (err < 0) {
 | |
| 		pr_err("%s: unable to create char device\n",
 | |
| 					info->name);
 | |
| 		goto pps_register_source_exit;
 | |
| 	}
 | |
| 
 | |
| 	dev_dbg(&pps->dev, "new PPS source %s\n", info->name);
 | |
| 
 | |
| 	return pps;
 | |
| 
 | |
| pps_register_source_exit:
 | |
| 	pr_err("%s: unable to register source\n", info->name);
 | |
| 
 | |
| 	return ERR_PTR(err);
 | |
| }
 | |
| EXPORT_SYMBOL(pps_register_source);
 | |
| 
 | |
| /* pps_unregister_source - remove a PPS source from the system
 | |
|  * @pps: the PPS source
 | |
|  *
 | |
|  * This function is used to remove a previously registered PPS source from
 | |
|  * the system.
 | |
|  */
 | |
| 
 | |
| void pps_unregister_source(struct pps_device *pps)
 | |
| {
 | |
| 	pps_kc_remove(pps);
 | |
| 	pps_unregister_cdev(pps);
 | |
| 
 | |
| 	/* don't have to kfree(pps) here because it will be done on
 | |
| 	 * device destruction */
 | |
| }
 | |
| EXPORT_SYMBOL(pps_unregister_source);
 | |
| 
 | |
| /* pps_event - register a PPS event into the system
 | |
|  * @pps: the PPS device
 | |
|  * @ts: the event timestamp
 | |
|  * @event: the event type
 | |
|  * @data: userdef pointer
 | |
|  *
 | |
|  * This function is used by each PPS client in order to register a new
 | |
|  * PPS event into the system (it's usually called inside an IRQ handler).
 | |
|  *
 | |
|  * If an echo function is associated with the PPS device it will be called
 | |
|  * as:
 | |
|  *	pps->info.echo(pps, event, data);
 | |
|  */
 | |
| void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
 | |
| 		void *data)
 | |
| {
 | |
| 	unsigned long flags;
 | |
| 	int captured = 0;
 | |
| 	struct pps_ktime ts_real = { .sec = 0, .nsec = 0, .flags = 0 };
 | |
| 
 | |
| 	/* check event type */
 | |
| 	BUG_ON((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0);
 | |
| 
 | |
| 	dev_dbg(&pps->dev, "PPS event at %lld.%09ld\n",
 | |
| 			(s64)ts->ts_real.tv_sec, ts->ts_real.tv_nsec);
 | |
| 
 | |
| 	timespec_to_pps_ktime(&ts_real, ts->ts_real);
 | |
| 
 | |
| 	spin_lock_irqsave(&pps->lock, flags);
 | |
| 
 | |
| 	/* Must call the echo function? */
 | |
| 	if ((pps->params.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)))
 | |
| 		pps->info.echo(pps, event, data);
 | |
| 
 | |
| 	/* Check the event */
 | |
| 	pps->current_mode = pps->params.mode;
 | |
| 	if (event & pps->params.mode & PPS_CAPTUREASSERT) {
 | |
| 		/* We have to add an offset? */
 | |
| 		if (pps->params.mode & PPS_OFFSETASSERT)
 | |
| 			pps_add_offset(&ts_real,
 | |
| 					&pps->params.assert_off_tu);
 | |
| 
 | |
| 		/* Save the time stamp */
 | |
| 		pps->assert_tu = ts_real;
 | |
| 		pps->assert_sequence++;
 | |
| 		dev_dbg(&pps->dev, "capture assert seq #%u\n",
 | |
| 			pps->assert_sequence);
 | |
| 
 | |
| 		captured = ~0;
 | |
| 	}
 | |
| 	if (event & pps->params.mode & PPS_CAPTURECLEAR) {
 | |
| 		/* We have to add an offset? */
 | |
| 		if (pps->params.mode & PPS_OFFSETCLEAR)
 | |
| 			pps_add_offset(&ts_real,
 | |
| 					&pps->params.clear_off_tu);
 | |
| 
 | |
| 		/* Save the time stamp */
 | |
| 		pps->clear_tu = ts_real;
 | |
| 		pps->clear_sequence++;
 | |
| 		dev_dbg(&pps->dev, "capture clear seq #%u\n",
 | |
| 			pps->clear_sequence);
 | |
| 
 | |
| 		captured = ~0;
 | |
| 	}
 | |
| 
 | |
| 	pps_kc_event(pps, ts, event);
 | |
| 
 | |
| 	/* Wake up if captured something */
 | |
| 	if (captured) {
 | |
| 		pps->last_ev++;
 | |
| 		wake_up_interruptible_all(&pps->queue);
 | |
| 
 | |
| 		kill_fasync(&pps->async_queue, SIGIO, POLL_IN);
 | |
| 	}
 | |
| 
 | |
| 	spin_unlock_irqrestore(&pps->lock, flags);
 | |
| }
 | |
| EXPORT_SYMBOL(pps_event);
 |