mirror of
https://github.com/torvalds/linux.git
synced 2025-11-01 00:58:39 +02:00
1d6049a3b1
As defined in table 126 of the SAS spec 1.1, use an enum for the DATAPRES field, which makes reading the code easier. Also change sas_ssp_task_response() to use a switch statement, which is more suitable (than if-else), as suggested by Christoph. Link: https://lore.kernel.org/r/1645112566-115804-3-git-send-email-john.garry@huawei.com Suggested-by: Xiang Chen <chenxiang66@hisilicon.com> Tested-by: Yihang Li <liyihang6@hisilicon.com> Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Reviewed-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: John Garry <john.garry@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
42 lines
1.2 KiB
C
42 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
#include "sas_internal.h"
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/export.h>
|
|
#include <scsi/sas.h>
|
|
#include <scsi/libsas.h>
|
|
|
|
/* fill task_status_struct based on SSP response frame */
|
|
void sas_ssp_task_response(struct device *dev, struct sas_task *task,
|
|
struct ssp_response_iu *iu)
|
|
{
|
|
struct task_status_struct *tstat = &task->task_status;
|
|
|
|
tstat->resp = SAS_TASK_COMPLETE;
|
|
|
|
switch (iu->datapres) {
|
|
case SAS_DATAPRES_NO_DATA:
|
|
tstat->stat = iu->status;
|
|
break;
|
|
case SAS_DATAPRES_RESPONSE_DATA:
|
|
tstat->stat = iu->resp_data[3];
|
|
break;
|
|
case SAS_DATAPRES_SENSE_DATA:
|
|
tstat->stat = SAS_SAM_STAT_CHECK_CONDITION;
|
|
tstat->buf_valid_size =
|
|
min_t(int, SAS_STATUS_BUF_SIZE,
|
|
be32_to_cpu(iu->sense_data_len));
|
|
memcpy(tstat->buf, iu->sense_data, tstat->buf_valid_size);
|
|
|
|
if (iu->status != SAM_STAT_CHECK_CONDITION)
|
|
dev_warn(dev, "dev %016llx sent sense data, but stat(0x%x) is not CHECK CONDITION\n",
|
|
SAS_ADDR(task->dev->sas_addr), iu->status);
|
|
break;
|
|
default:
|
|
/* when datapres contains corrupt/unknown value... */
|
|
tstat->stat = SAS_SAM_STAT_CHECK_CONDITION;
|
|
}
|
|
}
|
|
EXPORT_SYMBOL_GPL(sas_ssp_task_response);
|
|
|