mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	'modprobe slub_kunit' will have a warning as shown below. The root cause
is that __kmalloc_cache_noprof was directly used, which resulted in no
alloc_tag being allocated. This caused current->alloc_tag to be null,
leading to a warning in alloc_tag_add_check.
Let's add an alloc_hook layer to __kmalloc_cache_noprof specifically
within lib/slub_kunit.c, which is the only user of this internal slub
function outside kmalloc implementation itself.
[58162.947016] WARNING: CPU: 2 PID: 6210 at
./include/linux/alloc_tag.h:125 alloc_tagging_slab_alloc_hook+0x268/0x27c
[58162.957721] Call trace:
[58162.957919]  alloc_tagging_slab_alloc_hook+0x268/0x27c
[58162.958286]  __kmalloc_cache_noprof+0x14c/0x344
[58162.958615]  test_kmalloc_redzone_access+0x50/0x10c [slub_kunit]
[58162.959045]  kunit_try_run_case+0x74/0x184 [kunit]
[58162.959401]  kunit_generic_run_threadfn_adapter+0x2c/0x4c [kunit]
[58162.959841]  kthread+0x10c/0x118
[58162.960093]  ret_from_fork+0x10/0x20
[58162.960363] ---[ end trace 0000000000000000 ]---
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Fixes: a0a44d9175 ("mm, slab: don't wrap internal functions with alloc_hooks()")
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
		
	
			
		
			
				
	
	
		
			227 lines
		
	
	
	
		
			5.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			227 lines
		
	
	
	
		
			5.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0
 | 
						|
#include <kunit/test.h>
 | 
						|
#include <kunit/test-bug.h>
 | 
						|
#include <linux/mm.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/module.h>
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/rcupdate.h>
 | 
						|
#include "../mm/slab.h"
 | 
						|
 | 
						|
static struct kunit_resource resource;
 | 
						|
static int slab_errors;
 | 
						|
 | 
						|
/*
 | 
						|
 * Wrapper function for kmem_cache_create(), which reduces 2 parameters:
 | 
						|
 * 'align' and 'ctor', and sets SLAB_SKIP_KFENCE flag to avoid getting an
 | 
						|
 * object from kfence pool, where the operation could be caught by both
 | 
						|
 * our test and kfence sanity check.
 | 
						|
 */
 | 
						|
static struct kmem_cache *test_kmem_cache_create(const char *name,
 | 
						|
				unsigned int size, slab_flags_t flags)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = kmem_cache_create(name, size, 0,
 | 
						|
					(flags | SLAB_NO_USER_FLAGS), NULL);
 | 
						|
	s->flags |= SLAB_SKIP_KFENCE;
 | 
						|
	return s;
 | 
						|
}
 | 
						|
 | 
						|
static void test_clobber_zone(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_RZ_alloc", 64,
 | 
						|
							SLAB_RED_ZONE);
 | 
						|
	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
 | 
						|
	kasan_disable_current();
 | 
						|
	p[64] = 0x12;
 | 
						|
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
 | 
						|
	kasan_enable_current();
 | 
						|
	kmem_cache_free(s, p);
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
}
 | 
						|
 | 
						|
#ifndef CONFIG_KASAN
 | 
						|
static void test_next_pointer(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_next_ptr_free",
 | 
						|
							64, SLAB_POISON);
 | 
						|
	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
	unsigned long tmp;
 | 
						|
	unsigned long *ptr_addr;
 | 
						|
 | 
						|
	kmem_cache_free(s, p);
 | 
						|
 | 
						|
	ptr_addr = (unsigned long *)(p + s->offset);
 | 
						|
	tmp = *ptr_addr;
 | 
						|
	p[s->offset] = ~p[s->offset];
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Expecting three errors.
 | 
						|
	 * One for the corrupted freechain and the other one for the wrong
 | 
						|
	 * count of objects in use. The third error is fixing broken cache.
 | 
						|
	 */
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 3, slab_errors);
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Try to repair corrupted freepointer.
 | 
						|
	 * Still expecting two errors. The first for the wrong count
 | 
						|
	 * of objects in use.
 | 
						|
	 * The second error is for fixing broken cache.
 | 
						|
	 */
 | 
						|
	*ptr_addr = tmp;
 | 
						|
	slab_errors = 0;
 | 
						|
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Previous validation repaired the count of objects in use.
 | 
						|
	 * Now expecting no error.
 | 
						|
	 */
 | 
						|
	slab_errors = 0;
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 0, slab_errors);
 | 
						|
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
}
 | 
						|
 | 
						|
static void test_first_word(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_1th_word_free",
 | 
						|
							64, SLAB_POISON);
 | 
						|
	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
 | 
						|
	kmem_cache_free(s, p);
 | 
						|
	*p = 0x78;
 | 
						|
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
}
 | 
						|
 | 
						|
static void test_clobber_50th_byte(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_50th_word_free",
 | 
						|
							64, SLAB_POISON);
 | 
						|
	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
 | 
						|
	kmem_cache_free(s, p);
 | 
						|
	p[50] = 0x9a;
 | 
						|
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
}
 | 
						|
#endif
 | 
						|
 | 
						|
static void test_clobber_redzone_free(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_RZ_free", 64,
 | 
						|
							SLAB_RED_ZONE);
 | 
						|
	u8 *p = kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
 | 
						|
	kasan_disable_current();
 | 
						|
	kmem_cache_free(s, p);
 | 
						|
	p[64] = 0xab;
 | 
						|
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
 | 
						|
	kasan_enable_current();
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
}
 | 
						|
 | 
						|
static void test_kmalloc_redzone_access(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_RZ_kmalloc", 32,
 | 
						|
				SLAB_KMALLOC|SLAB_STORE_USER|SLAB_RED_ZONE);
 | 
						|
	u8 *p = alloc_hooks(__kmalloc_cache_noprof(s, GFP_KERNEL, 18));
 | 
						|
 | 
						|
	kasan_disable_current();
 | 
						|
 | 
						|
	/* Suppress the -Warray-bounds warning */
 | 
						|
	OPTIMIZER_HIDE_VAR(p);
 | 
						|
	p[18] = 0xab;
 | 
						|
	p[19] = 0xab;
 | 
						|
 | 
						|
	validate_slab_cache(s);
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
 | 
						|
	kasan_enable_current();
 | 
						|
	kmem_cache_free(s, p);
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
}
 | 
						|
 | 
						|
struct test_kfree_rcu_struct {
 | 
						|
	struct rcu_head rcu;
 | 
						|
};
 | 
						|
 | 
						|
static void test_kfree_rcu(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s;
 | 
						|
	struct test_kfree_rcu_struct *p;
 | 
						|
 | 
						|
	if (IS_BUILTIN(CONFIG_SLUB_KUNIT_TEST))
 | 
						|
		kunit_skip(test, "can't do kfree_rcu() when test is built-in");
 | 
						|
 | 
						|
	s = test_kmem_cache_create("TestSlub_kfree_rcu",
 | 
						|
				   sizeof(struct test_kfree_rcu_struct),
 | 
						|
				   SLAB_NO_MERGE);
 | 
						|
	p = kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
 | 
						|
	kfree_rcu(p, rcu);
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
 | 
						|
	KUNIT_EXPECT_EQ(test, 0, slab_errors);
 | 
						|
}
 | 
						|
 | 
						|
static void test_leak_destroy(struct kunit *test)
 | 
						|
{
 | 
						|
	struct kmem_cache *s = test_kmem_cache_create("TestSlub_leak_destroy",
 | 
						|
							64, SLAB_NO_MERGE);
 | 
						|
	kmem_cache_alloc(s, GFP_KERNEL);
 | 
						|
 | 
						|
	kmem_cache_destroy(s);
 | 
						|
 | 
						|
	KUNIT_EXPECT_EQ(test, 2, slab_errors);
 | 
						|
}
 | 
						|
 | 
						|
static int test_init(struct kunit *test)
 | 
						|
{
 | 
						|
	slab_errors = 0;
 | 
						|
 | 
						|
	kunit_add_named_resource(test, NULL, NULL, &resource,
 | 
						|
					"slab_errors", &slab_errors);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static struct kunit_case test_cases[] = {
 | 
						|
	KUNIT_CASE(test_clobber_zone),
 | 
						|
 | 
						|
#ifndef CONFIG_KASAN
 | 
						|
	KUNIT_CASE(test_next_pointer),
 | 
						|
	KUNIT_CASE(test_first_word),
 | 
						|
	KUNIT_CASE(test_clobber_50th_byte),
 | 
						|
#endif
 | 
						|
 | 
						|
	KUNIT_CASE(test_clobber_redzone_free),
 | 
						|
	KUNIT_CASE(test_kmalloc_redzone_access),
 | 
						|
	KUNIT_CASE(test_kfree_rcu),
 | 
						|
	KUNIT_CASE(test_leak_destroy),
 | 
						|
	{}
 | 
						|
};
 | 
						|
 | 
						|
static struct kunit_suite test_suite = {
 | 
						|
	.name = "slub_test",
 | 
						|
	.init = test_init,
 | 
						|
	.test_cases = test_cases,
 | 
						|
};
 | 
						|
kunit_test_suite(test_suite);
 | 
						|
 | 
						|
MODULE_LICENSE("GPL");
 |