mirror of
https://github.com/torvalds/linux.git
synced 2025-11-03 18:20:25 +02:00
484fd6c1de
The function ext4_init_acl() calls posix_acl_create() which is responsible for applying the umask. But without CONFIG_EXT4_FS_POSIX_ACL, ext4_init_acl() is an empty inline function, and nobody applies the umask. This fixes a bug which causes the umask to be ignored with O_TMPFILE on ext4: https://github.com/MusicPlayerDaemon/MPD/issues/558 https://bugs.gentoo.org/show_bug.cgi?id=686142#c3 https://bugzilla.kernel.org/show_bug.cgi?id=203625 Reviewed-by: "J. Bruce Fields" <bfields@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Max Kellermann <max.kellermann@ionos.com> Link: https://lore.kernel.org/r/20230919081824.1096619-1-max.kellermann@ionos.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
79 lines
1.8 KiB
C
79 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
File: fs/ext4/acl.h
|
|
|
|
(C) 2001 Andreas Gruenbacher, <a.gruenbacher@computer.org>
|
|
*/
|
|
|
|
#include <linux/posix_acl_xattr.h>
|
|
|
|
#define EXT4_ACL_VERSION 0x0001
|
|
|
|
typedef struct {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
__le32 e_id;
|
|
} ext4_acl_entry;
|
|
|
|
typedef struct {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
} ext4_acl_entry_short;
|
|
|
|
typedef struct {
|
|
__le32 a_version;
|
|
} ext4_acl_header;
|
|
|
|
static inline size_t ext4_acl_size(int count)
|
|
{
|
|
if (count <= 4) {
|
|
return sizeof(ext4_acl_header) +
|
|
count * sizeof(ext4_acl_entry_short);
|
|
} else {
|
|
return sizeof(ext4_acl_header) +
|
|
4 * sizeof(ext4_acl_entry_short) +
|
|
(count - 4) * sizeof(ext4_acl_entry);
|
|
}
|
|
}
|
|
|
|
static inline int ext4_acl_count(size_t size)
|
|
{
|
|
ssize_t s;
|
|
size -= sizeof(ext4_acl_header);
|
|
s = size - 4 * sizeof(ext4_acl_entry_short);
|
|
if (s < 0) {
|
|
if (size % sizeof(ext4_acl_entry_short))
|
|
return -1;
|
|
return size / sizeof(ext4_acl_entry_short);
|
|
} else {
|
|
if (s % sizeof(ext4_acl_entry))
|
|
return -1;
|
|
return s / sizeof(ext4_acl_entry) + 4;
|
|
}
|
|
}
|
|
|
|
#ifdef CONFIG_EXT4_FS_POSIX_ACL
|
|
|
|
/* acl.c */
|
|
struct posix_acl *ext4_get_acl(struct inode *inode, int type, bool rcu);
|
|
int ext4_set_acl(struct mnt_idmap *idmap, struct dentry *dentry,
|
|
struct posix_acl *acl, int type);
|
|
extern int ext4_init_acl(handle_t *, struct inode *, struct inode *);
|
|
|
|
#else /* CONFIG_EXT4_FS_POSIX_ACL */
|
|
#include <linux/sched.h>
|
|
#define ext4_get_acl NULL
|
|
#define ext4_set_acl NULL
|
|
|
|
static inline int
|
|
ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
|
|
{
|
|
/* usually, the umask is applied by posix_acl_create(), but if
|
|
ext4 ACL support is disabled at compile time, we need to do
|
|
it here, because posix_acl_create() will never be called */
|
|
inode->i_mode &= ~current_umask();
|
|
|
|
return 0;
|
|
}
|
|
#endif /* CONFIG_EXT4_FS_POSIX_ACL */
|
|
|