mirror of
https://github.com/torvalds/linux.git
synced 2025-11-04 10:40:15 +02:00
3b201c9af7
When compiling with gcc version 14.0.0 20231220 (experimental)
and W=1, I've noticed a bunch of four similar warnings like:
drivers/base/regmap/regmap-ram.c: In function '__regmap_init_ram':
drivers/base/regmap/regmap-ram.c:68:37: warning: 'kcalloc' sizes specified with
'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
68 | data->read = kcalloc(sizeof(bool), config->max_register + 1,
| ^~~~
Since 'n' and 'size' arguments of 'kcalloc()' are multiplied to
calculate the final size, their actual order doesn't affect the
result and so this is not a bug. But it's still worth to fix it.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://msgid.link/r/20231220175829.533700-1-dmantipov@yandex.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
85 lines
1.8 KiB
C
85 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// Register map access API - Memory region
|
|
//
|
|
// This is intended for testing only
|
|
//
|
|
// Copyright (c) 2023, Arm Ltd
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/module.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/swab.h>
|
|
|
|
#include "internal.h"
|
|
|
|
static int regmap_ram_write(void *context, unsigned int reg, unsigned int val)
|
|
{
|
|
struct regmap_ram_data *data = context;
|
|
|
|
data->vals[reg] = val;
|
|
data->written[reg] = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int regmap_ram_read(void *context, unsigned int reg, unsigned int *val)
|
|
{
|
|
struct regmap_ram_data *data = context;
|
|
|
|
*val = data->vals[reg];
|
|
data->read[reg] = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void regmap_ram_free_context(void *context)
|
|
{
|
|
struct regmap_ram_data *data = context;
|
|
|
|
kfree(data->vals);
|
|
kfree(data->read);
|
|
kfree(data->written);
|
|
kfree(data);
|
|
}
|
|
|
|
static const struct regmap_bus regmap_ram = {
|
|
.fast_io = true,
|
|
.reg_write = regmap_ram_write,
|
|
.reg_read = regmap_ram_read,
|
|
.free_context = regmap_ram_free_context,
|
|
};
|
|
|
|
struct regmap *__regmap_init_ram(const struct regmap_config *config,
|
|
struct regmap_ram_data *data,
|
|
struct lock_class_key *lock_key,
|
|
const char *lock_name)
|
|
{
|
|
struct regmap *map;
|
|
|
|
if (!config->max_register) {
|
|
pr_crit("No max_register specified for RAM regmap\n");
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
data->read = kcalloc(config->max_register + 1, sizeof(bool),
|
|
GFP_KERNEL);
|
|
if (!data->read)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
data->written = kcalloc(config->max_register + 1, sizeof(bool),
|
|
GFP_KERNEL);
|
|
if (!data->written)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
map = __regmap_init(NULL, ®map_ram, data, config,
|
|
lock_key, lock_name);
|
|
|
|
return map;
|
|
}
|
|
EXPORT_SYMBOL_GPL(__regmap_init_ram);
|
|
|
|
MODULE_LICENSE("GPL v2");
|