mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	There are session cleanup problems in ax25_release() and ax25_disconnect(). If we setup a session and then disconnect, the disconnected session is still in "LISTENING" state that is shown below. Active AX.25 sockets Dest Source Device State Vr/Vs Send-Q Recv-Q DL9SAU-4 DL9SAU-3 ??? LISTENING 000/000 0 0 DL9SAU-3 DL9SAU-4 ??? LISTENING 000/000 0 0 The first reason is caused by del_timer_sync() in ax25_release(). The timers of ax25 are used for correct session cleanup. If we use ax25_release() to close ax25 sessions and ax25_dev is not null, the del_timer_sync() functions in ax25_release() will execute. As a result, the sessions could not be cleaned up correctly, because the timers have stopped. In order to solve this problem, this patch adds a device_up flag in ax25_dev in order to judge whether the device is up. If there are sessions to be cleaned up, the del_timer_sync() in ax25_release() will not execute. What's more, we add ax25_cb_del() in ax25_kill_by_device(), because the timers have been stopped and there are no functions that could delete ax25_cb if we do not call ax25_release(). Finally, we reorder the position of ax25_list_lock in ax25_cb_del() in order to synchronize among different functions that call ax25_cb_del(). The second reason is caused by improper check in ax25_disconnect(). The incoming ax25 sessions which ax25->sk is null will close heartbeat timer, because the check "if(!ax25->sk || ..)" is satisfied. As a result, the session could not be cleaned up properly. In order to solve this problem, this patch changes the improper check to "if(ax25->sk && ..)" in ax25_disconnect(). What`s more, the ax25_disconnect() may be called twice, which is not necessary. For example, ax25_kill_by_device() calls ax25_disconnect() and sets ax25->state to AX25_STATE_0, but ax25_release() calls ax25_disconnect() again. In order to solve this problem, this patch add a check in ax25_release(). If the flag of ax25->sk equals to SOCK_DEAD, the ax25_disconnect() in ax25_release() should not be executed. Fixes:82e31755e5("ax25: Fix UAF bugs in ax25 timers") Fixes:8a367e74c0("ax25: Fix segfault after sock connection timeout") Reported-and-tested-by: Thomas Osterried <thomas@osterried.de> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Link: https://lore.kernel.org/r/20220530152158.108619-1-duoming@zju.edu.cn Signed-off-by: Paolo Abeni <pabeni@redhat.com>
		
			
				
	
	
		
			214 lines
		
	
	
	
		
			5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			214 lines
		
	
	
	
		
			5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0-or-later
 | 
						|
/*
 | 
						|
 *
 | 
						|
 * Copyright (C) Jonathan Naylor G4KLX (g4klx@g4klx.demon.co.uk)
 | 
						|
 */
 | 
						|
#include <linux/errno.h>
 | 
						|
#include <linux/types.h>
 | 
						|
#include <linux/socket.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/in.h>
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/timer.h>
 | 
						|
#include <linux/string.h>
 | 
						|
#include <linux/sockios.h>
 | 
						|
#include <linux/net.h>
 | 
						|
#include <linux/spinlock.h>
 | 
						|
#include <net/ax25.h>
 | 
						|
#include <linux/inet.h>
 | 
						|
#include <linux/netdevice.h>
 | 
						|
#include <linux/if_arp.h>
 | 
						|
#include <linux/skbuff.h>
 | 
						|
#include <net/sock.h>
 | 
						|
#include <linux/uaccess.h>
 | 
						|
#include <linux/fcntl.h>
 | 
						|
#include <linux/mm.h>
 | 
						|
#include <linux/interrupt.h>
 | 
						|
#include <linux/init.h>
 | 
						|
 | 
						|
ax25_dev *ax25_dev_list;
 | 
						|
DEFINE_SPINLOCK(ax25_dev_lock);
 | 
						|
 | 
						|
ax25_dev *ax25_addr_ax25dev(ax25_address *addr)
 | 
						|
{
 | 
						|
	ax25_dev *ax25_dev, *res = NULL;
 | 
						|
 | 
						|
	spin_lock_bh(&ax25_dev_lock);
 | 
						|
	for (ax25_dev = ax25_dev_list; ax25_dev != NULL; ax25_dev = ax25_dev->next)
 | 
						|
		if (ax25cmp(addr, (const ax25_address *)ax25_dev->dev->dev_addr) == 0) {
 | 
						|
			res = ax25_dev;
 | 
						|
			ax25_dev_hold(ax25_dev);
 | 
						|
		}
 | 
						|
	spin_unlock_bh(&ax25_dev_lock);
 | 
						|
 | 
						|
	return res;
 | 
						|
}
 | 
						|
 | 
						|
/*
 | 
						|
 *	This is called when an interface is brought up. These are
 | 
						|
 *	reasonable defaults.
 | 
						|
 */
 | 
						|
void ax25_dev_device_up(struct net_device *dev)
 | 
						|
{
 | 
						|
	ax25_dev *ax25_dev;
 | 
						|
 | 
						|
	if ((ax25_dev = kzalloc(sizeof(*ax25_dev), GFP_ATOMIC)) == NULL) {
 | 
						|
		printk(KERN_ERR "AX.25: ax25_dev_device_up - out of memory\n");
 | 
						|
		return;
 | 
						|
	}
 | 
						|
 | 
						|
	refcount_set(&ax25_dev->refcount, 1);
 | 
						|
	dev->ax25_ptr     = ax25_dev;
 | 
						|
	ax25_dev->dev     = dev;
 | 
						|
	dev_hold_track(dev, &ax25_dev->dev_tracker, GFP_ATOMIC);
 | 
						|
	ax25_dev->forward = NULL;
 | 
						|
	ax25_dev->device_up = true;
 | 
						|
 | 
						|
	ax25_dev->values[AX25_VALUES_IPDEFMODE] = AX25_DEF_IPDEFMODE;
 | 
						|
	ax25_dev->values[AX25_VALUES_AXDEFMODE] = AX25_DEF_AXDEFMODE;
 | 
						|
	ax25_dev->values[AX25_VALUES_BACKOFF]   = AX25_DEF_BACKOFF;
 | 
						|
	ax25_dev->values[AX25_VALUES_CONMODE]   = AX25_DEF_CONMODE;
 | 
						|
	ax25_dev->values[AX25_VALUES_WINDOW]    = AX25_DEF_WINDOW;
 | 
						|
	ax25_dev->values[AX25_VALUES_EWINDOW]   = AX25_DEF_EWINDOW;
 | 
						|
	ax25_dev->values[AX25_VALUES_T1]        = AX25_DEF_T1;
 | 
						|
	ax25_dev->values[AX25_VALUES_T2]        = AX25_DEF_T2;
 | 
						|
	ax25_dev->values[AX25_VALUES_T3]        = AX25_DEF_T3;
 | 
						|
	ax25_dev->values[AX25_VALUES_IDLE]	= AX25_DEF_IDLE;
 | 
						|
	ax25_dev->values[AX25_VALUES_N2]        = AX25_DEF_N2;
 | 
						|
	ax25_dev->values[AX25_VALUES_PACLEN]	= AX25_DEF_PACLEN;
 | 
						|
	ax25_dev->values[AX25_VALUES_PROTOCOL]  = AX25_DEF_PROTOCOL;
 | 
						|
	ax25_dev->values[AX25_VALUES_DS_TIMEOUT]= AX25_DEF_DS_TIMEOUT;
 | 
						|
 | 
						|
#if defined(CONFIG_AX25_DAMA_SLAVE) || defined(CONFIG_AX25_DAMA_MASTER)
 | 
						|
	ax25_ds_setup_timer(ax25_dev);
 | 
						|
#endif
 | 
						|
 | 
						|
	spin_lock_bh(&ax25_dev_lock);
 | 
						|
	ax25_dev->next = ax25_dev_list;
 | 
						|
	ax25_dev_list  = ax25_dev;
 | 
						|
	spin_unlock_bh(&ax25_dev_lock);
 | 
						|
	ax25_dev_hold(ax25_dev);
 | 
						|
 | 
						|
	ax25_register_dev_sysctl(ax25_dev);
 | 
						|
}
 | 
						|
 | 
						|
void ax25_dev_device_down(struct net_device *dev)
 | 
						|
{
 | 
						|
	ax25_dev *s, *ax25_dev;
 | 
						|
 | 
						|
	if ((ax25_dev = ax25_dev_ax25dev(dev)) == NULL)
 | 
						|
		return;
 | 
						|
 | 
						|
	ax25_unregister_dev_sysctl(ax25_dev);
 | 
						|
 | 
						|
	spin_lock_bh(&ax25_dev_lock);
 | 
						|
 | 
						|
#ifdef CONFIG_AX25_DAMA_SLAVE
 | 
						|
	ax25_ds_del_timer(ax25_dev);
 | 
						|
#endif
 | 
						|
 | 
						|
	/*
 | 
						|
	 *	Remove any packet forwarding that points to this device.
 | 
						|
	 */
 | 
						|
	for (s = ax25_dev_list; s != NULL; s = s->next)
 | 
						|
		if (s->forward == dev)
 | 
						|
			s->forward = NULL;
 | 
						|
 | 
						|
	if ((s = ax25_dev_list) == ax25_dev) {
 | 
						|
		ax25_dev_list = s->next;
 | 
						|
		goto unlock_put;
 | 
						|
	}
 | 
						|
 | 
						|
	while (s != NULL && s->next != NULL) {
 | 
						|
		if (s->next == ax25_dev) {
 | 
						|
			s->next = ax25_dev->next;
 | 
						|
			goto unlock_put;
 | 
						|
		}
 | 
						|
 | 
						|
		s = s->next;
 | 
						|
	}
 | 
						|
	spin_unlock_bh(&ax25_dev_lock);
 | 
						|
	dev->ax25_ptr = NULL;
 | 
						|
	ax25_dev_put(ax25_dev);
 | 
						|
	return;
 | 
						|
 | 
						|
unlock_put:
 | 
						|
	spin_unlock_bh(&ax25_dev_lock);
 | 
						|
	ax25_dev_put(ax25_dev);
 | 
						|
	dev->ax25_ptr = NULL;
 | 
						|
	dev_put_track(dev, &ax25_dev->dev_tracker);
 | 
						|
	ax25_dev_put(ax25_dev);
 | 
						|
}
 | 
						|
 | 
						|
int ax25_fwd_ioctl(unsigned int cmd, struct ax25_fwd_struct *fwd)
 | 
						|
{
 | 
						|
	ax25_dev *ax25_dev, *fwd_dev;
 | 
						|
 | 
						|
	if ((ax25_dev = ax25_addr_ax25dev(&fwd->port_from)) == NULL)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	switch (cmd) {
 | 
						|
	case SIOCAX25ADDFWD:
 | 
						|
		fwd_dev = ax25_addr_ax25dev(&fwd->port_to);
 | 
						|
		if (!fwd_dev) {
 | 
						|
			ax25_dev_put(ax25_dev);
 | 
						|
			return -EINVAL;
 | 
						|
		}
 | 
						|
		if (ax25_dev->forward) {
 | 
						|
			ax25_dev_put(fwd_dev);
 | 
						|
			ax25_dev_put(ax25_dev);
 | 
						|
			return -EINVAL;
 | 
						|
		}
 | 
						|
		ax25_dev->forward = fwd_dev->dev;
 | 
						|
		ax25_dev_put(fwd_dev);
 | 
						|
		ax25_dev_put(ax25_dev);
 | 
						|
		break;
 | 
						|
 | 
						|
	case SIOCAX25DELFWD:
 | 
						|
		if (!ax25_dev->forward) {
 | 
						|
			ax25_dev_put(ax25_dev);
 | 
						|
			return -EINVAL;
 | 
						|
		}
 | 
						|
		ax25_dev->forward = NULL;
 | 
						|
		ax25_dev_put(ax25_dev);
 | 
						|
		break;
 | 
						|
 | 
						|
	default:
 | 
						|
		ax25_dev_put(ax25_dev);
 | 
						|
		return -EINVAL;
 | 
						|
	}
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
struct net_device *ax25_fwd_dev(struct net_device *dev)
 | 
						|
{
 | 
						|
	ax25_dev *ax25_dev;
 | 
						|
 | 
						|
	if ((ax25_dev = ax25_dev_ax25dev(dev)) == NULL)
 | 
						|
		return dev;
 | 
						|
 | 
						|
	if (ax25_dev->forward == NULL)
 | 
						|
		return dev;
 | 
						|
 | 
						|
	return ax25_dev->forward;
 | 
						|
}
 | 
						|
 | 
						|
/*
 | 
						|
 *	Free all memory associated with device structures.
 | 
						|
 */
 | 
						|
void __exit ax25_dev_free(void)
 | 
						|
{
 | 
						|
	ax25_dev *s, *ax25_dev;
 | 
						|
 | 
						|
	spin_lock_bh(&ax25_dev_lock);
 | 
						|
	ax25_dev = ax25_dev_list;
 | 
						|
	while (ax25_dev != NULL) {
 | 
						|
		s        = ax25_dev;
 | 
						|
		dev_put_track(ax25_dev->dev, &ax25_dev->dev_tracker);
 | 
						|
		ax25_dev = ax25_dev->next;
 | 
						|
		kfree(s);
 | 
						|
	}
 | 
						|
	ax25_dev_list = NULL;
 | 
						|
	spin_unlock_bh(&ax25_dev_lock);
 | 
						|
}
 |