mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	As by now, platform::Device is implemented as:
	#[derive(Clone)]
	pub struct Device(ARef<device::Device>);
This may be convenient, but has the implication that drivers can call
device methods that require a mutable reference concurrently at any
point of time.
Instead define platform::Device as
	pub struct Device<Ctx: DeviceContext = Normal>(
		Opaque<bindings::platform_dev>,
		PhantomData<Ctx>,
	);
and manually implement the AlwaysRefCounted trait.
With this we can implement methods that should only be called from
bus callbacks (such as probe()) for platform::Device<Core>. Consequently,
we make this type accessible in bus callbacks only.
Arbitrary references taken by the driver are still of type
ARef<platform::Device> and hence don't provide access to methods that are
reserved for bus callbacks.
Fixes: 683a63befc ("rust: platform: add basic platform device / driver abstractions")
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250314160932.100165-5-dakr@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
		
	
			
		
			
				
	
	
		
			235 lines
		
	
	
	
		
			7.3 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			235 lines
		
	
	
	
		
			7.3 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0
 | 
						|
 | 
						|
//! Abstractions for the platform bus.
 | 
						|
//!
 | 
						|
//! C header: [`include/linux/platform_device.h`](srctree/include/linux/platform_device.h)
 | 
						|
 | 
						|
use crate::{
 | 
						|
    bindings, device, driver,
 | 
						|
    error::{to_result, Result},
 | 
						|
    of,
 | 
						|
    prelude::*,
 | 
						|
    str::CStr,
 | 
						|
    types::{ARef, ForeignOwnable, Opaque},
 | 
						|
    ThisModule,
 | 
						|
};
 | 
						|
 | 
						|
use core::{
 | 
						|
    marker::PhantomData,
 | 
						|
    ops::Deref,
 | 
						|
    ptr::{addr_of_mut, NonNull},
 | 
						|
};
 | 
						|
 | 
						|
/// An adapter for the registration of platform drivers.
 | 
						|
pub struct Adapter<T: Driver>(T);
 | 
						|
 | 
						|
// SAFETY: A call to `unregister` for a given instance of `RegType` is guaranteed to be valid if
 | 
						|
// a preceding call to `register` has been successful.
 | 
						|
unsafe impl<T: Driver + 'static> driver::RegistrationOps for Adapter<T> {
 | 
						|
    type RegType = bindings::platform_driver;
 | 
						|
 | 
						|
    unsafe fn register(
 | 
						|
        pdrv: &Opaque<Self::RegType>,
 | 
						|
        name: &'static CStr,
 | 
						|
        module: &'static ThisModule,
 | 
						|
    ) -> Result {
 | 
						|
        let of_table = match T::OF_ID_TABLE {
 | 
						|
            Some(table) => table.as_ptr(),
 | 
						|
            None => core::ptr::null(),
 | 
						|
        };
 | 
						|
 | 
						|
        // SAFETY: It's safe to set the fields of `struct platform_driver` on initialization.
 | 
						|
        unsafe {
 | 
						|
            (*pdrv.get()).driver.name = name.as_char_ptr();
 | 
						|
            (*pdrv.get()).probe = Some(Self::probe_callback);
 | 
						|
            (*pdrv.get()).remove = Some(Self::remove_callback);
 | 
						|
            (*pdrv.get()).driver.of_match_table = of_table;
 | 
						|
        }
 | 
						|
 | 
						|
        // SAFETY: `pdrv` is guaranteed to be a valid `RegType`.
 | 
						|
        to_result(unsafe { bindings::__platform_driver_register(pdrv.get(), module.0) })
 | 
						|
    }
 | 
						|
 | 
						|
    unsafe fn unregister(pdrv: &Opaque<Self::RegType>) {
 | 
						|
        // SAFETY: `pdrv` is guaranteed to be a valid `RegType`.
 | 
						|
        unsafe { bindings::platform_driver_unregister(pdrv.get()) };
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
impl<T: Driver + 'static> Adapter<T> {
 | 
						|
    extern "C" fn probe_callback(pdev: *mut bindings::platform_device) -> kernel::ffi::c_int {
 | 
						|
        // SAFETY: The platform bus only ever calls the probe callback with a valid pointer to a
 | 
						|
        // `struct platform_device`.
 | 
						|
        //
 | 
						|
        // INVARIANT: `pdev` is valid for the duration of `probe_callback()`.
 | 
						|
        let pdev = unsafe { &*pdev.cast::<Device<device::Core>>() };
 | 
						|
 | 
						|
        let info = <Self as driver::Adapter>::id_info(pdev.as_ref());
 | 
						|
        match T::probe(pdev, info) {
 | 
						|
            Ok(data) => {
 | 
						|
                // Let the `struct platform_device` own a reference of the driver's private data.
 | 
						|
                // SAFETY: By the type invariant `pdev.as_raw` returns a valid pointer to a
 | 
						|
                // `struct platform_device`.
 | 
						|
                unsafe { bindings::platform_set_drvdata(pdev.as_raw(), data.into_foreign() as _) };
 | 
						|
            }
 | 
						|
            Err(err) => return Error::to_errno(err),
 | 
						|
        }
 | 
						|
 | 
						|
        0
 | 
						|
    }
 | 
						|
 | 
						|
    extern "C" fn remove_callback(pdev: *mut bindings::platform_device) {
 | 
						|
        // SAFETY: `pdev` is a valid pointer to a `struct platform_device`.
 | 
						|
        let ptr = unsafe { bindings::platform_get_drvdata(pdev) };
 | 
						|
 | 
						|
        // SAFETY: `remove_callback` is only ever called after a successful call to
 | 
						|
        // `probe_callback`, hence it's guaranteed that `ptr` points to a valid and initialized
 | 
						|
        // `KBox<T>` pointer created through `KBox::into_foreign`.
 | 
						|
        let _ = unsafe { KBox::<T>::from_foreign(ptr) };
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
impl<T: Driver + 'static> driver::Adapter for Adapter<T> {
 | 
						|
    type IdInfo = T::IdInfo;
 | 
						|
 | 
						|
    fn of_id_table() -> Option<of::IdTable<Self::IdInfo>> {
 | 
						|
        T::OF_ID_TABLE
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
/// Declares a kernel module that exposes a single platform driver.
 | 
						|
///
 | 
						|
/// # Examples
 | 
						|
///
 | 
						|
/// ```ignore
 | 
						|
/// kernel::module_platform_driver! {
 | 
						|
///     type: MyDriver,
 | 
						|
///     name: "Module name",
 | 
						|
///     author: "Author name",
 | 
						|
///     description: "Description",
 | 
						|
///     license: "GPL v2",
 | 
						|
/// }
 | 
						|
/// ```
 | 
						|
#[macro_export]
 | 
						|
macro_rules! module_platform_driver {
 | 
						|
    ($($f:tt)*) => {
 | 
						|
        $crate::module_driver!(<T>, $crate::platform::Adapter<T>, { $($f)* });
 | 
						|
    };
 | 
						|
}
 | 
						|
 | 
						|
/// The platform driver trait.
 | 
						|
///
 | 
						|
/// Drivers must implement this trait in order to get a platform driver registered.
 | 
						|
///
 | 
						|
/// # Example
 | 
						|
///
 | 
						|
///```
 | 
						|
/// # use kernel::{bindings, c_str, device::Core, of, platform};
 | 
						|
///
 | 
						|
/// struct MyDriver;
 | 
						|
///
 | 
						|
/// kernel::of_device_table!(
 | 
						|
///     OF_TABLE,
 | 
						|
///     MODULE_OF_TABLE,
 | 
						|
///     <MyDriver as platform::Driver>::IdInfo,
 | 
						|
///     [
 | 
						|
///         (of::DeviceId::new(c_str!("test,device")), ())
 | 
						|
///     ]
 | 
						|
/// );
 | 
						|
///
 | 
						|
/// impl platform::Driver for MyDriver {
 | 
						|
///     type IdInfo = ();
 | 
						|
///     const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>> = Some(&OF_TABLE);
 | 
						|
///
 | 
						|
///     fn probe(
 | 
						|
///         _pdev: &platform::Device<Core>,
 | 
						|
///         _id_info: Option<&Self::IdInfo>,
 | 
						|
///     ) -> Result<Pin<KBox<Self>>> {
 | 
						|
///         Err(ENODEV)
 | 
						|
///     }
 | 
						|
/// }
 | 
						|
///```
 | 
						|
pub trait Driver {
 | 
						|
    /// The type holding driver private data about each device id supported by the driver.
 | 
						|
    ///
 | 
						|
    /// TODO: Use associated_type_defaults once stabilized:
 | 
						|
    ///
 | 
						|
    /// type IdInfo: 'static = ();
 | 
						|
    type IdInfo: 'static;
 | 
						|
 | 
						|
    /// The table of OF device ids supported by the driver.
 | 
						|
    const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>>;
 | 
						|
 | 
						|
    /// Platform driver probe.
 | 
						|
    ///
 | 
						|
    /// Called when a new platform device is added or discovered.
 | 
						|
    /// Implementers should attempt to initialize the device here.
 | 
						|
    fn probe(dev: &Device<device::Core>, id_info: Option<&Self::IdInfo>)
 | 
						|
        -> Result<Pin<KBox<Self>>>;
 | 
						|
}
 | 
						|
 | 
						|
/// The platform device representation.
 | 
						|
///
 | 
						|
/// This structure represents the Rust abstraction for a C `struct platform_device`. The
 | 
						|
/// implementation abstracts the usage of an already existing C `struct platform_device` within Rust
 | 
						|
/// code that we get passed from the C side.
 | 
						|
///
 | 
						|
/// # Invariants
 | 
						|
///
 | 
						|
/// A [`Device`] instance represents a valid `struct platform_device` created by the C portion of
 | 
						|
/// the kernel.
 | 
						|
#[repr(transparent)]
 | 
						|
pub struct Device<Ctx: device::DeviceContext = device::Normal>(
 | 
						|
    Opaque<bindings::platform_device>,
 | 
						|
    PhantomData<Ctx>,
 | 
						|
);
 | 
						|
 | 
						|
impl Device {
 | 
						|
    fn as_raw(&self) -> *mut bindings::platform_device {
 | 
						|
        self.0.get()
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
impl Deref for Device<device::Core> {
 | 
						|
    type Target = Device;
 | 
						|
 | 
						|
    fn deref(&self) -> &Self::Target {
 | 
						|
        let ptr: *const Self = self;
 | 
						|
 | 
						|
        // CAST: `Device<Ctx>` is a transparent wrapper of `Opaque<bindings::platform_device>`.
 | 
						|
        let ptr = ptr.cast::<Device>();
 | 
						|
 | 
						|
        // SAFETY: `ptr` was derived from `&self`.
 | 
						|
        unsafe { &*ptr }
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
impl From<&Device<device::Core>> for ARef<Device> {
 | 
						|
    fn from(dev: &Device<device::Core>) -> Self {
 | 
						|
        (&**dev).into()
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
// SAFETY: Instances of `Device` are always reference-counted.
 | 
						|
unsafe impl crate::types::AlwaysRefCounted for Device {
 | 
						|
    fn inc_ref(&self) {
 | 
						|
        // SAFETY: The existence of a shared reference guarantees that the refcount is non-zero.
 | 
						|
        unsafe { bindings::get_device(self.as_ref().as_raw()) };
 | 
						|
    }
 | 
						|
 | 
						|
    unsafe fn dec_ref(obj: NonNull<Self>) {
 | 
						|
        // SAFETY: The safety requirements guarantee that the refcount is non-zero.
 | 
						|
        unsafe { bindings::platform_device_put(obj.cast().as_ptr()) }
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
impl AsRef<device::Device> for Device {
 | 
						|
    fn as_ref(&self) -> &device::Device {
 | 
						|
        // SAFETY: By the type invariant of `Self`, `self.as_raw()` is a pointer to a valid
 | 
						|
        // `struct platform_device`.
 | 
						|
        let dev = unsafe { addr_of_mut!((*self.as_raw()).dev) };
 | 
						|
 | 
						|
        // SAFETY: `dev` points to a valid `struct device`.
 | 
						|
        unsafe { device::Device::as_ref(dev) }
 | 
						|
    }
 | 
						|
}
 |