mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	OpenVZ Linux kernel team has discovered the problem with 32bit quota tools
working on 64bit architectures.  In 2.6.10 kernel sys32_quotactl() function
was replaced by sys_quotactl() with the comment "sys_quotactl seems to be
32/64bit clean, enable it for 32bit" However this isn't right.  Look at
if_dqblk structure:
struct if_dqblk {
        __u64 dqb_bhardlimit;
        __u64 dqb_bsoftlimit;
        __u64 dqb_curspace;
        __u64 dqb_ihardlimit;
        __u64 dqb_isoftlimit;
        __u64 dqb_curinodes;
        __u64 dqb_btime;
        __u64 dqb_itime;
        __u32 dqb_valid;
};
For 32 bit quota tools sizeof(if_dqblk) == 0x44.
But for 64 bit kernel its size is 0x48, 'cause of alignment!
Thus we got a problem. Attached patch reintroduce sys32_quotactl() function,
that handles this and related situations.
[michal.k.k.piotrowski@gmail.com: build fix]
[akpm@linux-foundation.org: Make it link with CONFIG_QUOTA=n]
Signed-off-by: Vasily Tarasov <vtaras@openvz.org>
Cc: Andi Kleen <ak@suse.de>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
	
			
		
			
				
	
	
		
			151 lines
		
	
	
	
		
			4.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			151 lines
		
	
	
	
		
			4.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
 | 
						|
#include <linux/linkage.h>
 | 
						|
#include <linux/errno.h>
 | 
						|
 | 
						|
#include <asm/unistd.h>
 | 
						|
 | 
						|
/*
 | 
						|
 * Non-implemented system calls get redirected here.
 | 
						|
 */
 | 
						|
asmlinkage long sys_ni_syscall(void)
 | 
						|
{
 | 
						|
	return -ENOSYS;
 | 
						|
}
 | 
						|
 | 
						|
cond_syscall(sys_nfsservctl);
 | 
						|
cond_syscall(sys_quotactl);
 | 
						|
cond_syscall(sys32_quotactl);
 | 
						|
cond_syscall(sys_acct);
 | 
						|
cond_syscall(sys_lookup_dcookie);
 | 
						|
cond_syscall(sys_swapon);
 | 
						|
cond_syscall(sys_swapoff);
 | 
						|
cond_syscall(sys_kexec_load);
 | 
						|
cond_syscall(compat_sys_kexec_load);
 | 
						|
cond_syscall(sys_init_module);
 | 
						|
cond_syscall(sys_delete_module);
 | 
						|
cond_syscall(sys_socketpair);
 | 
						|
cond_syscall(sys_bind);
 | 
						|
cond_syscall(sys_listen);
 | 
						|
cond_syscall(sys_accept);
 | 
						|
cond_syscall(sys_connect);
 | 
						|
cond_syscall(sys_getsockname);
 | 
						|
cond_syscall(sys_getpeername);
 | 
						|
cond_syscall(sys_sendto);
 | 
						|
cond_syscall(sys_send);
 | 
						|
cond_syscall(sys_recvfrom);
 | 
						|
cond_syscall(sys_recv);
 | 
						|
cond_syscall(sys_socket);
 | 
						|
cond_syscall(sys_setsockopt);
 | 
						|
cond_syscall(sys_getsockopt);
 | 
						|
cond_syscall(sys_shutdown);
 | 
						|
cond_syscall(sys_sendmsg);
 | 
						|
cond_syscall(sys_recvmsg);
 | 
						|
cond_syscall(sys_socketcall);
 | 
						|
cond_syscall(sys_futex);
 | 
						|
cond_syscall(compat_sys_futex);
 | 
						|
cond_syscall(sys_set_robust_list);
 | 
						|
cond_syscall(compat_sys_set_robust_list);
 | 
						|
cond_syscall(sys_get_robust_list);
 | 
						|
cond_syscall(compat_sys_get_robust_list);
 | 
						|
cond_syscall(sys_epoll_create);
 | 
						|
cond_syscall(sys_epoll_ctl);
 | 
						|
cond_syscall(sys_epoll_wait);
 | 
						|
cond_syscall(sys_epoll_pwait);
 | 
						|
cond_syscall(sys_semget);
 | 
						|
cond_syscall(sys_semop);
 | 
						|
cond_syscall(sys_semtimedop);
 | 
						|
cond_syscall(sys_semctl);
 | 
						|
cond_syscall(sys_msgget);
 | 
						|
cond_syscall(sys_msgsnd);
 | 
						|
cond_syscall(sys_msgrcv);
 | 
						|
cond_syscall(sys_msgctl);
 | 
						|
cond_syscall(sys_shmget);
 | 
						|
cond_syscall(sys_shmat);
 | 
						|
cond_syscall(sys_shmdt);
 | 
						|
cond_syscall(sys_shmctl);
 | 
						|
cond_syscall(sys_mq_open);
 | 
						|
cond_syscall(sys_mq_unlink);
 | 
						|
cond_syscall(sys_mq_timedsend);
 | 
						|
cond_syscall(sys_mq_timedreceive);
 | 
						|
cond_syscall(sys_mq_notify);
 | 
						|
cond_syscall(sys_mq_getsetattr);
 | 
						|
cond_syscall(compat_sys_mq_open);
 | 
						|
cond_syscall(compat_sys_mq_timedsend);
 | 
						|
cond_syscall(compat_sys_mq_timedreceive);
 | 
						|
cond_syscall(compat_sys_mq_notify);
 | 
						|
cond_syscall(compat_sys_mq_getsetattr);
 | 
						|
cond_syscall(sys_mbind);
 | 
						|
cond_syscall(sys_get_mempolicy);
 | 
						|
cond_syscall(sys_set_mempolicy);
 | 
						|
cond_syscall(compat_sys_mbind);
 | 
						|
cond_syscall(compat_sys_get_mempolicy);
 | 
						|
cond_syscall(compat_sys_set_mempolicy);
 | 
						|
cond_syscall(sys_add_key);
 | 
						|
cond_syscall(sys_request_key);
 | 
						|
cond_syscall(sys_keyctl);
 | 
						|
cond_syscall(compat_sys_keyctl);
 | 
						|
cond_syscall(compat_sys_socketcall);
 | 
						|
cond_syscall(sys_inotify_init);
 | 
						|
cond_syscall(sys_inotify_add_watch);
 | 
						|
cond_syscall(sys_inotify_rm_watch);
 | 
						|
cond_syscall(sys_migrate_pages);
 | 
						|
cond_syscall(sys_move_pages);
 | 
						|
cond_syscall(sys_chown16);
 | 
						|
cond_syscall(sys_fchown16);
 | 
						|
cond_syscall(sys_getegid16);
 | 
						|
cond_syscall(sys_geteuid16);
 | 
						|
cond_syscall(sys_getgid16);
 | 
						|
cond_syscall(sys_getgroups16);
 | 
						|
cond_syscall(sys_getresgid16);
 | 
						|
cond_syscall(sys_getresuid16);
 | 
						|
cond_syscall(sys_getuid16);
 | 
						|
cond_syscall(sys_lchown16);
 | 
						|
cond_syscall(sys_setfsgid16);
 | 
						|
cond_syscall(sys_setfsuid16);
 | 
						|
cond_syscall(sys_setgid16);
 | 
						|
cond_syscall(sys_setgroups16);
 | 
						|
cond_syscall(sys_setregid16);
 | 
						|
cond_syscall(sys_setresgid16);
 | 
						|
cond_syscall(sys_setresuid16);
 | 
						|
cond_syscall(sys_setreuid16);
 | 
						|
cond_syscall(sys_setuid16);
 | 
						|
cond_syscall(sys_vm86old);
 | 
						|
cond_syscall(sys_vm86);
 | 
						|
cond_syscall(compat_sys_ipc);
 | 
						|
cond_syscall(compat_sys_sysctl);
 | 
						|
 | 
						|
/* arch-specific weak syscall entries */
 | 
						|
cond_syscall(sys_pciconfig_read);
 | 
						|
cond_syscall(sys_pciconfig_write);
 | 
						|
cond_syscall(sys_pciconfig_iobase);
 | 
						|
cond_syscall(sys32_ipc);
 | 
						|
cond_syscall(sys32_sysctl);
 | 
						|
cond_syscall(ppc_rtas);
 | 
						|
cond_syscall(sys_spu_run);
 | 
						|
cond_syscall(sys_spu_create);
 | 
						|
 | 
						|
/* mmu depending weak syscall entries */
 | 
						|
cond_syscall(sys_mprotect);
 | 
						|
cond_syscall(sys_msync);
 | 
						|
cond_syscall(sys_mlock);
 | 
						|
cond_syscall(sys_munlock);
 | 
						|
cond_syscall(sys_mlockall);
 | 
						|
cond_syscall(sys_munlockall);
 | 
						|
cond_syscall(sys_mincore);
 | 
						|
cond_syscall(sys_madvise);
 | 
						|
cond_syscall(sys_mremap);
 | 
						|
cond_syscall(sys_remap_file_pages);
 | 
						|
cond_syscall(compat_sys_move_pages);
 | 
						|
cond_syscall(compat_sys_migrate_pages);
 | 
						|
 | 
						|
/* block-layer dependent */
 | 
						|
cond_syscall(sys_bdflush);
 | 
						|
cond_syscall(sys_ioprio_set);
 | 
						|
cond_syscall(sys_ioprio_get);
 | 
						|
 | 
						|
/* New file descriptors */
 | 
						|
cond_syscall(sys_signalfd);
 | 
						|
cond_syscall(sys_timerfd);
 | 
						|
cond_syscall(compat_sys_signalfd);
 | 
						|
cond_syscall(compat_sys_timerfd);
 | 
						|
cond_syscall(sys_eventfd);
 |