mirrors/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-11-04 10:40:15 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/net/hyperv
History
Saurabh Sengar 3ec5233049 hv_netvsc: fix potential deadlock in netvsc_vf_setxdp() 
The MANA driver's probe registers netdevice via the following call chain:

mana_probe()
  register_netdev()
    register_netdevice()

register_netdevice() calls notifier callback for netvsc driver,
holding the netdev mutex via netdev_lock_ops().

Further this netvsc notifier callback end up attempting to acquire the
same lock again in dev_xdp_propagate() leading to deadlock.

netvsc_netdev_event()
  netvsc_vf_setxdp()
    dev_xdp_propagate()

This deadlock was not observed so far because net_shaper_ops was never set,
and thus the lock was effectively a no-op in this case. Fix this by using
netif_xdp_propagate() instead of dev_xdp_propagate() to avoid recursive
locking in this path.

And, since no deadlock is observed on the other path which is via
netvsc_probe, add the lock exclusivly for that path.

Also, clean up the unregistration path by removing the unnecessary call to
netvsc_vf_setxdp(), since unregister_netdevice_many_notify() already
performs this cleanup via dev_xdp_uninstall().

Fixes: 97246d6d21 ("net: hold netdev instance lock during ndo_bpf")
Cc: stable@vger.kernel.org
Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Tested-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
Link: https://patch.msgid.link/1748513910-23963-1-git-send-email-ssengar@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-05-30 19:31:25 -07:00
..
hyperv_net.h hv_netvsc: Remove rmsg_pgcnt 2025-05-14 19:45:24 -07:00
Kconfig hv_netvsc: rndis_filter needs to select NLS 2023-12-01 20:12:24 -08:00
Makefile
netvsc.c hv_netvsc: Remove rmsg_pgcnt 2025-05-14 19:45:24 -07:00
netvsc_bpf.c hv_netvsc: fix potential deadlock in netvsc_vf_setxdp() 2025-05-30 19:31:25 -07:00
netvsc_drv.c hv_netvsc: fix potential deadlock in netvsc_vf_setxdp() 2025-05-30 19:31:25 -07:00
netvsc_trace.c
netvsc_trace.h tracing/treewide: Remove second parameter of __assign_str() 2024-05-22 20:14:47 -04:00
rndis_filter.c hv_netvsc: Preserve contiguous PFN grouping in the page buffer array 2025-05-14 19:45:24 -07:00