mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	This fixes: [    0.010000] cpu cpu0: Error -2 creating of_node link
... which you get for every CPU on all architectures that use
CONFIG_GENERIC_CPU_DEVICES.
In that case, driver_init() calls cpu_dev_init() before calling
of_core_init(). Then we get the callchain:
  cpu_dev_init()
    -> cpu_dev_register_generic()
    -> register_cpu(cpu, i)
    -> device_register(&cpu->dev)
    -> device_add(dev)
    -> device_add_class_symlinks(dev)
... in device_add_class_symlinks, we we dev->of_node, and call
sysfs_create_link(), which fails because we haven't called
of_core_init() to register the sysfs devicetree directory yet.
Signed-off-by: Wesley W. Terpstra <wesley@sifive.com>
[hch: updated the changelog based on review feedback]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
		
	
			
		
			
				
	
	
		
			38 lines
		
	
	
	
		
			768 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			38 lines
		
	
	
	
		
			768 B
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0
 | 
						|
/*
 | 
						|
 * Copyright (c) 2002-3 Patrick Mochel
 | 
						|
 * Copyright (c) 2002-3 Open Source Development Labs
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/device.h>
 | 
						|
#include <linux/init.h>
 | 
						|
#include <linux/memory.h>
 | 
						|
#include <linux/of.h>
 | 
						|
 | 
						|
#include "base.h"
 | 
						|
 | 
						|
/**
 | 
						|
 * driver_init - initialize driver model.
 | 
						|
 *
 | 
						|
 * Call the driver model init functions to initialize their
 | 
						|
 * subsystems. Called early from init/main.c.
 | 
						|
 */
 | 
						|
void __init driver_init(void)
 | 
						|
{
 | 
						|
	/* These are the core pieces */
 | 
						|
	devtmpfs_init();
 | 
						|
	devices_init();
 | 
						|
	buses_init();
 | 
						|
	classes_init();
 | 
						|
	firmware_init();
 | 
						|
	hypervisor_init();
 | 
						|
 | 
						|
	/* These are also core pieces, but must come after the
 | 
						|
	 * core core pieces.
 | 
						|
	 */
 | 
						|
	of_core_init();
 | 
						|
	platform_bus_init();
 | 
						|
	cpu_dev_init();
 | 
						|
	memory_dev_init();
 | 
						|
	container_dev_init();
 | 
						|
}
 |