mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
        kzalloc(a * b, gfp)
with:
        kcalloc(a * b, gfp)
as well as handling cases of:
        kzalloc(a * b * c, gfp)
with:
        kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
        kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
        kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
  kzalloc(
-	(sizeof(TYPE)) * E
+	sizeof(TYPE) * E
  , ...)
|
  kzalloc(
-	(sizeof(THING)) * E
+	sizeof(THING) * E
  , ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
  kzalloc(
-	sizeof(u8) * (COUNT)
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(__u8) * (COUNT)
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(char) * (COUNT)
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(unsigned char) * (COUNT)
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(u8) * COUNT
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(__u8) * COUNT
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(char) * COUNT
+	COUNT
  , ...)
|
  kzalloc(
-	sizeof(unsigned char) * COUNT
+	COUNT
  , ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
  (
-	sizeof(TYPE) * (COUNT_ID)
+	COUNT_ID, sizeof(TYPE)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(TYPE) * COUNT_ID
+	COUNT_ID, sizeof(TYPE)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(TYPE) * (COUNT_CONST)
+	COUNT_CONST, sizeof(TYPE)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(TYPE) * COUNT_CONST
+	COUNT_CONST, sizeof(TYPE)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(THING) * (COUNT_ID)
+	COUNT_ID, sizeof(THING)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(THING) * COUNT_ID
+	COUNT_ID, sizeof(THING)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(THING) * (COUNT_CONST)
+	COUNT_CONST, sizeof(THING)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(THING) * COUNT_CONST
+	COUNT_CONST, sizeof(THING)
  , ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
  (
-	SIZE * COUNT
+	COUNT, SIZE
  , ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
  kzalloc(
-	sizeof(TYPE) * (COUNT) * (STRIDE)
+	array3_size(COUNT, STRIDE, sizeof(TYPE))
  , ...)
|
  kzalloc(
-	sizeof(TYPE) * (COUNT) * STRIDE
+	array3_size(COUNT, STRIDE, sizeof(TYPE))
  , ...)
|
  kzalloc(
-	sizeof(TYPE) * COUNT * (STRIDE)
+	array3_size(COUNT, STRIDE, sizeof(TYPE))
  , ...)
|
  kzalloc(
-	sizeof(TYPE) * COUNT * STRIDE
+	array3_size(COUNT, STRIDE, sizeof(TYPE))
  , ...)
|
  kzalloc(
-	sizeof(THING) * (COUNT) * (STRIDE)
+	array3_size(COUNT, STRIDE, sizeof(THING))
  , ...)
|
  kzalloc(
-	sizeof(THING) * (COUNT) * STRIDE
+	array3_size(COUNT, STRIDE, sizeof(THING))
  , ...)
|
  kzalloc(
-	sizeof(THING) * COUNT * (STRIDE)
+	array3_size(COUNT, STRIDE, sizeof(THING))
  , ...)
|
  kzalloc(
-	sizeof(THING) * COUNT * STRIDE
+	array3_size(COUNT, STRIDE, sizeof(THING))
  , ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
  kzalloc(
-	sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+	array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
  , ...)
|
  kzalloc(
-	sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+	array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
  , ...)
|
  kzalloc(
-	sizeof(THING1) * sizeof(THING2) * COUNT
+	array3_size(COUNT, sizeof(THING1), sizeof(THING2))
  , ...)
|
  kzalloc(
-	sizeof(THING1) * sizeof(THING2) * (COUNT)
+	array3_size(COUNT, sizeof(THING1), sizeof(THING2))
  , ...)
|
  kzalloc(
-	sizeof(TYPE1) * sizeof(THING2) * COUNT
+	array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
  , ...)
|
  kzalloc(
-	sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+	array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
  , ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
  kzalloc(
-	(COUNT) * STRIDE * SIZE
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	COUNT * (STRIDE) * SIZE
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	COUNT * STRIDE * (SIZE)
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	(COUNT) * (STRIDE) * SIZE
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	COUNT * (STRIDE) * (SIZE)
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	(COUNT) * STRIDE * (SIZE)
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	(COUNT) * (STRIDE) * (SIZE)
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
|
  kzalloc(
-	COUNT * STRIDE * SIZE
+	array3_size(COUNT, STRIDE, SIZE)
  , ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
  kzalloc(C1 * C2 * C3, ...)
|
  kzalloc(
-	(E1) * E2 * E3
+	array3_size(E1, E2, E3)
  , ...)
|
  kzalloc(
-	(E1) * (E2) * E3
+	array3_size(E1, E2, E3)
  , ...)
|
  kzalloc(
-	(E1) * (E2) * (E3)
+	array3_size(E1, E2, E3)
  , ...)
|
  kzalloc(
-	E1 * E2 * E3
+	array3_size(E1, E2, E3)
  , ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
  kzalloc(sizeof(THING) * C2, ...)
|
  kzalloc(sizeof(TYPE) * C2, ...)
|
  kzalloc(C1 * C2 * C3, ...)
|
  kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(TYPE) * (E2)
+	E2, sizeof(TYPE)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(TYPE) * E2
+	E2, sizeof(TYPE)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(THING) * (E2)
+	E2, sizeof(THING)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	sizeof(THING) * E2
+	E2, sizeof(THING)
  , ...)
|
- kzalloc
+ kcalloc
  (
-	(E1) * E2
+	E1, E2
  , ...)
|
- kzalloc
+ kcalloc
  (
-	(E1) * (E2)
+	E1, E2
  , ...)
|
- kzalloc
+ kcalloc
  (
-	E1 * E2
+	E1, E2
  , ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
		
	
			
		
			
				
	
	
		
			171 lines
		
	
	
	
		
			4.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			171 lines
		
	
	
	
		
			4.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Common library for ADIS16XXX devices
 | 
						|
 *
 | 
						|
 * Copyright 2012 Analog Devices Inc.
 | 
						|
 *   Author: Lars-Peter Clausen <lars@metafoo.de>
 | 
						|
 *
 | 
						|
 * Licensed under the GPL-2 or later.
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/export.h>
 | 
						|
#include <linux/interrupt.h>
 | 
						|
#include <linux/mutex.h>
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/spi/spi.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
 | 
						|
#include <linux/iio/iio.h>
 | 
						|
#include <linux/iio/buffer.h>
 | 
						|
#include <linux/iio/trigger_consumer.h>
 | 
						|
#include <linux/iio/triggered_buffer.h>
 | 
						|
#include <linux/iio/imu/adis.h>
 | 
						|
 | 
						|
int adis_update_scan_mode(struct iio_dev *indio_dev,
 | 
						|
	const unsigned long *scan_mask)
 | 
						|
{
 | 
						|
	struct adis *adis = iio_device_get_drvdata(indio_dev);
 | 
						|
	const struct iio_chan_spec *chan;
 | 
						|
	unsigned int scan_count;
 | 
						|
	unsigned int i, j;
 | 
						|
	__be16 *tx, *rx;
 | 
						|
 | 
						|
	kfree(adis->xfer);
 | 
						|
	kfree(adis->buffer);
 | 
						|
 | 
						|
	scan_count = indio_dev->scan_bytes / 2;
 | 
						|
 | 
						|
	adis->xfer = kcalloc(scan_count + 1, sizeof(*adis->xfer), GFP_KERNEL);
 | 
						|
	if (!adis->xfer)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	adis->buffer = kcalloc(indio_dev->scan_bytes, 2, GFP_KERNEL);
 | 
						|
	if (!adis->buffer)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	rx = adis->buffer;
 | 
						|
	tx = rx + scan_count;
 | 
						|
 | 
						|
	spi_message_init(&adis->msg);
 | 
						|
 | 
						|
	for (j = 0; j <= scan_count; j++) {
 | 
						|
		adis->xfer[j].bits_per_word = 8;
 | 
						|
		if (j != scan_count)
 | 
						|
			adis->xfer[j].cs_change = 1;
 | 
						|
		adis->xfer[j].len = 2;
 | 
						|
		adis->xfer[j].delay_usecs = adis->data->read_delay;
 | 
						|
		if (j < scan_count)
 | 
						|
			adis->xfer[j].tx_buf = &tx[j];
 | 
						|
		if (j >= 1)
 | 
						|
			adis->xfer[j].rx_buf = &rx[j - 1];
 | 
						|
		spi_message_add_tail(&adis->xfer[j], &adis->msg);
 | 
						|
	}
 | 
						|
 | 
						|
	chan = indio_dev->channels;
 | 
						|
	for (i = 0; i < indio_dev->num_channels; i++, chan++) {
 | 
						|
		if (!test_bit(chan->scan_index, scan_mask))
 | 
						|
			continue;
 | 
						|
		if (chan->scan_type.storagebits == 32)
 | 
						|
			*tx++ = cpu_to_be16((chan->address + 2) << 8);
 | 
						|
		*tx++ = cpu_to_be16(chan->address << 8);
 | 
						|
	}
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL_GPL(adis_update_scan_mode);
 | 
						|
 | 
						|
static irqreturn_t adis_trigger_handler(int irq, void *p)
 | 
						|
{
 | 
						|
	struct iio_poll_func *pf = p;
 | 
						|
	struct iio_dev *indio_dev = pf->indio_dev;
 | 
						|
	struct adis *adis = iio_device_get_drvdata(indio_dev);
 | 
						|
	int ret;
 | 
						|
 | 
						|
	if (!adis->buffer)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	if (adis->data->has_paging) {
 | 
						|
		mutex_lock(&adis->txrx_lock);
 | 
						|
		if (adis->current_page != 0) {
 | 
						|
			adis->tx[0] = ADIS_WRITE_REG(ADIS_REG_PAGE_ID);
 | 
						|
			adis->tx[1] = 0;
 | 
						|
			spi_write(adis->spi, adis->tx, 2);
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	ret = spi_sync(adis->spi, &adis->msg);
 | 
						|
	if (ret)
 | 
						|
		dev_err(&adis->spi->dev, "Failed to read data: %d", ret);
 | 
						|
 | 
						|
 | 
						|
	if (adis->data->has_paging) {
 | 
						|
		adis->current_page = 0;
 | 
						|
		mutex_unlock(&adis->txrx_lock);
 | 
						|
	}
 | 
						|
 | 
						|
	iio_push_to_buffers_with_timestamp(indio_dev, adis->buffer,
 | 
						|
		pf->timestamp);
 | 
						|
 | 
						|
	iio_trigger_notify_done(indio_dev->trig);
 | 
						|
 | 
						|
	return IRQ_HANDLED;
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * adis_setup_buffer_and_trigger() - Sets up buffer and trigger for the adis device
 | 
						|
 * @adis: The adis device.
 | 
						|
 * @indio_dev: The IIO device.
 | 
						|
 * @trigger_handler: Optional trigger handler, may be NULL.
 | 
						|
 *
 | 
						|
 * Returns 0 on success, a negative error code otherwise.
 | 
						|
 *
 | 
						|
 * This function sets up the buffer and trigger for a adis devices.  If
 | 
						|
 * 'trigger_handler' is NULL the default trigger handler will be used. The
 | 
						|
 * default trigger handler will simply read the registers assigned to the
 | 
						|
 * currently active channels.
 | 
						|
 *
 | 
						|
 * adis_cleanup_buffer_and_trigger() should be called to free the resources
 | 
						|
 * allocated by this function.
 | 
						|
 */
 | 
						|
int adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *indio_dev,
 | 
						|
	irqreturn_t (*trigger_handler)(int, void *))
 | 
						|
{
 | 
						|
	int ret;
 | 
						|
 | 
						|
	if (!trigger_handler)
 | 
						|
		trigger_handler = adis_trigger_handler;
 | 
						|
 | 
						|
	ret = iio_triggered_buffer_setup(indio_dev, &iio_pollfunc_store_time,
 | 
						|
		trigger_handler, NULL);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	if (adis->spi->irq) {
 | 
						|
		ret = adis_probe_trigger(adis, indio_dev);
 | 
						|
		if (ret)
 | 
						|
			goto error_buffer_cleanup;
 | 
						|
	}
 | 
						|
	return 0;
 | 
						|
 | 
						|
error_buffer_cleanup:
 | 
						|
	iio_triggered_buffer_cleanup(indio_dev);
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL_GPL(adis_setup_buffer_and_trigger);
 | 
						|
 | 
						|
/**
 | 
						|
 * adis_cleanup_buffer_and_trigger() - Free buffer and trigger resources
 | 
						|
 * @adis: The adis device.
 | 
						|
 * @indio_dev: The IIO device.
 | 
						|
 *
 | 
						|
 * Frees resources allocated by adis_setup_buffer_and_trigger()
 | 
						|
 */
 | 
						|
void adis_cleanup_buffer_and_trigger(struct adis *adis,
 | 
						|
	struct iio_dev *indio_dev)
 | 
						|
{
 | 
						|
	if (adis->spi->irq)
 | 
						|
		adis_remove_trigger(adis);
 | 
						|
	kfree(adis->buffer);
 | 
						|
	kfree(adis->xfer);
 | 
						|
	iio_triggered_buffer_cleanup(indio_dev);
 | 
						|
}
 | 
						|
EXPORT_SYMBOL_GPL(adis_cleanup_buffer_and_trigger);
 |