mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	Clang warns when an emumerated type is implicitly converted to another.
drivers/infiniband/sw/rxe/rxe.c:106:27: warning: implicit conversion
from enumeration type 'enum rxe_device_param' to different enumeration
type 'enum ib_atomic_cap' [-Wenum-conversion]
        rxe->attr.atomic_cap                    = RXE_ATOMIC_CAP;
                                                ~ ^~~~~~~~~~~~~~
drivers/infiniband/sw/rxe/rxe.c:131:22: warning: implicit conversion
from enumeration type 'enum rxe_port_param' to different enumeration
type 'enum ib_port_state' [-Wenum-conversion]
        port->attr.state                = RXE_PORT_STATE;
                                        ~ ^~~~~~~~~~~~~~
drivers/infiniband/sw/rxe/rxe.c:132:24: warning: implicit conversion
from enumeration type 'enum rxe_port_param' to different enumeration
type 'enum ib_mtu' [-Wenum-conversion]
        port->attr.max_mtu              = RXE_PORT_MAX_MTU;
                                        ~ ^~~~~~~~~~~~~~~~
drivers/infiniband/sw/rxe/rxe.c:133:27: warning: implicit conversion
from enumeration type 'enum rxe_port_param' to different enumeration
type 'enum ib_mtu' [-Wenum-conversion]
        port->attr.active_mtu           = RXE_PORT_ACTIVE_MTU;
                                        ~ ^~~~~~~~~~~~~~~~~~~
drivers/infiniband/sw/rxe/rxe.c:151:24: warning: implicit conversion
from enumeration type 'enum rxe_port_param' to different enumeration
type 'enum ib_mtu' [-Wenum-conversion]
                                ib_mtu_enum_to_int(RXE_PORT_ACTIVE_MTU);
                                ~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~
5 warnings generated.
Use the appropriate values from the expected enumerated type so no
conversion needs to happen then remove the unneeded definitions.
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
		
	
			
		
			
				
	
	
		
			167 lines
		
	
	
	
		
			4.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			167 lines
		
	
	
	
		
			4.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (c) 2016 Mellanox Technologies Ltd. All rights reserved.
 | 
						|
 * Copyright (c) 2015 System Fabric Works, Inc. All rights reserved.
 | 
						|
 *
 | 
						|
 * This software is available to you under a choice of one of two
 | 
						|
 * licenses.  You may choose to be licensed under the terms of the GNU
 | 
						|
 * General Public License (GPL) Version 2, available from the file
 | 
						|
 * COPYING in the main directory of this source tree, or the
 | 
						|
 * OpenIB.org BSD license below:
 | 
						|
 *
 | 
						|
 *     Redistribution and use in source and binary forms, with or
 | 
						|
 *     without modification, are permitted provided that the following
 | 
						|
 *     conditions are met:
 | 
						|
 *
 | 
						|
 *	- Redistributions of source code must retain the above
 | 
						|
 *	  copyright notice, this list of conditions and the following
 | 
						|
 *	  disclaimer.
 | 
						|
 *
 | 
						|
 *	- Redistributions in binary form must reproduce the above
 | 
						|
 *	  copyright notice, this list of conditions and the following
 | 
						|
 *	  disclaimer in the documentation and/or other materials
 | 
						|
 *	  provided with the distribution.
 | 
						|
 *
 | 
						|
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 | 
						|
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 | 
						|
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 | 
						|
 * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
 | 
						|
 * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
 | 
						|
 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 | 
						|
 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 | 
						|
 * SOFTWARE.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef RXE_PARAM_H
 | 
						|
#define RXE_PARAM_H
 | 
						|
 | 
						|
static inline enum ib_mtu rxe_mtu_int_to_enum(int mtu)
 | 
						|
{
 | 
						|
	if (mtu < 256)
 | 
						|
		return 0;
 | 
						|
	else if (mtu < 512)
 | 
						|
		return IB_MTU_256;
 | 
						|
	else if (mtu < 1024)
 | 
						|
		return IB_MTU_512;
 | 
						|
	else if (mtu < 2048)
 | 
						|
		return IB_MTU_1024;
 | 
						|
	else if (mtu < 4096)
 | 
						|
		return IB_MTU_2048;
 | 
						|
	else
 | 
						|
		return IB_MTU_4096;
 | 
						|
}
 | 
						|
 | 
						|
/* Find the IB mtu for a given network MTU. */
 | 
						|
static inline enum ib_mtu eth_mtu_int_to_enum(int mtu)
 | 
						|
{
 | 
						|
	mtu -= RXE_MAX_HDR_LENGTH;
 | 
						|
 | 
						|
	return rxe_mtu_int_to_enum(mtu);
 | 
						|
}
 | 
						|
 | 
						|
/* default/initial rxe device parameter settings */
 | 
						|
enum rxe_device_param {
 | 
						|
	RXE_FW_VER			= 0,
 | 
						|
	RXE_MAX_MR_SIZE			= -1ull,
 | 
						|
	RXE_PAGE_SIZE_CAP		= 0xfffff000,
 | 
						|
	RXE_VENDOR_ID			= 0,
 | 
						|
	RXE_VENDOR_PART_ID		= 0,
 | 
						|
	RXE_HW_VER			= 0,
 | 
						|
	RXE_MAX_QP			= 0x10000,
 | 
						|
	RXE_MAX_QP_WR			= 0x4000,
 | 
						|
	RXE_MAX_INLINE_DATA		= 400,
 | 
						|
	RXE_DEVICE_CAP_FLAGS		= IB_DEVICE_BAD_PKEY_CNTR
 | 
						|
					| IB_DEVICE_BAD_QKEY_CNTR
 | 
						|
					| IB_DEVICE_AUTO_PATH_MIG
 | 
						|
					| IB_DEVICE_CHANGE_PHY_PORT
 | 
						|
					| IB_DEVICE_UD_AV_PORT_ENFORCE
 | 
						|
					| IB_DEVICE_PORT_ACTIVE_EVENT
 | 
						|
					| IB_DEVICE_SYS_IMAGE_GUID
 | 
						|
					| IB_DEVICE_RC_RNR_NAK_GEN
 | 
						|
					| IB_DEVICE_SRQ_RESIZE
 | 
						|
					| IB_DEVICE_MEM_MGT_EXTENSIONS,
 | 
						|
	RXE_MAX_SGE			= 32,
 | 
						|
	RXE_MAX_SGE_RD			= 32,
 | 
						|
	RXE_MAX_CQ			= 16384,
 | 
						|
	RXE_MAX_LOG_CQE			= 15,
 | 
						|
	RXE_MAX_MR			= 256 * 1024,
 | 
						|
	RXE_MAX_PD			= 0x7ffc,
 | 
						|
	RXE_MAX_QP_RD_ATOM		= 128,
 | 
						|
	RXE_MAX_EE_RD_ATOM		= 0,
 | 
						|
	RXE_MAX_RES_RD_ATOM		= 0x3f000,
 | 
						|
	RXE_MAX_QP_INIT_RD_ATOM		= 128,
 | 
						|
	RXE_MAX_EE_INIT_RD_ATOM		= 0,
 | 
						|
	RXE_MAX_EE			= 0,
 | 
						|
	RXE_MAX_RDD			= 0,
 | 
						|
	RXE_MAX_MW			= 0,
 | 
						|
	RXE_MAX_RAW_IPV6_QP		= 0,
 | 
						|
	RXE_MAX_RAW_ETHY_QP		= 0,
 | 
						|
	RXE_MAX_MCAST_GRP		= 8192,
 | 
						|
	RXE_MAX_MCAST_QP_ATTACH		= 56,
 | 
						|
	RXE_MAX_TOT_MCAST_QP_ATTACH	= 0x70000,
 | 
						|
	RXE_MAX_AH			= 100,
 | 
						|
	RXE_MAX_FMR			= 0,
 | 
						|
	RXE_MAX_MAP_PER_FMR		= 0,
 | 
						|
	RXE_MAX_SRQ			= 960,
 | 
						|
	RXE_MAX_SRQ_WR			= 0x4000,
 | 
						|
	RXE_MIN_SRQ_WR			= 1,
 | 
						|
	RXE_MAX_SRQ_SGE			= 27,
 | 
						|
	RXE_MIN_SRQ_SGE			= 1,
 | 
						|
	RXE_MAX_FMR_PAGE_LIST_LEN	= 512,
 | 
						|
	RXE_MAX_PKEYS			= 64,
 | 
						|
	RXE_LOCAL_CA_ACK_DELAY		= 15,
 | 
						|
 | 
						|
	RXE_MAX_UCONTEXT		= 512,
 | 
						|
 | 
						|
	RXE_NUM_PORT			= 1,
 | 
						|
 | 
						|
	RXE_MIN_QP_INDEX		= 16,
 | 
						|
	RXE_MAX_QP_INDEX		= 0x00020000,
 | 
						|
 | 
						|
	RXE_MIN_SRQ_INDEX		= 0x00020001,
 | 
						|
	RXE_MAX_SRQ_INDEX		= 0x00040000,
 | 
						|
 | 
						|
	RXE_MIN_MR_INDEX		= 0x00000001,
 | 
						|
	RXE_MAX_MR_INDEX		= 0x00040000,
 | 
						|
	RXE_MIN_MW_INDEX		= 0x00040001,
 | 
						|
	RXE_MAX_MW_INDEX		= 0x00060000,
 | 
						|
	RXE_MAX_PKT_PER_ACK		= 64,
 | 
						|
 | 
						|
	RXE_MAX_UNACKED_PSNS		= 128,
 | 
						|
 | 
						|
	/* Max inflight SKBs per queue pair */
 | 
						|
	RXE_INFLIGHT_SKBS_PER_QP_HIGH	= 64,
 | 
						|
	RXE_INFLIGHT_SKBS_PER_QP_LOW	= 16,
 | 
						|
 | 
						|
	/* Delay before calling arbiter timer */
 | 
						|
	RXE_NSEC_ARB_TIMER_DELAY	= 200,
 | 
						|
};
 | 
						|
 | 
						|
/* default/initial rxe port parameters */
 | 
						|
enum rxe_port_param {
 | 
						|
	RXE_PORT_GID_TBL_LEN		= 1024,
 | 
						|
	RXE_PORT_PORT_CAP_FLAGS		= RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP,
 | 
						|
	RXE_PORT_MAX_MSG_SZ		= 0x800000,
 | 
						|
	RXE_PORT_BAD_PKEY_CNTR		= 0,
 | 
						|
	RXE_PORT_QKEY_VIOL_CNTR		= 0,
 | 
						|
	RXE_PORT_LID			= 0,
 | 
						|
	RXE_PORT_SM_LID			= 0,
 | 
						|
	RXE_PORT_SM_SL			= 0,
 | 
						|
	RXE_PORT_LMC			= 0,
 | 
						|
	RXE_PORT_MAX_VL_NUM		= 1,
 | 
						|
	RXE_PORT_SUBNET_TIMEOUT		= 0,
 | 
						|
	RXE_PORT_INIT_TYPE_REPLY	= 0,
 | 
						|
	RXE_PORT_ACTIVE_WIDTH		= IB_WIDTH_1X,
 | 
						|
	RXE_PORT_ACTIVE_SPEED		= 1,
 | 
						|
	RXE_PORT_PKEY_TBL_LEN		= 64,
 | 
						|
	RXE_PORT_PHYS_STATE		= 2,
 | 
						|
	RXE_PORT_SUBNET_PREFIX		= 0xfe80000000000000ULL,
 | 
						|
};
 | 
						|
 | 
						|
/* default/initial port info parameters */
 | 
						|
enum rxe_port_info_param {
 | 
						|
	RXE_PORT_INFO_VL_CAP		= 4,	/* 1-8 */
 | 
						|
	RXE_PORT_INFO_MTU_CAP		= 5,	/* 4096 */
 | 
						|
	RXE_PORT_INFO_OPER_VL		= 1,	/* 1 */
 | 
						|
};
 | 
						|
 | 
						|
#endif /* RXE_PARAM_H */
 |