mirror of
https://github.com/torvalds/linux.git
synced 2025-11-02 09:40:27 +02:00
2153bbc12f
According to the datasheet the update bit must be set if the on-time-div or the base-unit changes. Now that we properly order device resume on Cherry Trail so that the GFX0 _PS0 method no longer exits with an error, we end up with a sequence of events where we are writing the same values twice in a row. First the _PS0 method restores the duty cycle of 0% the GPU driver set on suspend and then the GPU driver first updates just the enabled bit in the pwm_state from 0 to 1, causing us to write the same values again, before restoring the pre-suspend duty-cycle in a separate pwm_apply call. When writing the update bit the second time, without changing any of the values the update bit clears immediately / instantly, instead of staying 1 for a while as usual. After this the next setting of the update bit seems to be ignored, causing the restoring of the pre-suspend duty-cycle to not get applied. This makes the backlight come up with a 0% dutycycle after suspend/resume. Any further brightness changes after this do work. This commit moves the setting of the update bit into pwm_lpss_prepare() and only sets the bit if we have actually changed any of the values. This avoids the setting of the update bit the second time we configure the PWM to 0% dutycycle, this fixes the backlight coming up with 0% duty-cycle after a suspend/resume. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Thierry Reding <thierry.reding@gmail.com> |
||
|---|---|---|
| .. | ||
| core.c | ||
| Kconfig | ||
| Makefile | ||
| pwm-ab8500.c | ||
| pwm-atmel-hlcdc.c | ||
| pwm-atmel-tcb.c | ||
| pwm-atmel.c | ||
| pwm-bcm-iproc.c | ||
| pwm-bcm-kona.c | ||
| pwm-bcm2835.c | ||
| pwm-berlin.c | ||
| pwm-brcmstb.c | ||
| pwm-clps711x.c | ||
| pwm-crc.c | ||
| pwm-cros-ec.c | ||
| pwm-ep93xx.c | ||
| pwm-fsl-ftm.c | ||
| pwm-hibvt.c | ||
| pwm-img.c | ||
| pwm-imx.c | ||
| pwm-jz4740.c | ||
| pwm-lp3943.c | ||
| pwm-lpc18xx-sct.c | ||
| pwm-lpc32xx.c | ||
| pwm-lpss-pci.c | ||
| pwm-lpss-platform.c | ||
| pwm-lpss.c | ||
| pwm-lpss.h | ||
| pwm-mediatek.c | ||
| pwm-meson.c | ||
| pwm-mtk-disp.c | ||
| pwm-mxs.c | ||
| pwm-omap-dmtimer.c | ||
| pwm-pca9685.c | ||
| pwm-puv3.c | ||
| pwm-pxa.c | ||
| pwm-rcar.c | ||
| pwm-renesas-tpu.c | ||
| pwm-rockchip.c | ||
| pwm-samsung.c | ||
| pwm-spear.c | ||
| pwm-sti.c | ||
| pwm-stm32-lp.c | ||
| pwm-stm32.c | ||
| pwm-stmpe.c | ||
| pwm-sun4i.c | ||
| pwm-tegra.c | ||
| pwm-tiecap.c | ||
| pwm-tiehrpwm.c | ||
| pwm-tipwmss.c | ||
| pwm-twl-led.c | ||
| pwm-twl.c | ||
| pwm-vt8500.c | ||
| pwm-zx.c | ||
| sysfs.c | ||