mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	Impact: cleanup
mm/failslab.c depends on slab.h without including it:
    CC      mm/failslab.o
  mm/failslab.c: In function ‘should_failslab’:
  mm/failslab.c:16: error: ‘__GFP_NOFAIL’ undeclared (first use in this function)
  mm/failslab.c:16: error: (Each undeclared identifier is reported only once
  mm/failslab.c:16: error: for each function it appears in.)
  mm/failslab.c:19: error: ‘__GFP_WAIT’ undeclared (first use in this function)
  make[1]: *** [mm/failslab.o] Error 1
  make: *** [mm] Error 2
It gets included implicitly currently - but this will not be the
case with upcoming kmemtrace changes.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
LKML-Reference: <1237888761.25315.69.camel@penberg-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
		
	
			
		
			
				
	
	
		
			60 lines
		
	
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			60 lines
		
	
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#include <linux/fault-inject.h>
 | 
						|
#include <linux/gfp.h>
 | 
						|
 | 
						|
static struct {
 | 
						|
	struct fault_attr attr;
 | 
						|
	u32 ignore_gfp_wait;
 | 
						|
#ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
 | 
						|
	struct dentry *ignore_gfp_wait_file;
 | 
						|
#endif
 | 
						|
} failslab = {
 | 
						|
	.attr = FAULT_ATTR_INITIALIZER,
 | 
						|
	.ignore_gfp_wait = 1,
 | 
						|
};
 | 
						|
 | 
						|
bool should_failslab(size_t size, gfp_t gfpflags)
 | 
						|
{
 | 
						|
	if (gfpflags & __GFP_NOFAIL)
 | 
						|
		return false;
 | 
						|
 | 
						|
        if (failslab.ignore_gfp_wait && (gfpflags & __GFP_WAIT))
 | 
						|
		return false;
 | 
						|
 | 
						|
	return should_fail(&failslab.attr, size);
 | 
						|
}
 | 
						|
 | 
						|
static int __init setup_failslab(char *str)
 | 
						|
{
 | 
						|
	return setup_fault_attr(&failslab.attr, str);
 | 
						|
}
 | 
						|
__setup("failslab=", setup_failslab);
 | 
						|
 | 
						|
#ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
 | 
						|
 | 
						|
static int __init failslab_debugfs_init(void)
 | 
						|
{
 | 
						|
	mode_t mode = S_IFREG | S_IRUSR | S_IWUSR;
 | 
						|
	struct dentry *dir;
 | 
						|
	int err;
 | 
						|
 | 
						|
	err = init_fault_attr_dentries(&failslab.attr, "failslab");
 | 
						|
	if (err)
 | 
						|
		return err;
 | 
						|
	dir = failslab.attr.dentries.dir;
 | 
						|
 | 
						|
	failslab.ignore_gfp_wait_file =
 | 
						|
		debugfs_create_bool("ignore-gfp-wait", mode, dir,
 | 
						|
				      &failslab.ignore_gfp_wait);
 | 
						|
 | 
						|
	if (!failslab.ignore_gfp_wait_file) {
 | 
						|
		err = -ENOMEM;
 | 
						|
		debugfs_remove(failslab.ignore_gfp_wait_file);
 | 
						|
		cleanup_fault_attr_dentries(&failslab.attr);
 | 
						|
	}
 | 
						|
 | 
						|
	return err;
 | 
						|
}
 | 
						|
 | 
						|
late_initcall(failslab_debugfs_init);
 | 
						|
 | 
						|
#endif /* CONFIG_FAULT_INJECTION_DEBUG_FS */
 |