mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	When truncating a file to a size within the last allowed logical block,
block_to_path() is called with the *next* block.  This exceeds the limit,
causing the "block %ld too big" error message to be printed.
This case isn't actually an error; there are just no more blocks past that
point.  So, remove this error message.
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Qiujun Huang <anenbupt@gmail.com>
Link: http://lkml.kernel.org/r/20200628060846.682158-7-ebiggers@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
	
			
		
			
				
	
	
		
			75 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			75 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0
 | 
						|
#include <linux/buffer_head.h>
 | 
						|
#include "minix.h"
 | 
						|
 | 
						|
enum {DIRECT = 7, DEPTH = 4};	/* Have triple indirect */
 | 
						|
 | 
						|
typedef u32 block_t;	/* 32 bit, host order */
 | 
						|
 | 
						|
static inline unsigned long block_to_cpu(block_t n)
 | 
						|
{
 | 
						|
	return n;
 | 
						|
}
 | 
						|
 | 
						|
static inline block_t cpu_to_block(unsigned long n)
 | 
						|
{
 | 
						|
	return n;
 | 
						|
}
 | 
						|
 | 
						|
static inline block_t *i_data(struct inode *inode)
 | 
						|
{
 | 
						|
	return (block_t *)minix_i(inode)->u.i2_data;
 | 
						|
}
 | 
						|
 | 
						|
#define DIRCOUNT 7
 | 
						|
#define INDIRCOUNT(sb) (1 << ((sb)->s_blocksize_bits - 2))
 | 
						|
 | 
						|
static int block_to_path(struct inode * inode, long block, int offsets[DEPTH])
 | 
						|
{
 | 
						|
	int n = 0;
 | 
						|
	struct super_block *sb = inode->i_sb;
 | 
						|
 | 
						|
	if (block < 0) {
 | 
						|
		printk("MINIX-fs: block_to_path: block %ld < 0 on dev %pg\n",
 | 
						|
			block, sb->s_bdev);
 | 
						|
		return 0;
 | 
						|
	}
 | 
						|
	if ((u64)block * (u64)sb->s_blocksize >= sb->s_maxbytes)
 | 
						|
		return 0;
 | 
						|
 | 
						|
	if (block < DIRCOUNT) {
 | 
						|
		offsets[n++] = block;
 | 
						|
	} else if ((block -= DIRCOUNT) < INDIRCOUNT(sb)) {
 | 
						|
		offsets[n++] = DIRCOUNT;
 | 
						|
		offsets[n++] = block;
 | 
						|
	} else if ((block -= INDIRCOUNT(sb)) < INDIRCOUNT(sb) * INDIRCOUNT(sb)) {
 | 
						|
		offsets[n++] = DIRCOUNT + 1;
 | 
						|
		offsets[n++] = block / INDIRCOUNT(sb);
 | 
						|
		offsets[n++] = block % INDIRCOUNT(sb);
 | 
						|
	} else {
 | 
						|
		block -= INDIRCOUNT(sb) * INDIRCOUNT(sb);
 | 
						|
		offsets[n++] = DIRCOUNT + 2;
 | 
						|
		offsets[n++] = (block / INDIRCOUNT(sb)) / INDIRCOUNT(sb);
 | 
						|
		offsets[n++] = (block / INDIRCOUNT(sb)) % INDIRCOUNT(sb);
 | 
						|
		offsets[n++] = block % INDIRCOUNT(sb);
 | 
						|
	}
 | 
						|
	return n;
 | 
						|
}
 | 
						|
 | 
						|
#include "itree_common.c"
 | 
						|
 | 
						|
int V2_minix_get_block(struct inode * inode, long block,
 | 
						|
			struct buffer_head *bh_result, int create)
 | 
						|
{
 | 
						|
	return get_block(inode, block, bh_result, create);
 | 
						|
}
 | 
						|
 | 
						|
void V2_minix_truncate(struct inode * inode)
 | 
						|
{
 | 
						|
	truncate(inode);
 | 
						|
}
 | 
						|
 | 
						|
unsigned V2_minix_blocks(loff_t size, struct super_block *sb)
 | 
						|
{
 | 
						|
	return nblocks(size, sb);
 | 
						|
}
 |