mirror of
https://github.com/torvalds/linux.git
synced 2025-10-31 16:48:26 +02:00
fcad9bbf9e
In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast` is safer because it cannot accidentally change the > pointer's mutability, nor cast the pointer to other types like `usize`. There are a few classes of changes required: - Modules generated by bindgen are marked `#[allow(clippy::ptr_as_ptr)]`. - Inferred casts (` as _`) are replaced with `.cast()`. - Ascribed casts (` as *... T`) are replaced with `.cast::<T>()`. - Multistep casts from references (` as *const _ as *const T`) are replaced with `core::ptr::from_ref(&x).cast()` with or without `::<T>` according to the previous rules. The `core::ptr::from_ref` call is required because `(x as *const _).cast::<T>()` results in inference failure. - Native literal C strings are replaced with `c_str!().as_char_ptr()`. - `*mut *mut T as _` is replaced with `let *mut *const T = (*mut *mut T)`.cast();` since pointer to pointer can be confusing. Apply these changes and enable the lint -- no functional change intended. Link: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_as_ptr [1] Reviewed-by: Benno Lossin <benno.lossin@proton.me> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Signed-off-by: Tamir Duberstein <tamird@gmail.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Tejun Heo <tj@kernel.org> Acked-by: Danilo Krummrich <dakr@kernel.org> Link: https://lore.kernel.org/r/20250615-ptr-as-ptr-v12-1-f43b024581e8@gmail.com [ Added `.cast()` for `opp`. - Miguel ] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
53 lines
1.7 KiB
Rust
53 lines
1.7 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
//! Seq file bindings.
|
|
//!
|
|
//! C header: [`include/linux/seq_file.h`](srctree/include/linux/seq_file.h)
|
|
|
|
use crate::{bindings, c_str, types::NotThreadSafe, types::Opaque};
|
|
|
|
/// A utility for generating the contents of a seq file.
|
|
#[repr(transparent)]
|
|
pub struct SeqFile {
|
|
inner: Opaque<bindings::seq_file>,
|
|
_not_send: NotThreadSafe,
|
|
}
|
|
|
|
impl SeqFile {
|
|
/// Creates a new [`SeqFile`] from a raw pointer.
|
|
///
|
|
/// # Safety
|
|
///
|
|
/// The caller must ensure that for the duration of `'a` the following is satisfied:
|
|
/// * The pointer points at a valid `struct seq_file`.
|
|
/// * The `struct seq_file` is not accessed from any other thread.
|
|
pub unsafe fn from_raw<'a>(ptr: *mut bindings::seq_file) -> &'a SeqFile {
|
|
// SAFETY: The caller ensures that the reference is valid for 'a. There's no way to trigger
|
|
// a data race by using the `&SeqFile` since this is the only thread accessing the seq_file.
|
|
//
|
|
// CAST: The layout of `struct seq_file` and `SeqFile` is compatible.
|
|
unsafe { &*ptr.cast() }
|
|
}
|
|
|
|
/// Used by the [`seq_print`] macro.
|
|
#[inline]
|
|
pub fn call_printf(&self, args: core::fmt::Arguments<'_>) {
|
|
// SAFETY: Passing a void pointer to `Arguments` is valid for `%pA`.
|
|
unsafe {
|
|
bindings::seq_printf(
|
|
self.inner.get(),
|
|
c_str!("%pA").as_char_ptr(),
|
|
core::ptr::from_ref(&args).cast::<crate::ffi::c_void>(),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Write to a [`SeqFile`] with the ordinary Rust formatting syntax.
|
|
#[macro_export]
|
|
macro_rules! seq_print {
|
|
($m:expr, $($arg:tt)+) => (
|
|
$m.call_printf(format_args!($($arg)+))
|
|
);
|
|
}
|
|
pub use seq_print;
|