mirror of
https://github.com/torvalds/linux.git
synced 2025-11-01 09:09:47 +02:00
Introduces the concept of a `ScopedDir`, which allows for the creation of debugfs directories and files that are tied to the lifetime of a particular data structure. This ensures that debugfs entries do not outlive the data they refer to. The new `Dir::scope` method creates a new directory that is owned by a `Scope` handle. All files and subdirectories created within this scope are automatically cleaned up when the `Scope` is dropped. Signed-off-by: Matthew Maurer <mmaurer@google.com> Tested-by: Dirk Behme <dirk.behme@de.bosch.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20250904-debugfs-rust-v11-6-7d12a165685a@google.com [ Fix up Result<(), Error> -> Result; fix spurious backtick in doc-comment. - Danilo ] Signed-off-by: Danilo Krummrich <dakr@kernel.org>
164 lines
5.7 KiB
Rust
164 lines
5.7 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
// Copyright (C) 2025 Google LLC.
|
|
|
|
use crate::debugfs::file_ops::FileOps;
|
|
use crate::ffi::c_void;
|
|
use crate::str::CStr;
|
|
use crate::sync::Arc;
|
|
use core::marker::PhantomData;
|
|
|
|
/// Owning handle to a DebugFS entry.
|
|
///
|
|
/// # Invariants
|
|
///
|
|
/// The wrapped pointer will always be `NULL`, an error, or an owned DebugFS `dentry`.
|
|
pub(crate) struct Entry<'a> {
|
|
entry: *mut bindings::dentry,
|
|
// If we were created with an owning parent, this is the keep-alive
|
|
_parent: Option<Arc<Entry<'static>>>,
|
|
// If we were created with a non-owning parent, this prevents us from outliving it
|
|
_phantom: PhantomData<&'a ()>,
|
|
}
|
|
|
|
// SAFETY: [`Entry`] is just a `dentry` under the hood, which the API promises can be transferred
|
|
// between threads.
|
|
unsafe impl Send for Entry<'_> {}
|
|
|
|
// SAFETY: All the C functions we call on the `dentry` pointer are threadsafe.
|
|
unsafe impl Sync for Entry<'_> {}
|
|
|
|
impl Entry<'static> {
|
|
pub(crate) fn dynamic_dir(name: &CStr, parent: Option<Arc<Self>>) -> Self {
|
|
let parent_ptr = match &parent {
|
|
Some(entry) => entry.as_ptr(),
|
|
None => core::ptr::null_mut(),
|
|
};
|
|
// SAFETY: The invariants of this function's arguments ensure the safety of this call.
|
|
// * `name` is a valid C string by the invariants of `&CStr`.
|
|
// * `parent_ptr` is either `NULL` (if `parent` is `None`), or a pointer to a valid
|
|
// `dentry` by our invariant. `debugfs_create_dir` handles `NULL` pointers correctly.
|
|
let entry = unsafe { bindings::debugfs_create_dir(name.as_char_ptr(), parent_ptr) };
|
|
|
|
Entry {
|
|
entry,
|
|
_parent: parent,
|
|
_phantom: PhantomData,
|
|
}
|
|
}
|
|
|
|
/// # Safety
|
|
///
|
|
/// * `data` must outlive the returned `Entry`.
|
|
pub(crate) unsafe fn dynamic_file<T>(
|
|
name: &CStr,
|
|
parent: Arc<Self>,
|
|
data: &T,
|
|
file_ops: &'static FileOps<T>,
|
|
) -> Self {
|
|
// SAFETY: The invariants of this function's arguments ensure the safety of this call.
|
|
// * `name` is a valid C string by the invariants of `&CStr`.
|
|
// * `parent.as_ptr()` is a pointer to a valid `dentry` by invariant.
|
|
// * The caller guarantees that `data` will outlive the returned `Entry`.
|
|
// * The guarantees on `FileOps` assert the vtable will be compatible with the data we have
|
|
// provided.
|
|
let entry = unsafe {
|
|
bindings::debugfs_create_file_full(
|
|
name.as_char_ptr(),
|
|
file_ops.mode(),
|
|
parent.as_ptr(),
|
|
core::ptr::from_ref(data) as *mut c_void,
|
|
core::ptr::null(),
|
|
&**file_ops,
|
|
)
|
|
};
|
|
|
|
Entry {
|
|
entry,
|
|
_parent: Some(parent),
|
|
_phantom: PhantomData,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<'a> Entry<'a> {
|
|
pub(crate) fn dir(name: &CStr, parent: Option<&'a Entry<'_>>) -> Self {
|
|
let parent_ptr = match &parent {
|
|
Some(entry) => entry.as_ptr(),
|
|
None => core::ptr::null_mut(),
|
|
};
|
|
// SAFETY: The invariants of this function's arguments ensure the safety of this call.
|
|
// * `name` is a valid C string by the invariants of `&CStr`.
|
|
// * `parent_ptr` is either `NULL` (if `parent` is `None`), or a pointer to a valid
|
|
// `dentry` (because `parent` is a valid reference to an `Entry`). The lifetime `'a`
|
|
// ensures that the parent outlives this entry.
|
|
let entry = unsafe { bindings::debugfs_create_dir(name.as_char_ptr(), parent_ptr) };
|
|
|
|
Entry {
|
|
entry,
|
|
_parent: None,
|
|
_phantom: PhantomData,
|
|
}
|
|
}
|
|
|
|
pub(crate) fn file<T>(
|
|
name: &CStr,
|
|
parent: &'a Entry<'_>,
|
|
data: &'a T,
|
|
file_ops: &FileOps<T>,
|
|
) -> Self {
|
|
// SAFETY: The invariants of this function's arguments ensure the safety of this call.
|
|
// * `name` is a valid C string by the invariants of `&CStr`.
|
|
// * `parent.as_ptr()` is a pointer to a valid `dentry` because we have `&'a Entry`.
|
|
// * `data` is a valid pointer to `T` for lifetime `'a`.
|
|
// * The returned `Entry` has lifetime `'a`, so it cannot outlive `parent` or `data`.
|
|
// * The caller guarantees that `vtable` is compatible with `data`.
|
|
// * The guarantees on `FileOps` assert the vtable will be compatible with the data we have
|
|
// provided.
|
|
let entry = unsafe {
|
|
bindings::debugfs_create_file_full(
|
|
name.as_char_ptr(),
|
|
file_ops.mode(),
|
|
parent.as_ptr(),
|
|
core::ptr::from_ref(data) as *mut c_void,
|
|
core::ptr::null(),
|
|
&**file_ops,
|
|
)
|
|
};
|
|
|
|
Entry {
|
|
entry,
|
|
_parent: None,
|
|
_phantom: PhantomData,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Entry<'_> {
|
|
/// Constructs a placeholder DebugFS [`Entry`].
|
|
pub(crate) fn empty() -> Self {
|
|
Self {
|
|
entry: core::ptr::null_mut(),
|
|
_parent: None,
|
|
_phantom: PhantomData,
|
|
}
|
|
}
|
|
|
|
/// Returns the pointer representation of the DebugFS directory.
|
|
///
|
|
/// # Guarantees
|
|
///
|
|
/// Due to the type invariant, the value returned from this function will always be an error
|
|
/// code, NULL, or a live DebugFS directory. If it is live, it will remain live at least as
|
|
/// long as this entry lives.
|
|
pub(crate) fn as_ptr(&self) -> *mut bindings::dentry {
|
|
self.entry
|
|
}
|
|
}
|
|
|
|
impl Drop for Entry<'_> {
|
|
fn drop(&mut self) {
|
|
// SAFETY: `debugfs_remove` can take `NULL`, error values, and legal DebugFS dentries.
|
|
// `as_ptr` guarantees that the pointer is of this form.
|
|
unsafe { bindings::debugfs_remove(self.as_ptr()) }
|
|
}
|
|
}
|