mirror of
https://github.com/torvalds/linux.git
synced 2025-11-03 18:20:25 +02:00
8efe8816a7
For some architectures, such as X86_64, ARCH_KMALLOC_MINALIGN is not
resolvable for bindgen. E.g. due to being defined as
__alignof__(unsigned long long).
Hence, we have to create a rust helper, i.e. let the C compiler evaluate
the expression and store it in a const.
However, if for other architectures, such as arm64,
ARCH_KMALLOC_MINALIGN does evaluate to something that can be directly
processed by bindgen, we end up with multiple definitions of
ARCH_KMALLOC_MINALIGN in the generated bindings.
error[E0428]: the name `ARCH_KMALLOC_MINALIGN` is defined multiple times
--> /builddir/build/BUILD/kernel-6.17.0-build/kernel-next-20250818/linux-6.17.0-0.0.next.20250818.423.vanilla.fc44.aarch64/rust/bindings/bindings_generated.rs:134545:1
|
9622 | pub const ARCH_KMALLOC_MINALIGN: u32 = 8;
| ----------------------------------------- previous definition of the value `ARCH_KMALLOC_MINALIGN` here
...
134545 | pub const ARCH_KMALLOC_MINALIGN: usize = 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `ARCH_KMALLOC_MINALIGN` redefined here
|
= note: `ARCH_KMALLOC_MINALIGN` must be defined only once in the value namespace of this module
To fix this up, add ARCH_KMALLOC_MINALIGN to the blocklist of bindgen,
such that we always only generate the symbol from the rust helper.
Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Closes: https://lore.kernel.org/all/8aa05f08-ef6e-4dfe-9453-beaab7b3cb98@leemhuis.info/
Fixes: 1b1a946dc2 ("rust: alloc: specify the minimum alignment of each allocator")
Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20250818180923.192042-1-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
37 lines
1.4 KiB
Text
37 lines
1.4 KiB
Text
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
# We want to map these types to `isize`/`usize` manually, instead of
|
|
# define them as `int`/`long` depending on platform bitwidth.
|
|
--blocklist-type __kernel_s?size_t
|
|
--blocklist-type __kernel_ptrdiff_t
|
|
|
|
--opaque-type xregs_state
|
|
--opaque-type desc_struct
|
|
--opaque-type arch_lbr_state
|
|
--opaque-type local_apic
|
|
|
|
# Packed type cannot transitively contain a `#[repr(align)]` type.
|
|
--opaque-type alt_instr
|
|
--opaque-type x86_msi_data
|
|
--opaque-type x86_msi_addr_lo
|
|
|
|
# `try` is a reserved keyword since Rust 2018; solved in `bindgen` v0.59.2,
|
|
# commit 2aed6b021680 ("context: Escape the try keyword properly").
|
|
--opaque-type kunit_try_catch
|
|
|
|
# If SMP is disabled, `arch_spinlock_t` is defined as a ZST which triggers a Rust
|
|
# warning. We don't need to peek into it anyway.
|
|
--opaque-type spinlock
|
|
|
|
# `seccomp`'s comment gets understood as a doctest
|
|
--no-doc-comments
|
|
|
|
# These functions use the `__preserve_most` calling convention, which neither bindgen
|
|
# nor Rust currently understand, and which Clang currently declares to be unstable.
|
|
--blocklist-function __list_.*_report
|
|
|
|
# These constants are sometimes not recognized by bindgen depending on config.
|
|
# We use const helpers to aid bindgen, to avoid conflicts when constants are
|
|
# recognized, block generation of the non-helper constants.
|
|
--blocklist-item ARCH_SLAB_MINALIGN
|
|
--blocklist-item ARCH_KMALLOC_MINALIGN
|