mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	 b1992c3772
			
		
	
	
		b1992c3772
		
	
	
	
	
		
			
			Kbuild conventionally uses $(obj)/ for generated files, and $(src)/ for
checked-in source files. It is merely a convention without any functional
difference. In fact, $(obj) and $(src) are exactly the same, as defined
in scripts/Makefile.build:
    src := $(obj)
When the kernel is built in a separate output directory, $(src) does
not accurately reflect the source directory location. While Kbuild
resolves this discrepancy by specifying VPATH=$(srctree) to search for
source files, it does not cover all cases. For example, when adding a
header search path for local headers, -I$(srctree)/$(src) is typically
passed to the compiler.
This introduces inconsistency between upstream and downstream Makefiles
because $(src) is used instead of $(srctree)/$(src) for the latter.
To address this inconsistency, this commit changes the semantics of
$(src) so that it always points to the directory in the source tree.
Going forward, the variables used in Makefiles will have the following
meanings:
  $(obj)     - directory in the object tree
  $(src)     - directory in the source tree  (changed by this commit)
  $(objtree) - the top of the kernel object tree
  $(srctree) - the top of the kernel source tree
Consequently, $(srctree)/$(src) in upstream Makefiles need to be replaced
with $(src).
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
		
	
			
		
			
				
	
	
		
			58 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			58 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
| # SPDX-License-Identifier: GPL-2.0
 | |
| # include/asm-generic contains a lot of files that are used
 | |
| # verbatim by several architectures.
 | |
| #
 | |
| # This Makefile reads the file arch/$(SRCARCH)/include/(uapi/)/asm/Kbuild
 | |
| # and for each file listed in this file with generic-y creates
 | |
| # a small wrapper file in arch/$(SRCARCH)/include/generated/(uapi/)/asm.
 | |
| 
 | |
| PHONY := all
 | |
| all:
 | |
| 
 | |
| src := $(srctree)/$(subst /generated,,$(obj))
 | |
| 
 | |
| include $(srctree)/scripts/Kbuild.include
 | |
| -include $(kbuild-file)
 | |
| 
 | |
| # $(generic)/Kbuild lists mandatory-y. Exclude um since it is a special case.
 | |
| ifneq ($(SRCARCH),um)
 | |
| include $(srctree)/$(generic)/Kbuild
 | |
| endif
 | |
| 
 | |
| redundant := $(filter $(mandatory-y) $(generated-y), $(generic-y))
 | |
| redundant += $(foreach f, $(generic-y), $(if $(wildcard $(src)/$(f)),$(f)))
 | |
| redundant := $(sort $(redundant))
 | |
| $(if $(redundant),\
 | |
| 	$(warning redundant generic-y found in $(src)/Kbuild: $(redundant)))
 | |
| 
 | |
| # If arch does not implement mandatory headers, fallback to asm-generic ones.
 | |
| mandatory-y := $(filter-out $(generated-y), $(mandatory-y))
 | |
| generic-y   += $(foreach f, $(mandatory-y), $(if $(wildcard $(src)/$(f)),,$(f)))
 | |
| 
 | |
| generic-y   := $(addprefix $(obj)/, $(generic-y))
 | |
| generated-y := $(addprefix $(obj)/, $(generated-y))
 | |
| 
 | |
| # Remove stale wrappers when the corresponding files are removed from generic-y
 | |
| old-headers := $(wildcard $(obj)/*.h)
 | |
| unwanted    := $(filter-out $(generic-y) $(generated-y),$(old-headers))
 | |
| 
 | |
| quiet_cmd_wrap = WRAP    $@
 | |
|       cmd_wrap = echo "\#include <asm-generic/$*.h>" > $@
 | |
| 
 | |
| quiet_cmd_remove = REMOVE  $(unwanted)
 | |
|       cmd_remove = rm -f $(unwanted)
 | |
| 
 | |
| all: $(generic-y)
 | |
| 	$(if $(unwanted),$(call cmd,remove))
 | |
| 	@:
 | |
| 
 | |
| $(obj)/%.h:
 | |
| 	$(call cmd,wrap)
 | |
| 
 | |
| # Create output directory. Skip it if at least one old header exists
 | |
| # since we know the output directory already exists.
 | |
| ifeq ($(old-headers),)
 | |
| $(shell mkdir -p $(obj))
 | |
| endif
 | |
| 
 | |
| .PHONY: $(PHONY)
 |