mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	syzbot reports that KMSAN complains that 'nr_tw' is an uninit-value
with the following report:
BUG: KMSAN: uninit-value in io_req_local_work_add io_uring/io_uring.c:1192 [inline]
BUG: KMSAN: uninit-value in io_req_task_work_add_remote+0x588/0x5d0 io_uring/io_uring.c:1240
 io_req_local_work_add io_uring/io_uring.c:1192 [inline]
 io_req_task_work_add_remote+0x588/0x5d0 io_uring/io_uring.c:1240
 io_msg_remote_post io_uring/msg_ring.c:102 [inline]
 io_msg_data_remote io_uring/msg_ring.c:133 [inline]
 io_msg_ring_data io_uring/msg_ring.c:152 [inline]
 io_msg_ring+0x1c38/0x1ef0 io_uring/msg_ring.c:305
 io_issue_sqe+0x383/0x22c0 io_uring/io_uring.c:1710
 io_queue_sqe io_uring/io_uring.c:1924 [inline]
 io_submit_sqe io_uring/io_uring.c:2180 [inline]
 io_submit_sqes+0x1259/0x2f20 io_uring/io_uring.c:2295
 __do_sys_io_uring_enter io_uring/io_uring.c:3205 [inline]
 __se_sys_io_uring_enter+0x40c/0x3ca0 io_uring/io_uring.c:3142
 __x64_sys_io_uring_enter+0x11f/0x1a0 io_uring/io_uring.c:3142
 x64_sys_call+0x2d82/0x3c10 arch/x86/include/generated/asm/syscalls_64.h:427
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
which is the following check:
if (nr_tw < nr_wait)
	return;
in io_req_local_work_add(). While nr_tw itself cannot be uninitialized,
it does depend on req->flags, which off the msg ring issue path can
indeed be uninitialized.
Fix this by always clearing the allocated 'req' fully if we can't grab
one from the cache itself.
Fixes: 50cf5f3842 ("io_uring/msg_ring: add an alloc cache for io_kiocb entries")
Reported-by: syzbot+82609b8937a4458106ca@syzkaller.appspotmail.com
Link: https://lore.kernel.org/io-uring/000000000000fd3d8d061dfc0e4a@google.com/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
		
	
			
		
			
				
	
	
		
			330 lines
		
	
	
	
		
			8.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			330 lines
		
	
	
	
		
			8.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/errno.h>
 | 
						|
#include <linux/file.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/nospec.h>
 | 
						|
#include <linux/io_uring.h>
 | 
						|
 | 
						|
#include <uapi/linux/io_uring.h>
 | 
						|
 | 
						|
#include "io_uring.h"
 | 
						|
#include "rsrc.h"
 | 
						|
#include "filetable.h"
 | 
						|
#include "alloc_cache.h"
 | 
						|
#include "msg_ring.h"
 | 
						|
 | 
						|
/* All valid masks for MSG_RING */
 | 
						|
#define IORING_MSG_RING_MASK		(IORING_MSG_RING_CQE_SKIP | \
 | 
						|
					IORING_MSG_RING_FLAGS_PASS)
 | 
						|
 | 
						|
struct io_msg {
 | 
						|
	struct file			*file;
 | 
						|
	struct file			*src_file;
 | 
						|
	struct callback_head		tw;
 | 
						|
	u64 user_data;
 | 
						|
	u32 len;
 | 
						|
	u32 cmd;
 | 
						|
	u32 src_fd;
 | 
						|
	union {
 | 
						|
		u32 dst_fd;
 | 
						|
		u32 cqe_flags;
 | 
						|
	};
 | 
						|
	u32 flags;
 | 
						|
};
 | 
						|
 | 
						|
static void io_double_unlock_ctx(struct io_ring_ctx *octx)
 | 
						|
{
 | 
						|
	mutex_unlock(&octx->uring_lock);
 | 
						|
}
 | 
						|
 | 
						|
static int io_double_lock_ctx(struct io_ring_ctx *octx,
 | 
						|
			      unsigned int issue_flags)
 | 
						|
{
 | 
						|
	/*
 | 
						|
	 * To ensure proper ordering between the two ctxs, we can only
 | 
						|
	 * attempt a trylock on the target. If that fails and we already have
 | 
						|
	 * the source ctx lock, punt to io-wq.
 | 
						|
	 */
 | 
						|
	if (!(issue_flags & IO_URING_F_UNLOCKED)) {
 | 
						|
		if (!mutex_trylock(&octx->uring_lock))
 | 
						|
			return -EAGAIN;
 | 
						|
		return 0;
 | 
						|
	}
 | 
						|
	mutex_lock(&octx->uring_lock);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
void io_msg_ring_cleanup(struct io_kiocb *req)
 | 
						|
{
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
 | 
						|
	if (WARN_ON_ONCE(!msg->src_file))
 | 
						|
		return;
 | 
						|
 | 
						|
	fput(msg->src_file);
 | 
						|
	msg->src_file = NULL;
 | 
						|
}
 | 
						|
 | 
						|
static inline bool io_msg_need_remote(struct io_ring_ctx *target_ctx)
 | 
						|
{
 | 
						|
	return target_ctx->task_complete;
 | 
						|
}
 | 
						|
 | 
						|
static void io_msg_tw_complete(struct io_kiocb *req, struct io_tw_state *ts)
 | 
						|
{
 | 
						|
	struct io_ring_ctx *ctx = req->ctx;
 | 
						|
 | 
						|
	io_add_aux_cqe(ctx, req->cqe.user_data, req->cqe.res, req->cqe.flags);
 | 
						|
	if (spin_trylock(&ctx->msg_lock)) {
 | 
						|
		if (io_alloc_cache_put(&ctx->msg_cache, req))
 | 
						|
			req = NULL;
 | 
						|
		spin_unlock(&ctx->msg_lock);
 | 
						|
	}
 | 
						|
	if (req)
 | 
						|
		kmem_cache_free(req_cachep, req);
 | 
						|
	percpu_ref_put(&ctx->refs);
 | 
						|
}
 | 
						|
 | 
						|
static int io_msg_remote_post(struct io_ring_ctx *ctx, struct io_kiocb *req,
 | 
						|
			      int res, u32 cflags, u64 user_data)
 | 
						|
{
 | 
						|
	req->task = READ_ONCE(ctx->submitter_task);
 | 
						|
	if (!req->task) {
 | 
						|
		kmem_cache_free(req_cachep, req);
 | 
						|
		return -EOWNERDEAD;
 | 
						|
	}
 | 
						|
	req->cqe.user_data = user_data;
 | 
						|
	io_req_set_res(req, res, cflags);
 | 
						|
	percpu_ref_get(&ctx->refs);
 | 
						|
	req->ctx = ctx;
 | 
						|
	req->io_task_work.func = io_msg_tw_complete;
 | 
						|
	io_req_task_work_add_remote(req, ctx, IOU_F_TWQ_LAZY_WAKE);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static struct io_kiocb *io_msg_get_kiocb(struct io_ring_ctx *ctx)
 | 
						|
{
 | 
						|
	struct io_kiocb *req = NULL;
 | 
						|
 | 
						|
	if (spin_trylock(&ctx->msg_lock)) {
 | 
						|
		req = io_alloc_cache_get(&ctx->msg_cache);
 | 
						|
		spin_unlock(&ctx->msg_lock);
 | 
						|
		if (req)
 | 
						|
			return req;
 | 
						|
	}
 | 
						|
	return kmem_cache_alloc(req_cachep, GFP_KERNEL | __GFP_NOWARN | __GFP_ZERO);
 | 
						|
}
 | 
						|
 | 
						|
static int io_msg_data_remote(struct io_kiocb *req)
 | 
						|
{
 | 
						|
	struct io_ring_ctx *target_ctx = req->file->private_data;
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	struct io_kiocb *target;
 | 
						|
	u32 flags = 0;
 | 
						|
 | 
						|
	target = io_msg_get_kiocb(req->ctx);
 | 
						|
	if (unlikely(!target))
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	if (msg->flags & IORING_MSG_RING_FLAGS_PASS)
 | 
						|
		flags = msg->cqe_flags;
 | 
						|
 | 
						|
	return io_msg_remote_post(target_ctx, target, msg->len, flags,
 | 
						|
					msg->user_data);
 | 
						|
}
 | 
						|
 | 
						|
static int io_msg_ring_data(struct io_kiocb *req, unsigned int issue_flags)
 | 
						|
{
 | 
						|
	struct io_ring_ctx *target_ctx = req->file->private_data;
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	u32 flags = 0;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	if (msg->src_fd || msg->flags & ~IORING_MSG_RING_FLAGS_PASS)
 | 
						|
		return -EINVAL;
 | 
						|
	if (!(msg->flags & IORING_MSG_RING_FLAGS_PASS) && msg->dst_fd)
 | 
						|
		return -EINVAL;
 | 
						|
	if (target_ctx->flags & IORING_SETUP_R_DISABLED)
 | 
						|
		return -EBADFD;
 | 
						|
 | 
						|
	if (io_msg_need_remote(target_ctx))
 | 
						|
		return io_msg_data_remote(req);
 | 
						|
 | 
						|
	if (msg->flags & IORING_MSG_RING_FLAGS_PASS)
 | 
						|
		flags = msg->cqe_flags;
 | 
						|
 | 
						|
	ret = -EOVERFLOW;
 | 
						|
	if (target_ctx->flags & IORING_SETUP_IOPOLL) {
 | 
						|
		if (unlikely(io_double_lock_ctx(target_ctx, issue_flags)))
 | 
						|
			return -EAGAIN;
 | 
						|
	}
 | 
						|
	if (io_post_aux_cqe(target_ctx, msg->user_data, msg->len, flags))
 | 
						|
		ret = 0;
 | 
						|
	if (target_ctx->flags & IORING_SETUP_IOPOLL)
 | 
						|
		io_double_unlock_ctx(target_ctx);
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static struct file *io_msg_grab_file(struct io_kiocb *req, unsigned int issue_flags)
 | 
						|
{
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	struct io_ring_ctx *ctx = req->ctx;
 | 
						|
	struct file *file = NULL;
 | 
						|
	int idx = msg->src_fd;
 | 
						|
 | 
						|
	io_ring_submit_lock(ctx, issue_flags);
 | 
						|
	if (likely(idx < ctx->nr_user_files)) {
 | 
						|
		idx = array_index_nospec(idx, ctx->nr_user_files);
 | 
						|
		file = io_file_from_index(&ctx->file_table, idx);
 | 
						|
		if (file)
 | 
						|
			get_file(file);
 | 
						|
	}
 | 
						|
	io_ring_submit_unlock(ctx, issue_flags);
 | 
						|
	return file;
 | 
						|
}
 | 
						|
 | 
						|
static int io_msg_install_complete(struct io_kiocb *req, unsigned int issue_flags)
 | 
						|
{
 | 
						|
	struct io_ring_ctx *target_ctx = req->file->private_data;
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	struct file *src_file = msg->src_file;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	if (unlikely(io_double_lock_ctx(target_ctx, issue_flags)))
 | 
						|
		return -EAGAIN;
 | 
						|
 | 
						|
	ret = __io_fixed_fd_install(target_ctx, src_file, msg->dst_fd);
 | 
						|
	if (ret < 0)
 | 
						|
		goto out_unlock;
 | 
						|
 | 
						|
	msg->src_file = NULL;
 | 
						|
	req->flags &= ~REQ_F_NEED_CLEANUP;
 | 
						|
 | 
						|
	if (msg->flags & IORING_MSG_RING_CQE_SKIP)
 | 
						|
		goto out_unlock;
 | 
						|
	/*
 | 
						|
	 * If this fails, the target still received the file descriptor but
 | 
						|
	 * wasn't notified of the fact. This means that if this request
 | 
						|
	 * completes with -EOVERFLOW, then the sender must ensure that a
 | 
						|
	 * later IORING_OP_MSG_RING delivers the message.
 | 
						|
	 */
 | 
						|
	if (!io_post_aux_cqe(target_ctx, msg->user_data, ret, 0))
 | 
						|
		ret = -EOVERFLOW;
 | 
						|
out_unlock:
 | 
						|
	io_double_unlock_ctx(target_ctx);
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static void io_msg_tw_fd_complete(struct callback_head *head)
 | 
						|
{
 | 
						|
	struct io_msg *msg = container_of(head, struct io_msg, tw);
 | 
						|
	struct io_kiocb *req = cmd_to_io_kiocb(msg);
 | 
						|
	int ret = -EOWNERDEAD;
 | 
						|
 | 
						|
	if (!(current->flags & PF_EXITING))
 | 
						|
		ret = io_msg_install_complete(req, IO_URING_F_UNLOCKED);
 | 
						|
	if (ret < 0)
 | 
						|
		req_set_fail(req);
 | 
						|
	io_req_queue_tw_complete(req, ret);
 | 
						|
}
 | 
						|
 | 
						|
static int io_msg_fd_remote(struct io_kiocb *req)
 | 
						|
{
 | 
						|
	struct io_ring_ctx *ctx = req->file->private_data;
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	struct task_struct *task = READ_ONCE(ctx->submitter_task);
 | 
						|
 | 
						|
	if (unlikely(!task))
 | 
						|
		return -EOWNERDEAD;
 | 
						|
 | 
						|
	init_task_work(&msg->tw, io_msg_tw_fd_complete);
 | 
						|
	if (task_work_add(task, &msg->tw, TWA_SIGNAL))
 | 
						|
		return -EOWNERDEAD;
 | 
						|
 | 
						|
	return IOU_ISSUE_SKIP_COMPLETE;
 | 
						|
}
 | 
						|
 | 
						|
static int io_msg_send_fd(struct io_kiocb *req, unsigned int issue_flags)
 | 
						|
{
 | 
						|
	struct io_ring_ctx *target_ctx = req->file->private_data;
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	struct io_ring_ctx *ctx = req->ctx;
 | 
						|
	struct file *src_file = msg->src_file;
 | 
						|
 | 
						|
	if (msg->len)
 | 
						|
		return -EINVAL;
 | 
						|
	if (target_ctx == ctx)
 | 
						|
		return -EINVAL;
 | 
						|
	if (target_ctx->flags & IORING_SETUP_R_DISABLED)
 | 
						|
		return -EBADFD;
 | 
						|
	if (!src_file) {
 | 
						|
		src_file = io_msg_grab_file(req, issue_flags);
 | 
						|
		if (!src_file)
 | 
						|
			return -EBADF;
 | 
						|
		msg->src_file = src_file;
 | 
						|
		req->flags |= REQ_F_NEED_CLEANUP;
 | 
						|
	}
 | 
						|
 | 
						|
	if (io_msg_need_remote(target_ctx))
 | 
						|
		return io_msg_fd_remote(req);
 | 
						|
	return io_msg_install_complete(req, issue_flags);
 | 
						|
}
 | 
						|
 | 
						|
int io_msg_ring_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 | 
						|
{
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
 | 
						|
	if (unlikely(sqe->buf_index || sqe->personality))
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	msg->src_file = NULL;
 | 
						|
	msg->user_data = READ_ONCE(sqe->off);
 | 
						|
	msg->len = READ_ONCE(sqe->len);
 | 
						|
	msg->cmd = READ_ONCE(sqe->addr);
 | 
						|
	msg->src_fd = READ_ONCE(sqe->addr3);
 | 
						|
	msg->dst_fd = READ_ONCE(sqe->file_index);
 | 
						|
	msg->flags = READ_ONCE(sqe->msg_ring_flags);
 | 
						|
	if (msg->flags & ~IORING_MSG_RING_MASK)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int io_msg_ring(struct io_kiocb *req, unsigned int issue_flags)
 | 
						|
{
 | 
						|
	struct io_msg *msg = io_kiocb_to_cmd(req, struct io_msg);
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = -EBADFD;
 | 
						|
	if (!io_is_uring_fops(req->file))
 | 
						|
		goto done;
 | 
						|
 | 
						|
	switch (msg->cmd) {
 | 
						|
	case IORING_MSG_DATA:
 | 
						|
		ret = io_msg_ring_data(req, issue_flags);
 | 
						|
		break;
 | 
						|
	case IORING_MSG_SEND_FD:
 | 
						|
		ret = io_msg_send_fd(req, issue_flags);
 | 
						|
		break;
 | 
						|
	default:
 | 
						|
		ret = -EINVAL;
 | 
						|
		break;
 | 
						|
	}
 | 
						|
 | 
						|
done:
 | 
						|
	if (ret < 0) {
 | 
						|
		if (ret == -EAGAIN || ret == IOU_ISSUE_SKIP_COMPLETE)
 | 
						|
			return ret;
 | 
						|
		req_set_fail(req);
 | 
						|
	}
 | 
						|
	io_req_set_res(req, ret, 0);
 | 
						|
	return IOU_OK;
 | 
						|
}
 | 
						|
 | 
						|
void io_msg_cache_free(const void *entry)
 | 
						|
{
 | 
						|
	struct io_kiocb *req = (struct io_kiocb *) entry;
 | 
						|
 | 
						|
	kmem_cache_free(req_cachep, req);
 | 
						|
}
 |