mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	Dave Jones reported a lockdep splat occurring in IP defrag code.
commit 6d7b857d54 (net: use lib/percpu_counter API for
fragmentation mem accounting) added a possible deadlock.
Because percpu_counter_sum_positive() needs to acquire
a lock that can be used from softirq, we need to disable BH
in sum_frag_mem_limit()
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
		
	
			
		
			
				
	
	
		
			147 lines
		
	
	
	
		
			3.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			147 lines
		
	
	
	
		
			3.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef __NET_FRAG_H__
 | 
						|
#define __NET_FRAG_H__
 | 
						|
 | 
						|
#include <linux/percpu_counter.h>
 | 
						|
 | 
						|
struct netns_frags {
 | 
						|
	int			nqueues;
 | 
						|
	struct list_head	lru_list;
 | 
						|
	spinlock_t		lru_lock;
 | 
						|
 | 
						|
	/* The percpu_counter "mem" need to be cacheline aligned.
 | 
						|
	 *  mem.count must not share cacheline with other writers
 | 
						|
	 */
 | 
						|
	struct percpu_counter   mem ____cacheline_aligned_in_smp;
 | 
						|
 | 
						|
	/* sysctls */
 | 
						|
	int			timeout;
 | 
						|
	int			high_thresh;
 | 
						|
	int			low_thresh;
 | 
						|
};
 | 
						|
 | 
						|
struct inet_frag_queue {
 | 
						|
	spinlock_t		lock;
 | 
						|
	struct timer_list	timer;      /* when will this queue expire? */
 | 
						|
	struct list_head	lru_list;   /* lru list member */
 | 
						|
	struct hlist_node	list;
 | 
						|
	atomic_t		refcnt;
 | 
						|
	struct sk_buff		*fragments; /* list of received fragments */
 | 
						|
	struct sk_buff		*fragments_tail;
 | 
						|
	ktime_t			stamp;
 | 
						|
	int			len;        /* total length of orig datagram */
 | 
						|
	int			meat;
 | 
						|
	__u8			last_in;    /* first/last segment arrived? */
 | 
						|
 | 
						|
#define INET_FRAG_COMPLETE	4
 | 
						|
#define INET_FRAG_FIRST_IN	2
 | 
						|
#define INET_FRAG_LAST_IN	1
 | 
						|
 | 
						|
	u16			max_size;
 | 
						|
 | 
						|
	struct netns_frags	*net;
 | 
						|
};
 | 
						|
 | 
						|
#define INETFRAGS_HASHSZ		64
 | 
						|
 | 
						|
struct inet_frags {
 | 
						|
	struct hlist_head	hash[INETFRAGS_HASHSZ];
 | 
						|
	/* This rwlock is a global lock (seperate per IPv4, IPv6 and
 | 
						|
	 * netfilter). Important to keep this on a seperate cacheline.
 | 
						|
	 */
 | 
						|
	rwlock_t		lock ____cacheline_aligned_in_smp;
 | 
						|
	int			secret_interval;
 | 
						|
	struct timer_list	secret_timer;
 | 
						|
	u32			rnd;
 | 
						|
	int			qsize;
 | 
						|
 | 
						|
	unsigned int		(*hashfn)(struct inet_frag_queue *);
 | 
						|
	bool			(*match)(struct inet_frag_queue *q, void *arg);
 | 
						|
	void			(*constructor)(struct inet_frag_queue *q,
 | 
						|
						void *arg);
 | 
						|
	void			(*destructor)(struct inet_frag_queue *);
 | 
						|
	void			(*skb_free)(struct sk_buff *);
 | 
						|
	void			(*frag_expire)(unsigned long data);
 | 
						|
};
 | 
						|
 | 
						|
void inet_frags_init(struct inet_frags *);
 | 
						|
void inet_frags_fini(struct inet_frags *);
 | 
						|
 | 
						|
void inet_frags_init_net(struct netns_frags *nf);
 | 
						|
void inet_frags_exit_net(struct netns_frags *nf, struct inet_frags *f);
 | 
						|
 | 
						|
void inet_frag_kill(struct inet_frag_queue *q, struct inet_frags *f);
 | 
						|
void inet_frag_destroy(struct inet_frag_queue *q,
 | 
						|
				struct inet_frags *f, int *work);
 | 
						|
int inet_frag_evictor(struct netns_frags *nf, struct inet_frags *f, bool force);
 | 
						|
struct inet_frag_queue *inet_frag_find(struct netns_frags *nf,
 | 
						|
		struct inet_frags *f, void *key, unsigned int hash)
 | 
						|
	__releases(&f->lock);
 | 
						|
 | 
						|
static inline void inet_frag_put(struct inet_frag_queue *q, struct inet_frags *f)
 | 
						|
{
 | 
						|
	if (atomic_dec_and_test(&q->refcnt))
 | 
						|
		inet_frag_destroy(q, f, NULL);
 | 
						|
}
 | 
						|
 | 
						|
/* Memory Tracking Functions. */
 | 
						|
 | 
						|
/* The default percpu_counter batch size is not big enough to scale to
 | 
						|
 * fragmentation mem acct sizes.
 | 
						|
 * The mem size of a 64K fragment is approx:
 | 
						|
 *  (44 fragments * 2944 truesize) + frag_queue struct(200) = 129736 bytes
 | 
						|
 */
 | 
						|
static unsigned int frag_percpu_counter_batch = 130000;
 | 
						|
 | 
						|
static inline int frag_mem_limit(struct netns_frags *nf)
 | 
						|
{
 | 
						|
	return percpu_counter_read(&nf->mem);
 | 
						|
}
 | 
						|
 | 
						|
static inline void sub_frag_mem_limit(struct inet_frag_queue *q, int i)
 | 
						|
{
 | 
						|
	__percpu_counter_add(&q->net->mem, -i, frag_percpu_counter_batch);
 | 
						|
}
 | 
						|
 | 
						|
static inline void add_frag_mem_limit(struct inet_frag_queue *q, int i)
 | 
						|
{
 | 
						|
	__percpu_counter_add(&q->net->mem, i, frag_percpu_counter_batch);
 | 
						|
}
 | 
						|
 | 
						|
static inline void init_frag_mem_limit(struct netns_frags *nf)
 | 
						|
{
 | 
						|
	percpu_counter_init(&nf->mem, 0);
 | 
						|
}
 | 
						|
 | 
						|
static inline int sum_frag_mem_limit(struct netns_frags *nf)
 | 
						|
{
 | 
						|
	int res;
 | 
						|
 | 
						|
	local_bh_disable();
 | 
						|
	res = percpu_counter_sum_positive(&nf->mem);
 | 
						|
	local_bh_enable();
 | 
						|
 | 
						|
	return res;
 | 
						|
}
 | 
						|
 | 
						|
static inline void inet_frag_lru_move(struct inet_frag_queue *q)
 | 
						|
{
 | 
						|
	spin_lock(&q->net->lru_lock);
 | 
						|
	list_move_tail(&q->lru_list, &q->net->lru_list);
 | 
						|
	spin_unlock(&q->net->lru_lock);
 | 
						|
}
 | 
						|
 | 
						|
static inline void inet_frag_lru_del(struct inet_frag_queue *q)
 | 
						|
{
 | 
						|
	spin_lock(&q->net->lru_lock);
 | 
						|
	list_del(&q->lru_list);
 | 
						|
	spin_unlock(&q->net->lru_lock);
 | 
						|
}
 | 
						|
 | 
						|
static inline void inet_frag_lru_add(struct netns_frags *nf,
 | 
						|
				     struct inet_frag_queue *q)
 | 
						|
{
 | 
						|
	spin_lock(&nf->lru_lock);
 | 
						|
	list_add_tail(&q->lru_list, &nf->lru_list);
 | 
						|
	spin_unlock(&nf->lru_lock);
 | 
						|
}
 | 
						|
#endif
 |