mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	Fix sparse warning: drivers/net/netdevsim/bus.c:253:5: warning: symbol 'nsim_num_vf' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
		
			
				
	
	
		
			341 lines
		
	
	
	
		
			7.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			341 lines
		
	
	
	
		
			7.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0
 | 
						|
/* Copyright (C) 2017 Netronome Systems, Inc.
 | 
						|
 * Copyright (C) 2019 Mellanox Technologies. All rights reserved
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/device.h>
 | 
						|
#include <linux/idr.h>
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/list.h>
 | 
						|
#include <linux/mutex.h>
 | 
						|
#include <linux/rtnetlink.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/sysfs.h>
 | 
						|
 | 
						|
#include "netdevsim.h"
 | 
						|
 | 
						|
static DEFINE_IDA(nsim_bus_dev_ids);
 | 
						|
static LIST_HEAD(nsim_bus_dev_list);
 | 
						|
static DEFINE_MUTEX(nsim_bus_dev_list_lock);
 | 
						|
 | 
						|
static struct nsim_bus_dev *to_nsim_bus_dev(struct device *dev)
 | 
						|
{
 | 
						|
	return container_of(dev, struct nsim_bus_dev, dev);
 | 
						|
}
 | 
						|
 | 
						|
static int nsim_bus_dev_vfs_enable(struct nsim_bus_dev *nsim_bus_dev,
 | 
						|
				   unsigned int num_vfs)
 | 
						|
{
 | 
						|
	nsim_bus_dev->vfconfigs = kcalloc(num_vfs,
 | 
						|
					  sizeof(struct nsim_vf_config),
 | 
						|
					  GFP_KERNEL);
 | 
						|
	if (!nsim_bus_dev->vfconfigs)
 | 
						|
		return -ENOMEM;
 | 
						|
	nsim_bus_dev->num_vfs = num_vfs;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void nsim_bus_dev_vfs_disable(struct nsim_bus_dev *nsim_bus_dev)
 | 
						|
{
 | 
						|
	kfree(nsim_bus_dev->vfconfigs);
 | 
						|
	nsim_bus_dev->vfconfigs = NULL;
 | 
						|
	nsim_bus_dev->num_vfs = 0;
 | 
						|
}
 | 
						|
 | 
						|
static ssize_t
 | 
						|
nsim_bus_dev_numvfs_store(struct device *dev, struct device_attribute *attr,
 | 
						|
			  const char *buf, size_t count)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
	unsigned int num_vfs;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = kstrtouint(buf, 0, &num_vfs);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	rtnl_lock();
 | 
						|
	if (nsim_bus_dev->num_vfs == num_vfs)
 | 
						|
		goto exit_good;
 | 
						|
	if (nsim_bus_dev->num_vfs && num_vfs) {
 | 
						|
		ret = -EBUSY;
 | 
						|
		goto exit_unlock;
 | 
						|
	}
 | 
						|
 | 
						|
	if (num_vfs) {
 | 
						|
		ret = nsim_bus_dev_vfs_enable(nsim_bus_dev, num_vfs);
 | 
						|
		if (ret)
 | 
						|
			goto exit_unlock;
 | 
						|
	} else {
 | 
						|
		nsim_bus_dev_vfs_disable(nsim_bus_dev);
 | 
						|
	}
 | 
						|
exit_good:
 | 
						|
	ret = count;
 | 
						|
exit_unlock:
 | 
						|
	rtnl_unlock();
 | 
						|
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static ssize_t
 | 
						|
nsim_bus_dev_numvfs_show(struct device *dev,
 | 
						|
			 struct device_attribute *attr, char *buf)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
 | 
						|
	return sprintf(buf, "%u\n", nsim_bus_dev->num_vfs);
 | 
						|
}
 | 
						|
 | 
						|
static struct device_attribute nsim_bus_dev_numvfs_attr =
 | 
						|
	__ATTR(sriov_numvfs, 0664, nsim_bus_dev_numvfs_show,
 | 
						|
	       nsim_bus_dev_numvfs_store);
 | 
						|
 | 
						|
static ssize_t
 | 
						|
new_port_store(struct device *dev, struct device_attribute *attr,
 | 
						|
	       const char *buf, size_t count)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
	unsigned int port_index;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = kstrtouint(buf, 0, &port_index);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
	ret = nsim_dev_port_add(nsim_bus_dev, port_index);
 | 
						|
	return ret ? ret : count;
 | 
						|
}
 | 
						|
 | 
						|
static struct device_attribute nsim_bus_dev_new_port_attr = __ATTR_WO(new_port);
 | 
						|
 | 
						|
static ssize_t
 | 
						|
del_port_store(struct device *dev, struct device_attribute *attr,
 | 
						|
	       const char *buf, size_t count)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
	unsigned int port_index;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = kstrtouint(buf, 0, &port_index);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
	ret = nsim_dev_port_del(nsim_bus_dev, port_index);
 | 
						|
	return ret ? ret : count;
 | 
						|
}
 | 
						|
 | 
						|
static struct device_attribute nsim_bus_dev_del_port_attr = __ATTR_WO(del_port);
 | 
						|
 | 
						|
static struct attribute *nsim_bus_dev_attrs[] = {
 | 
						|
	&nsim_bus_dev_numvfs_attr.attr,
 | 
						|
	&nsim_bus_dev_new_port_attr.attr,
 | 
						|
	&nsim_bus_dev_del_port_attr.attr,
 | 
						|
	NULL,
 | 
						|
};
 | 
						|
 | 
						|
static const struct attribute_group nsim_bus_dev_attr_group = {
 | 
						|
	.attrs = nsim_bus_dev_attrs,
 | 
						|
};
 | 
						|
 | 
						|
static const struct attribute_group *nsim_bus_dev_attr_groups[] = {
 | 
						|
	&nsim_bus_dev_attr_group,
 | 
						|
	NULL,
 | 
						|
};
 | 
						|
 | 
						|
static void nsim_bus_dev_release(struct device *dev)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
 | 
						|
	nsim_bus_dev_vfs_disable(nsim_bus_dev);
 | 
						|
}
 | 
						|
 | 
						|
static struct device_type nsim_bus_dev_type = {
 | 
						|
	.groups = nsim_bus_dev_attr_groups,
 | 
						|
	.release = nsim_bus_dev_release,
 | 
						|
};
 | 
						|
 | 
						|
static struct nsim_bus_dev *
 | 
						|
nsim_bus_dev_new(unsigned int id, unsigned int port_count);
 | 
						|
 | 
						|
static ssize_t
 | 
						|
new_device_store(struct bus_type *bus, const char *buf, size_t count)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev;
 | 
						|
	unsigned int port_count;
 | 
						|
	unsigned int id;
 | 
						|
	int err;
 | 
						|
 | 
						|
	err = sscanf(buf, "%u %u", &id, &port_count);
 | 
						|
	switch (err) {
 | 
						|
	case 1:
 | 
						|
		port_count = 1;
 | 
						|
		/* fall through */
 | 
						|
	case 2:
 | 
						|
		if (id > INT_MAX) {
 | 
						|
			pr_err("Value of \"id\" is too big.\n");
 | 
						|
			return -EINVAL;
 | 
						|
		}
 | 
						|
		break;
 | 
						|
	default:
 | 
						|
		pr_err("Format for adding new device is \"id port_count\" (uint uint).\n");
 | 
						|
		return -EINVAL;
 | 
						|
	}
 | 
						|
	nsim_bus_dev = nsim_bus_dev_new(id, port_count);
 | 
						|
	if (IS_ERR(nsim_bus_dev))
 | 
						|
		return PTR_ERR(nsim_bus_dev);
 | 
						|
 | 
						|
	mutex_lock(&nsim_bus_dev_list_lock);
 | 
						|
	list_add_tail(&nsim_bus_dev->list, &nsim_bus_dev_list);
 | 
						|
	mutex_unlock(&nsim_bus_dev_list_lock);
 | 
						|
 | 
						|
	return count;
 | 
						|
}
 | 
						|
static BUS_ATTR_WO(new_device);
 | 
						|
 | 
						|
static void nsim_bus_dev_del(struct nsim_bus_dev *nsim_bus_dev);
 | 
						|
 | 
						|
static ssize_t
 | 
						|
del_device_store(struct bus_type *bus, const char *buf, size_t count)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev, *tmp;
 | 
						|
	unsigned int id;
 | 
						|
	int err;
 | 
						|
 | 
						|
	err = sscanf(buf, "%u", &id);
 | 
						|
	switch (err) {
 | 
						|
	case 1:
 | 
						|
		if (id > INT_MAX) {
 | 
						|
			pr_err("Value of \"id\" is too big.\n");
 | 
						|
			return -EINVAL;
 | 
						|
		}
 | 
						|
		break;
 | 
						|
	default:
 | 
						|
		pr_err("Format for deleting device is \"id\" (uint).\n");
 | 
						|
		return -EINVAL;
 | 
						|
	}
 | 
						|
 | 
						|
	err = -ENOENT;
 | 
						|
	mutex_lock(&nsim_bus_dev_list_lock);
 | 
						|
	list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list) {
 | 
						|
		if (nsim_bus_dev->dev.id != id)
 | 
						|
			continue;
 | 
						|
		list_del(&nsim_bus_dev->list);
 | 
						|
		nsim_bus_dev_del(nsim_bus_dev);
 | 
						|
		err = 0;
 | 
						|
		break;
 | 
						|
	}
 | 
						|
	mutex_unlock(&nsim_bus_dev_list_lock);
 | 
						|
	return !err ? count : err;
 | 
						|
}
 | 
						|
static BUS_ATTR_WO(del_device);
 | 
						|
 | 
						|
static struct attribute *nsim_bus_attrs[] = {
 | 
						|
	&bus_attr_new_device.attr,
 | 
						|
	&bus_attr_del_device.attr,
 | 
						|
	NULL
 | 
						|
};
 | 
						|
ATTRIBUTE_GROUPS(nsim_bus);
 | 
						|
 | 
						|
static int nsim_bus_probe(struct device *dev)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
 | 
						|
	return nsim_dev_probe(nsim_bus_dev);
 | 
						|
}
 | 
						|
 | 
						|
static int nsim_bus_remove(struct device *dev)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
 | 
						|
	nsim_dev_remove(nsim_bus_dev);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int nsim_num_vf(struct device *dev)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
 | 
						|
 | 
						|
	return nsim_bus_dev->num_vfs;
 | 
						|
}
 | 
						|
 | 
						|
static struct bus_type nsim_bus = {
 | 
						|
	.name		= DRV_NAME,
 | 
						|
	.dev_name	= DRV_NAME,
 | 
						|
	.bus_groups	= nsim_bus_groups,
 | 
						|
	.probe		= nsim_bus_probe,
 | 
						|
	.remove		= nsim_bus_remove,
 | 
						|
	.num_vf		= nsim_num_vf,
 | 
						|
};
 | 
						|
 | 
						|
static struct nsim_bus_dev *
 | 
						|
nsim_bus_dev_new(unsigned int id, unsigned int port_count)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev;
 | 
						|
	int err;
 | 
						|
 | 
						|
	nsim_bus_dev = kzalloc(sizeof(*nsim_bus_dev), GFP_KERNEL);
 | 
						|
	if (!nsim_bus_dev)
 | 
						|
		return ERR_PTR(-ENOMEM);
 | 
						|
 | 
						|
	err = ida_alloc_range(&nsim_bus_dev_ids, id, id, GFP_KERNEL);
 | 
						|
	if (err < 0)
 | 
						|
		goto err_nsim_bus_dev_free;
 | 
						|
	nsim_bus_dev->dev.id = err;
 | 
						|
	nsim_bus_dev->dev.bus = &nsim_bus;
 | 
						|
	nsim_bus_dev->dev.type = &nsim_bus_dev_type;
 | 
						|
	nsim_bus_dev->port_count = port_count;
 | 
						|
 | 
						|
	err = device_register(&nsim_bus_dev->dev);
 | 
						|
	if (err)
 | 
						|
		goto err_nsim_bus_dev_id_free;
 | 
						|
	return nsim_bus_dev;
 | 
						|
 | 
						|
err_nsim_bus_dev_id_free:
 | 
						|
	ida_free(&nsim_bus_dev_ids, nsim_bus_dev->dev.id);
 | 
						|
err_nsim_bus_dev_free:
 | 
						|
	kfree(nsim_bus_dev);
 | 
						|
	return ERR_PTR(err);
 | 
						|
}
 | 
						|
 | 
						|
static void nsim_bus_dev_del(struct nsim_bus_dev *nsim_bus_dev)
 | 
						|
{
 | 
						|
	device_unregister(&nsim_bus_dev->dev);
 | 
						|
	ida_free(&nsim_bus_dev_ids, nsim_bus_dev->dev.id);
 | 
						|
	kfree(nsim_bus_dev);
 | 
						|
}
 | 
						|
 | 
						|
static struct device_driver nsim_driver = {
 | 
						|
	.name		= DRV_NAME,
 | 
						|
	.bus		= &nsim_bus,
 | 
						|
	.owner		= THIS_MODULE,
 | 
						|
};
 | 
						|
 | 
						|
int nsim_bus_init(void)
 | 
						|
{
 | 
						|
	int err;
 | 
						|
 | 
						|
	err = bus_register(&nsim_bus);
 | 
						|
	if (err)
 | 
						|
		return err;
 | 
						|
	err = driver_register(&nsim_driver);
 | 
						|
	if (err)
 | 
						|
		goto err_bus_unregister;
 | 
						|
	return 0;
 | 
						|
 | 
						|
err_bus_unregister:
 | 
						|
	bus_unregister(&nsim_bus);
 | 
						|
	return err;
 | 
						|
}
 | 
						|
 | 
						|
void nsim_bus_exit(void)
 | 
						|
{
 | 
						|
	struct nsim_bus_dev *nsim_bus_dev, *tmp;
 | 
						|
 | 
						|
	mutex_lock(&nsim_bus_dev_list_lock);
 | 
						|
	list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list) {
 | 
						|
		list_del(&nsim_bus_dev->list);
 | 
						|
		nsim_bus_dev_del(nsim_bus_dev);
 | 
						|
	}
 | 
						|
	mutex_unlock(&nsim_bus_dev_list_lock);
 | 
						|
	driver_unregister(&nsim_driver);
 | 
						|
	bus_unregister(&nsim_bus);
 | 
						|
}
 |