mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_helper.h includes. v2: Make it compile. There was so much compile fail on arm drivers that I figured I'll better not include any of the acks on v1. v3: Massive rebase because i915 has lost a lot of drmP.h includes, but not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h there was still one, which this patch largely removes. Which means rolling out lots more includes all over. This will also conflict with ongoing drmP.h cleanup by others I expect. v3: Rebase on top of atomic bochs. v4: Review from Laurent for bridge/rcar/omap/shmob/core bits: - (re)move some of the added includes, use the better include files in other places (all suggested from Laurent adopted unchanged). - sort alphabetically v5: Actually try to sort them, and while at it, sort all the ones I touch. v6: Rebase onto i915 changes. v7: Rebase once more. Acked-by: Harry Wentland <harry.wentland@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> Acked-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Neil Armstrong <narmstrong@baylibre.com> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Acked-by: CK Hu <ck.hu@mediatek.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: linux-arm-kernel@lists.infradead.org Cc: virtualization@lists.linux-foundation.org Cc: etnaviv@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Cc: linux-mediatek@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Cc: spice-devel@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-tegra@vger.kernel.org Cc: xen-devel@lists.xen.org Link: https://patchwork.freedesktop.org/patch/msgid/20190117210334.13234-1-daniel.vetter@ffwll.ch
		
			
				
	
	
		
			293 lines
		
	
	
	
		
			7.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			293 lines
		
	
	
	
		
			7.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0+
 | 
						|
/*
 | 
						|
 * i.MX drm driver - parallel display implementation
 | 
						|
 *
 | 
						|
 * Copyright (C) 2012 Sascha Hauer, Pengutronix
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/component.h>
 | 
						|
#include <linux/module.h>
 | 
						|
#include <drm/drmP.h>
 | 
						|
#include <drm/drm_atomic_helper.h>
 | 
						|
#include <drm/drm_fb_helper.h>
 | 
						|
#include <drm/drm_of.h>
 | 
						|
#include <drm/drm_panel.h>
 | 
						|
#include <drm/drm_probe_helper.h>
 | 
						|
#include <linux/videodev2.h>
 | 
						|
#include <video/of_display_timing.h>
 | 
						|
 | 
						|
#include "imx-drm.h"
 | 
						|
 | 
						|
struct imx_parallel_display {
 | 
						|
	struct drm_connector connector;
 | 
						|
	struct drm_encoder encoder;
 | 
						|
	struct device *dev;
 | 
						|
	void *edid;
 | 
						|
	int edid_len;
 | 
						|
	u32 bus_format;
 | 
						|
	u32 bus_flags;
 | 
						|
	struct drm_display_mode mode;
 | 
						|
	struct drm_panel *panel;
 | 
						|
	struct drm_bridge *bridge;
 | 
						|
};
 | 
						|
 | 
						|
static inline struct imx_parallel_display *con_to_imxpd(struct drm_connector *c)
 | 
						|
{
 | 
						|
	return container_of(c, struct imx_parallel_display, connector);
 | 
						|
}
 | 
						|
 | 
						|
static inline struct imx_parallel_display *enc_to_imxpd(struct drm_encoder *e)
 | 
						|
{
 | 
						|
	return container_of(e, struct imx_parallel_display, encoder);
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_connector_get_modes(struct drm_connector *connector)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = con_to_imxpd(connector);
 | 
						|
	struct device_node *np = imxpd->dev->of_node;
 | 
						|
	int num_modes = 0;
 | 
						|
 | 
						|
	if (imxpd->panel && imxpd->panel->funcs &&
 | 
						|
	    imxpd->panel->funcs->get_modes) {
 | 
						|
		num_modes = imxpd->panel->funcs->get_modes(imxpd->panel);
 | 
						|
		if (num_modes > 0)
 | 
						|
			return num_modes;
 | 
						|
	}
 | 
						|
 | 
						|
	if (imxpd->edid) {
 | 
						|
		drm_connector_update_edid_property(connector, imxpd->edid);
 | 
						|
		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 | 
						|
	}
 | 
						|
 | 
						|
	if (np) {
 | 
						|
		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 | 
						|
		int ret;
 | 
						|
 | 
						|
		if (!mode)
 | 
						|
			return -EINVAL;
 | 
						|
 | 
						|
		ret = of_get_drm_display_mode(np, &imxpd->mode,
 | 
						|
					      &imxpd->bus_flags,
 | 
						|
					      OF_USE_NATIVE_MODE);
 | 
						|
		if (ret)
 | 
						|
			return ret;
 | 
						|
 | 
						|
		drm_mode_copy(mode, &imxpd->mode);
 | 
						|
		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
 | 
						|
		drm_mode_probed_add(connector, mode);
 | 
						|
		num_modes++;
 | 
						|
	}
 | 
						|
 | 
						|
	return num_modes;
 | 
						|
}
 | 
						|
 | 
						|
static struct drm_encoder *imx_pd_connector_best_encoder(
 | 
						|
		struct drm_connector *connector)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = con_to_imxpd(connector);
 | 
						|
 | 
						|
	return &imxpd->encoder;
 | 
						|
}
 | 
						|
 | 
						|
static void imx_pd_encoder_enable(struct drm_encoder *encoder)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
 | 
						|
 | 
						|
	drm_panel_prepare(imxpd->panel);
 | 
						|
	drm_panel_enable(imxpd->panel);
 | 
						|
}
 | 
						|
 | 
						|
static void imx_pd_encoder_disable(struct drm_encoder *encoder)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
 | 
						|
 | 
						|
	drm_panel_disable(imxpd->panel);
 | 
						|
	drm_panel_unprepare(imxpd->panel);
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_encoder_atomic_check(struct drm_encoder *encoder,
 | 
						|
				       struct drm_crtc_state *crtc_state,
 | 
						|
				       struct drm_connector_state *conn_state)
 | 
						|
{
 | 
						|
	struct imx_crtc_state *imx_crtc_state = to_imx_crtc_state(crtc_state);
 | 
						|
	struct drm_display_info *di = &conn_state->connector->display_info;
 | 
						|
	struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
 | 
						|
 | 
						|
	if (!imxpd->bus_format && di->num_bus_formats) {
 | 
						|
		imx_crtc_state->bus_flags = di->bus_flags;
 | 
						|
		imx_crtc_state->bus_format = di->bus_formats[0];
 | 
						|
	} else {
 | 
						|
		imx_crtc_state->bus_flags = imxpd->bus_flags;
 | 
						|
		imx_crtc_state->bus_format = imxpd->bus_format;
 | 
						|
	}
 | 
						|
	imx_crtc_state->di_hsync_pin = 2;
 | 
						|
	imx_crtc_state->di_vsync_pin = 3;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static const struct drm_connector_funcs imx_pd_connector_funcs = {
 | 
						|
	.fill_modes = drm_helper_probe_single_connector_modes,
 | 
						|
	.destroy = imx_drm_connector_destroy,
 | 
						|
	.reset = drm_atomic_helper_connector_reset,
 | 
						|
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 | 
						|
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 | 
						|
};
 | 
						|
 | 
						|
static const struct drm_connector_helper_funcs imx_pd_connector_helper_funcs = {
 | 
						|
	.get_modes = imx_pd_connector_get_modes,
 | 
						|
	.best_encoder = imx_pd_connector_best_encoder,
 | 
						|
};
 | 
						|
 | 
						|
static const struct drm_encoder_funcs imx_pd_encoder_funcs = {
 | 
						|
	.destroy = imx_drm_encoder_destroy,
 | 
						|
};
 | 
						|
 | 
						|
static const struct drm_encoder_helper_funcs imx_pd_encoder_helper_funcs = {
 | 
						|
	.enable = imx_pd_encoder_enable,
 | 
						|
	.disable = imx_pd_encoder_disable,
 | 
						|
	.atomic_check = imx_pd_encoder_atomic_check,
 | 
						|
};
 | 
						|
 | 
						|
static int imx_pd_register(struct drm_device *drm,
 | 
						|
	struct imx_parallel_display *imxpd)
 | 
						|
{
 | 
						|
	struct drm_encoder *encoder = &imxpd->encoder;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = imx_drm_encoder_parse_of(drm, encoder, imxpd->dev->of_node);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	/* set the connector's dpms to OFF so that
 | 
						|
	 * drm_helper_connector_dpms() won't return
 | 
						|
	 * immediately since the current state is ON
 | 
						|
	 * at this point.
 | 
						|
	 */
 | 
						|
	imxpd->connector.dpms = DRM_MODE_DPMS_OFF;
 | 
						|
 | 
						|
	drm_encoder_helper_add(encoder, &imx_pd_encoder_helper_funcs);
 | 
						|
	drm_encoder_init(drm, encoder, &imx_pd_encoder_funcs,
 | 
						|
			 DRM_MODE_ENCODER_NONE, NULL);
 | 
						|
 | 
						|
	if (!imxpd->bridge) {
 | 
						|
		drm_connector_helper_add(&imxpd->connector,
 | 
						|
				&imx_pd_connector_helper_funcs);
 | 
						|
		drm_connector_init(drm, &imxpd->connector,
 | 
						|
				   &imx_pd_connector_funcs,
 | 
						|
				   DRM_MODE_CONNECTOR_DPI);
 | 
						|
	}
 | 
						|
 | 
						|
	if (imxpd->panel)
 | 
						|
		drm_panel_attach(imxpd->panel, &imxpd->connector);
 | 
						|
 | 
						|
	if (imxpd->bridge) {
 | 
						|
		ret = drm_bridge_attach(encoder, imxpd->bridge, NULL);
 | 
						|
		if (ret < 0) {
 | 
						|
			dev_err(imxpd->dev, "failed to attach bridge: %d\n",
 | 
						|
				ret);
 | 
						|
			return ret;
 | 
						|
		}
 | 
						|
	} else {
 | 
						|
		drm_connector_attach_encoder(&imxpd->connector, encoder);
 | 
						|
	}
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_bind(struct device *dev, struct device *master, void *data)
 | 
						|
{
 | 
						|
	struct drm_device *drm = data;
 | 
						|
	struct device_node *np = dev->of_node;
 | 
						|
	const u8 *edidp;
 | 
						|
	struct imx_parallel_display *imxpd;
 | 
						|
	int ret;
 | 
						|
	u32 bus_format = 0;
 | 
						|
	const char *fmt;
 | 
						|
 | 
						|
	imxpd = devm_kzalloc(dev, sizeof(*imxpd), GFP_KERNEL);
 | 
						|
	if (!imxpd)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	edidp = of_get_property(np, "edid", &imxpd->edid_len);
 | 
						|
	if (edidp)
 | 
						|
		imxpd->edid = kmemdup(edidp, imxpd->edid_len, GFP_KERNEL);
 | 
						|
 | 
						|
	ret = of_property_read_string(np, "interface-pix-fmt", &fmt);
 | 
						|
	if (!ret) {
 | 
						|
		if (!strcmp(fmt, "rgb24"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB888_1X24;
 | 
						|
		else if (!strcmp(fmt, "rgb565"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB565_1X16;
 | 
						|
		else if (!strcmp(fmt, "bgr666"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB666_1X18;
 | 
						|
		else if (!strcmp(fmt, "lvds666"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
 | 
						|
	}
 | 
						|
	imxpd->bus_format = bus_format;
 | 
						|
 | 
						|
	/* port@1 is the output port */
 | 
						|
	ret = drm_of_find_panel_or_bridge(np, 1, 0, &imxpd->panel, &imxpd->bridge);
 | 
						|
	if (ret && ret != -ENODEV)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	imxpd->dev = dev;
 | 
						|
 | 
						|
	ret = imx_pd_register(drm, imxpd);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	dev_set_drvdata(dev, imxpd);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void imx_pd_unbind(struct device *dev, struct device *master,
 | 
						|
	void *data)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = dev_get_drvdata(dev);
 | 
						|
 | 
						|
	if (imxpd->panel)
 | 
						|
		drm_panel_detach(imxpd->panel);
 | 
						|
 | 
						|
	kfree(imxpd->edid);
 | 
						|
}
 | 
						|
 | 
						|
static const struct component_ops imx_pd_ops = {
 | 
						|
	.bind	= imx_pd_bind,
 | 
						|
	.unbind	= imx_pd_unbind,
 | 
						|
};
 | 
						|
 | 
						|
static int imx_pd_probe(struct platform_device *pdev)
 | 
						|
{
 | 
						|
	return component_add(&pdev->dev, &imx_pd_ops);
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_remove(struct platform_device *pdev)
 | 
						|
{
 | 
						|
	component_del(&pdev->dev, &imx_pd_ops);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static const struct of_device_id imx_pd_dt_ids[] = {
 | 
						|
	{ .compatible = "fsl,imx-parallel-display", },
 | 
						|
	{ /* sentinel */ }
 | 
						|
};
 | 
						|
MODULE_DEVICE_TABLE(of, imx_pd_dt_ids);
 | 
						|
 | 
						|
static struct platform_driver imx_pd_driver = {
 | 
						|
	.probe		= imx_pd_probe,
 | 
						|
	.remove		= imx_pd_remove,
 | 
						|
	.driver		= {
 | 
						|
		.of_match_table = imx_pd_dt_ids,
 | 
						|
		.name	= "imx-parallel-display",
 | 
						|
	},
 | 
						|
};
 | 
						|
 | 
						|
module_platform_driver(imx_pd_driver);
 | 
						|
 | 
						|
MODULE_DESCRIPTION("i.MX parallel display driver");
 | 
						|
MODULE_AUTHOR("Sascha Hauer, Pengutronix");
 | 
						|
MODULE_LICENSE("GPL");
 | 
						|
MODULE_ALIAS("platform:imx-parallel-display");
 |