mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 08:38:45 +02:00 
			
		
		
		
	 69d803c40e
			
		
	
	
		69d803c40e
		
	
	
	
	
		
			
			This reverts commitf8c989a0c8. Before this commit, svc_export_put or expkey_put will call path_put with sync mode. After this commit, path_put will be called with async mode. And this can lead the unexpected results show as follow. mkfs.xfs -f /dev/sda echo "/ *(rw,no_root_squash,fsid=0)" > /etc/exports echo "/mnt *(rw,no_root_squash,fsid=1)" >> /etc/exports exportfs -ra service nfs-server start mount -t nfs -o vers=4.0 127.0.0.1:/mnt /mnt1 mount /dev/sda /mnt/sda touch /mnt1/sda/file exportfs -r umount /mnt/sda # failed unexcepted The touch will finally call nfsd_cross_mnt, add refcount to mount, and then add cache_head. Before this commit, exportfs -r will call cache_flush to cleanup all cache_head, and path_put in svc_export_put/expkey_put will be finished with sync mode. So, the latter umount will always success. However, after this commit, path_put will be called with async mode, the latter umount may failed, and if we add some delay, umount will success too. Personally I think this bug and should be fixed. We first revert before bugfix patch, and then fix the original bug with a different way. Fixes:f8c989a0c8("nfsd: release svc_expkey/svc_export with rcu_work") Signed-off-by: Yang Erkun <yangerkun@huawei.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
		
			
				
	
	
		
			136 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			136 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* SPDX-License-Identifier: GPL-2.0 */
 | |
| /*
 | |
|  * Copyright (C) 1995-1997 Olaf Kirch <okir@monad.swb.de>
 | |
|  */
 | |
| #ifndef NFSD_EXPORT_H
 | |
| #define NFSD_EXPORT_H
 | |
| 
 | |
| #include <linux/sunrpc/cache.h>
 | |
| #include <linux/percpu_counter.h>
 | |
| #include <uapi/linux/nfsd/export.h>
 | |
| #include <linux/nfs4.h>
 | |
| 
 | |
| struct knfsd_fh;
 | |
| struct svc_fh;
 | |
| struct svc_rqst;
 | |
| 
 | |
| /*
 | |
|  * FS Locations
 | |
|  */
 | |
| 
 | |
| #define MAX_FS_LOCATIONS	128
 | |
| 
 | |
| struct nfsd4_fs_location {
 | |
| 	char *hosts; /* colon separated list of hosts */
 | |
| 	char *path;  /* slash separated list of path components */
 | |
| };
 | |
| 
 | |
| struct nfsd4_fs_locations {
 | |
| 	uint32_t locations_count;
 | |
| 	struct nfsd4_fs_location *locations;
 | |
| /* If we're not actually serving this data ourselves (only providing a
 | |
|  * list of replicas that do serve it) then we set "migrated": */
 | |
| 	int migrated;
 | |
| };
 | |
| 
 | |
| /*
 | |
|  * We keep an array of pseudoflavors with the export, in order from most
 | |
|  * to least preferred.  For the foreseeable future, we don't expect more
 | |
|  * than the eight pseudoflavors null, unix, krb5, krb5i, krb5p, skpm3,
 | |
|  * spkm3i, and spkm3p (and using all 8 at once should be rare).
 | |
|  */
 | |
| #define MAX_SECINFO_LIST	8
 | |
| #define EX_UUID_LEN		16
 | |
| 
 | |
| struct exp_flavor_info {
 | |
| 	u32	pseudoflavor;
 | |
| 	u32	flags;
 | |
| };
 | |
| 
 | |
| /* Per-export stats */
 | |
| enum {
 | |
| 	EXP_STATS_FH_STALE,
 | |
| 	EXP_STATS_IO_READ,
 | |
| 	EXP_STATS_IO_WRITE,
 | |
| 	EXP_STATS_COUNTERS_NUM
 | |
| };
 | |
| 
 | |
| struct export_stats {
 | |
| 	time64_t		start_time;
 | |
| 	struct percpu_counter	counter[EXP_STATS_COUNTERS_NUM];
 | |
| };
 | |
| 
 | |
| struct svc_export {
 | |
| 	struct cache_head	h;
 | |
| 	struct auth_domain *	ex_client;
 | |
| 	int			ex_flags;
 | |
| 	int			ex_fsid;
 | |
| 	struct path		ex_path;
 | |
| 	kuid_t			ex_anon_uid;
 | |
| 	kgid_t			ex_anon_gid;
 | |
| 	unsigned char *		ex_uuid; /* 16 byte fsid */
 | |
| 	struct nfsd4_fs_locations ex_fslocs;
 | |
| 	uint32_t		ex_nflavors;
 | |
| 	struct exp_flavor_info	ex_flavors[MAX_SECINFO_LIST];
 | |
| 	u32			ex_layout_types;
 | |
| 	struct nfsd4_deviceid_map *ex_devid_map;
 | |
| 	struct cache_detail	*cd;
 | |
| 	struct rcu_head		ex_rcu;
 | |
| 	unsigned long		ex_xprtsec_modes;
 | |
| 	struct export_stats	*ex_stats;
 | |
| };
 | |
| 
 | |
| /* an "export key" (expkey) maps a filehandlefragement to an
 | |
|  * svc_export for a given client.  There can be several per export,
 | |
|  * for the different fsid types.
 | |
|  */
 | |
| struct svc_expkey {
 | |
| 	struct cache_head	h;
 | |
| 
 | |
| 	struct auth_domain *	ek_client;
 | |
| 	int			ek_fsidtype;
 | |
| 	u32			ek_fsid[6];
 | |
| 
 | |
| 	struct path		ek_path;
 | |
| 	struct rcu_head		ek_rcu;
 | |
| };
 | |
| 
 | |
| #define EX_ISSYNC(exp)		(!((exp)->ex_flags & NFSEXP_ASYNC))
 | |
| #define EX_NOHIDE(exp)		((exp)->ex_flags & NFSEXP_NOHIDE)
 | |
| #define EX_WGATHER(exp)		((exp)->ex_flags & NFSEXP_GATHERED_WRITES)
 | |
| 
 | |
| struct svc_cred;
 | |
| int nfsexp_flags(struct svc_cred *cred, struct svc_export *exp);
 | |
| __be32 check_nfsd_access(struct svc_export *exp, struct svc_rqst *rqstp,
 | |
| 			 bool may_bypass_gss);
 | |
| 
 | |
| /*
 | |
|  * Function declarations
 | |
|  */
 | |
| int			nfsd_export_init(struct net *);
 | |
| void			nfsd_export_shutdown(struct net *);
 | |
| void			nfsd_export_flush(struct net *);
 | |
| struct svc_export *	rqst_exp_get_by_name(struct svc_rqst *,
 | |
| 					     struct path *);
 | |
| struct svc_export *	rqst_exp_parent(struct svc_rqst *,
 | |
| 					struct path *);
 | |
| struct svc_export *	rqst_find_fsidzero_export(struct svc_rqst *);
 | |
| int			exp_rootfh(struct net *, struct auth_domain *,
 | |
| 					char *path, struct knfsd_fh *, int maxsize);
 | |
| __be32			exp_pseudoroot(struct svc_rqst *, struct svc_fh *);
 | |
| 
 | |
| static inline void exp_put(struct svc_export *exp)
 | |
| {
 | |
| 	cache_put(&exp->h, exp->cd);
 | |
| }
 | |
| 
 | |
| static inline struct svc_export *exp_get(struct svc_export *exp)
 | |
| {
 | |
| 	cache_get(&exp->h);
 | |
| 	return exp;
 | |
| }
 | |
| struct svc_export *rqst_exp_find(struct cache_req *reqp, struct net *net,
 | |
| 				 struct auth_domain *cl, struct auth_domain *gsscl,
 | |
| 				 int fsid_type, u32 *fsidv);
 | |
| 
 | |
| #endif /* NFSD_EXPORT_H */
 |