mirror of
				https://github.com/torvalds/linux.git
				synced 2025-10-31 16:48:26 +02:00 
			
		
		
		
	 13b25489b6
			
		
	
	
		13b25489b6
		
	
	
	
	
		
			
			Currently, Kbuild always operates in the output directory of the kernel,
even when building external modules. This increases the risk of external
module Makefiles attempting to write to the kernel directory.
This commit switches the working directory to the external module
directory, allowing the removal of the $(KBUILD_EXTMOD)/ prefix from
some build artifacts.
The command for building external modules maintains backward
compatibility, but Makefiles that rely on working in the kernel
directory may break. In such cases, $(objtree) and $(srctree) should
be used to refer to the output and source directories of the kernel.
The appearance of the build log will change as follows:
[Before]
  $ make -C /path/to/my/linux M=/path/to/my/externel/module
  make: Entering directory '/path/to/my/linux'
    CC [M]  /path/to/my/externel/module/helloworld.o
    MODPOST /path/to/my/externel/module/Module.symvers
    CC [M]  /path/to/my/externel/module/helloworld.mod.o
    CC [M]  /path/to/my/externel/module/.module-common.o
    LD [M]  /path/to/my/externel/module/helloworld.ko
  make: Leaving directory '/path/to/my/linux'
[After]
  $ make -C /path/to/my/linux M=/path/to/my/externel/module
  make: Entering directory '/path/to/my/linux'
  make[1]: Entering directory '/path/to/my/externel/module'
    CC [M]  helloworld.o
    MODPOST Module.symvers
    CC [M]  helloworld.mod.o
    CC [M]  .module-common.o
    LD [M]  helloworld.ko
  make[1]: Leaving directory '/path/to/my/externel/module'
  make: Leaving directory '/path/to/my/linux'
Printing "Entering directory" twice is cumbersome. This will be
addressed later.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <n.schier@avm.de>
		
	
			
		
			
				
	
	
		
			89 lines
		
	
	
	
		
			3.3 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			89 lines
		
	
	
	
		
			3.3 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
| # SPDX-License-Identifier: GPL-2.0-only
 | |
| 
 | |
| # cc-cross-prefix
 | |
| # Usage: CROSS_COMPILE := $(call cc-cross-prefix, m68k-linux-gnu- m68k-linux-)
 | |
| # Return first <prefix> where a <prefix>gcc is found in PATH.
 | |
| # If no gcc found in PATH with listed prefixes return nothing
 | |
| #
 | |
| # Note: '2>/dev/null' is here to force Make to invoke a shell. Otherwise, it
 | |
| # would try to directly execute the shell builtin 'command'. This workaround
 | |
| # should be kept for a long time since this issue was fixed only after the
 | |
| # GNU Make 4.2.1 release.
 | |
| cc-cross-prefix = $(firstword $(foreach c, $(1), \
 | |
| 			$(if $(shell command -v -- $(c)gcc 2>/dev/null), $(c))))
 | |
| 
 | |
| # output directory for tests below
 | |
| TMPOUT = .tmp_$$$$
 | |
| 
 | |
| # try-run
 | |
| # Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise)
 | |
| # Exit code chooses option. "$$TMP" serves as a temporary file and is
 | |
| # automatically cleaned up.
 | |
| try-run = $(shell set -e;		\
 | |
| 	TMP=$(TMPOUT)/tmp;		\
 | |
| 	trap "rm -rf $(TMPOUT)" EXIT;	\
 | |
| 	mkdir -p $(TMPOUT);		\
 | |
| 	if ($(1)) >/dev/null 2>&1;	\
 | |
| 	then echo "$(2)";		\
 | |
| 	else echo "$(3)";		\
 | |
| 	fi)
 | |
| 
 | |
| # as-option
 | |
| # Usage: aflags-y += $(call as-option,-Wa$(comma)-isa=foo,)
 | |
| 
 | |
| as-option = $(call try-run,\
 | |
| 	$(CC) -Werror $(KBUILD_CPPFLAGS) $(KBUILD_AFLAGS) $(1) -c -x assembler-with-cpp /dev/null -o "$$TMP",$(1),$(2))
 | |
| 
 | |
| # as-instr
 | |
| # Usage: aflags-y += $(call as-instr,instr,option1,option2)
 | |
| 
 | |
| as-instr = $(call try-run,\
 | |
| 	printf "%b\n" "$(1)" | $(CC) -Werror $(CLANG_FLAGS) $(KBUILD_AFLAGS) -Wa$(comma)--fatal-warnings -c -x assembler-with-cpp -o "$$TMP" -,$(2),$(3))
 | |
| 
 | |
| # __cc-option
 | |
| # Usage: MY_CFLAGS += $(call __cc-option,$(CC),$(MY_CFLAGS),-march=winchip-c6,-march=i586)
 | |
| __cc-option = $(call try-run,\
 | |
| 	$(1) -Werror $(2) $(3) -c -x c /dev/null -o "$$TMP",$(3),$(4))
 | |
| 
 | |
| # cc-option
 | |
| # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586)
 | |
| 
 | |
| cc-option = $(call __cc-option, $(CC),\
 | |
| 	$(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS),$(1),$(2))
 | |
| 
 | |
| # cc-option-yn
 | |
| # Usage: flag := $(call cc-option-yn,-march=winchip-c6)
 | |
| cc-option-yn = $(if $(call cc-option,$1),y,n)
 | |
| 
 | |
| # cc-disable-warning
 | |
| # Usage: cflags-y += $(call cc-disable-warning,unused-but-set-variable)
 | |
| cc-disable-warning = $(if $(call cc-option,-W$(strip $1)),-Wno-$(strip $1))
 | |
| 
 | |
| # gcc-min-version
 | |
| # Usage: cflags-$(call gcc-min-version, 70100) += -foo
 | |
| gcc-min-version = $(call test-ge, $(CONFIG_GCC_VERSION), $1)
 | |
| 
 | |
| # clang-min-version
 | |
| # Usage: cflags-$(call clang-min-version, 110000) += -foo
 | |
| clang-min-version = $(call test-ge, $(CONFIG_CLANG_VERSION), $1)
 | |
| 
 | |
| # ld-option
 | |
| # Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y)
 | |
| ld-option = $(call try-run, $(LD) $(KBUILD_LDFLAGS) $(1) -v,$(1),$(2),$(3))
 | |
| 
 | |
| # __rustc-option
 | |
| # Usage: MY_RUSTFLAGS += $(call __rustc-option,$(RUSTC),$(MY_RUSTFLAGS),-Cinstrument-coverage,-Zinstrument-coverage)
 | |
| # TODO: remove RUSTC_BOOTSTRAP=1 when we raise the minimum GNU Make version to 4.4
 | |
| __rustc-option = $(call try-run,\
 | |
| 	echo '#![allow(missing_docs)]#![feature(no_core)]#![no_core]' | RUSTC_BOOTSTRAP=1\
 | |
| 	$(1) --sysroot=/dev/null $(filter-out --sysroot=/dev/null,$(2)) $(3)\
 | |
| 	--crate-type=rlib --out-dir=$(TMPOUT) --emit=obj=- - >/dev/null,$(3),$(4))
 | |
| 
 | |
| # rustc-option
 | |
| # Usage: rustflags-y += $(call rustc-option,-Cinstrument-coverage,-Zinstrument-coverage)
 | |
| rustc-option = $(call __rustc-option, $(RUSTC),\
 | |
| 	$(KBUILD_RUSTFLAGS),$(1),$(2))
 | |
| 
 | |
| # rustc-option-yn
 | |
| # Usage: flag := $(call rustc-option-yn,-Cinstrument-coverage)
 | |
| rustc-option-yn = $(if $(call rustc-option,$1),y,n)
 |