mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 10:40:15 +02:00 
			
		
		
		
	Most drivers that use bridges forgot to detach them at cleanup time. Instead of fixing them one by one, detach the bridge in the core drm_encoder_cleanup() function. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Archit Taneja <architt@codeaurora.org> Link: http://patchwork.freedesktop.org/patch/msgid/1481709550-29226-5-git-send-email-laurent.pinchart+renesas@ideasonboard.com
		
			
				
	
	
		
			330 lines
		
	
	
	
		
			8.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			330 lines
		
	
	
	
		
			8.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * i.MX drm driver - parallel display implementation
 | 
						|
 *
 | 
						|
 * Copyright (C) 2012 Sascha Hauer, Pengutronix
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or
 | 
						|
 * modify it under the terms of the GNU General Public License
 | 
						|
 * as published by the Free Software Foundation; either version 2
 | 
						|
 * of the License, or (at your option) any later version.
 | 
						|
 * This program is distributed in the hope that it will be useful,
 | 
						|
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
 * GNU General Public License for more details.
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/component.h>
 | 
						|
#include <linux/module.h>
 | 
						|
#include <drm/drmP.h>
 | 
						|
#include <drm/drm_atomic_helper.h>
 | 
						|
#include <drm/drm_fb_helper.h>
 | 
						|
#include <drm/drm_crtc_helper.h>
 | 
						|
#include <drm/drm_panel.h>
 | 
						|
#include <linux/videodev2.h>
 | 
						|
#include <video/of_display_timing.h>
 | 
						|
#include <linux/of_graph.h>
 | 
						|
 | 
						|
#include "imx-drm.h"
 | 
						|
 | 
						|
struct imx_parallel_display {
 | 
						|
	struct drm_connector connector;
 | 
						|
	struct drm_encoder encoder;
 | 
						|
	struct device *dev;
 | 
						|
	void *edid;
 | 
						|
	int edid_len;
 | 
						|
	u32 bus_format;
 | 
						|
	u32 bus_flags;
 | 
						|
	struct drm_display_mode mode;
 | 
						|
	struct drm_panel *panel;
 | 
						|
	struct drm_bridge *bridge;
 | 
						|
};
 | 
						|
 | 
						|
static inline struct imx_parallel_display *con_to_imxpd(struct drm_connector *c)
 | 
						|
{
 | 
						|
	return container_of(c, struct imx_parallel_display, connector);
 | 
						|
}
 | 
						|
 | 
						|
static inline struct imx_parallel_display *enc_to_imxpd(struct drm_encoder *e)
 | 
						|
{
 | 
						|
	return container_of(e, struct imx_parallel_display, encoder);
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_connector_get_modes(struct drm_connector *connector)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = con_to_imxpd(connector);
 | 
						|
	struct device_node *np = imxpd->dev->of_node;
 | 
						|
	int num_modes = 0;
 | 
						|
 | 
						|
	if (imxpd->panel && imxpd->panel->funcs &&
 | 
						|
	    imxpd->panel->funcs->get_modes) {
 | 
						|
		num_modes = imxpd->panel->funcs->get_modes(imxpd->panel);
 | 
						|
		if (num_modes > 0)
 | 
						|
			return num_modes;
 | 
						|
	}
 | 
						|
 | 
						|
	if (imxpd->edid) {
 | 
						|
		drm_mode_connector_update_edid_property(connector, imxpd->edid);
 | 
						|
		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 | 
						|
	}
 | 
						|
 | 
						|
	if (np) {
 | 
						|
		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 | 
						|
		int ret;
 | 
						|
 | 
						|
		if (!mode)
 | 
						|
			return -EINVAL;
 | 
						|
 | 
						|
		ret = of_get_drm_display_mode(np, &imxpd->mode,
 | 
						|
					      &imxpd->bus_flags,
 | 
						|
					      OF_USE_NATIVE_MODE);
 | 
						|
		if (ret)
 | 
						|
			return ret;
 | 
						|
 | 
						|
		drm_mode_copy(mode, &imxpd->mode);
 | 
						|
		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
 | 
						|
		drm_mode_probed_add(connector, mode);
 | 
						|
		num_modes++;
 | 
						|
	}
 | 
						|
 | 
						|
	return num_modes;
 | 
						|
}
 | 
						|
 | 
						|
static struct drm_encoder *imx_pd_connector_best_encoder(
 | 
						|
		struct drm_connector *connector)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = con_to_imxpd(connector);
 | 
						|
 | 
						|
	return &imxpd->encoder;
 | 
						|
}
 | 
						|
 | 
						|
static void imx_pd_encoder_enable(struct drm_encoder *encoder)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
 | 
						|
 | 
						|
	drm_panel_prepare(imxpd->panel);
 | 
						|
	drm_panel_enable(imxpd->panel);
 | 
						|
}
 | 
						|
 | 
						|
static void imx_pd_encoder_disable(struct drm_encoder *encoder)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
 | 
						|
 | 
						|
	drm_panel_disable(imxpd->panel);
 | 
						|
	drm_panel_unprepare(imxpd->panel);
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_encoder_atomic_check(struct drm_encoder *encoder,
 | 
						|
				       struct drm_crtc_state *crtc_state,
 | 
						|
				       struct drm_connector_state *conn_state)
 | 
						|
{
 | 
						|
	struct imx_crtc_state *imx_crtc_state = to_imx_crtc_state(crtc_state);
 | 
						|
	struct drm_display_info *di = &conn_state->connector->display_info;
 | 
						|
	struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
 | 
						|
 | 
						|
	if (!imxpd->bus_format && di->num_bus_formats) {
 | 
						|
		imx_crtc_state->bus_flags = di->bus_flags;
 | 
						|
		imx_crtc_state->bus_format = di->bus_formats[0];
 | 
						|
	} else {
 | 
						|
		imx_crtc_state->bus_flags = imxpd->bus_flags;
 | 
						|
		imx_crtc_state->bus_format = imxpd->bus_format;
 | 
						|
	}
 | 
						|
	imx_crtc_state->di_hsync_pin = 2;
 | 
						|
	imx_crtc_state->di_vsync_pin = 3;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static const struct drm_connector_funcs imx_pd_connector_funcs = {
 | 
						|
	.dpms = drm_atomic_helper_connector_dpms,
 | 
						|
	.fill_modes = drm_helper_probe_single_connector_modes,
 | 
						|
	.destroy = imx_drm_connector_destroy,
 | 
						|
	.reset = drm_atomic_helper_connector_reset,
 | 
						|
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 | 
						|
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 | 
						|
};
 | 
						|
 | 
						|
static const struct drm_connector_helper_funcs imx_pd_connector_helper_funcs = {
 | 
						|
	.get_modes = imx_pd_connector_get_modes,
 | 
						|
	.best_encoder = imx_pd_connector_best_encoder,
 | 
						|
};
 | 
						|
 | 
						|
static const struct drm_encoder_funcs imx_pd_encoder_funcs = {
 | 
						|
	.destroy = imx_drm_encoder_destroy,
 | 
						|
};
 | 
						|
 | 
						|
static const struct drm_encoder_helper_funcs imx_pd_encoder_helper_funcs = {
 | 
						|
	.enable = imx_pd_encoder_enable,
 | 
						|
	.disable = imx_pd_encoder_disable,
 | 
						|
	.atomic_check = imx_pd_encoder_atomic_check,
 | 
						|
};
 | 
						|
 | 
						|
static int imx_pd_register(struct drm_device *drm,
 | 
						|
	struct imx_parallel_display *imxpd)
 | 
						|
{
 | 
						|
	struct drm_encoder *encoder = &imxpd->encoder;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = imx_drm_encoder_parse_of(drm, encoder, imxpd->dev->of_node);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	/* set the connector's dpms to OFF so that
 | 
						|
	 * drm_helper_connector_dpms() won't return
 | 
						|
	 * immediately since the current state is ON
 | 
						|
	 * at this point.
 | 
						|
	 */
 | 
						|
	imxpd->connector.dpms = DRM_MODE_DPMS_OFF;
 | 
						|
 | 
						|
	drm_encoder_helper_add(encoder, &imx_pd_encoder_helper_funcs);
 | 
						|
	drm_encoder_init(drm, encoder, &imx_pd_encoder_funcs,
 | 
						|
			 DRM_MODE_ENCODER_NONE, NULL);
 | 
						|
 | 
						|
	if (!imxpd->bridge) {
 | 
						|
		drm_connector_helper_add(&imxpd->connector,
 | 
						|
				&imx_pd_connector_helper_funcs);
 | 
						|
		drm_connector_init(drm, &imxpd->connector,
 | 
						|
				   &imx_pd_connector_funcs,
 | 
						|
				   DRM_MODE_CONNECTOR_VGA);
 | 
						|
	}
 | 
						|
 | 
						|
	if (imxpd->panel)
 | 
						|
		drm_panel_attach(imxpd->panel, &imxpd->connector);
 | 
						|
 | 
						|
	if (imxpd->bridge) {
 | 
						|
		ret = drm_bridge_attach(encoder, imxpd->bridge, NULL);
 | 
						|
		if (ret < 0) {
 | 
						|
			dev_err(imxpd->dev, "failed to attach bridge: %d\n",
 | 
						|
				ret);
 | 
						|
			return ret;
 | 
						|
		}
 | 
						|
	} else {
 | 
						|
		drm_mode_connector_attach_encoder(&imxpd->connector, encoder);
 | 
						|
	}
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_bind(struct device *dev, struct device *master, void *data)
 | 
						|
{
 | 
						|
	struct drm_device *drm = data;
 | 
						|
	struct device_node *np = dev->of_node;
 | 
						|
	struct device_node *ep;
 | 
						|
	const u8 *edidp;
 | 
						|
	struct imx_parallel_display *imxpd;
 | 
						|
	int ret;
 | 
						|
	u32 bus_format = 0;
 | 
						|
	const char *fmt;
 | 
						|
 | 
						|
	imxpd = devm_kzalloc(dev, sizeof(*imxpd), GFP_KERNEL);
 | 
						|
	if (!imxpd)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	edidp = of_get_property(np, "edid", &imxpd->edid_len);
 | 
						|
	if (edidp)
 | 
						|
		imxpd->edid = kmemdup(edidp, imxpd->edid_len, GFP_KERNEL);
 | 
						|
 | 
						|
	ret = of_property_read_string(np, "interface-pix-fmt", &fmt);
 | 
						|
	if (!ret) {
 | 
						|
		if (!strcmp(fmt, "rgb24"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB888_1X24;
 | 
						|
		else if (!strcmp(fmt, "rgb565"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB565_1X16;
 | 
						|
		else if (!strcmp(fmt, "bgr666"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB666_1X18;
 | 
						|
		else if (!strcmp(fmt, "lvds666"))
 | 
						|
			bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
 | 
						|
	}
 | 
						|
	imxpd->bus_format = bus_format;
 | 
						|
 | 
						|
	/* port@1 is the output port */
 | 
						|
	ep = of_graph_get_endpoint_by_regs(np, 1, -1);
 | 
						|
	if (ep) {
 | 
						|
		struct device_node *remote;
 | 
						|
 | 
						|
		remote = of_graph_get_remote_port_parent(ep);
 | 
						|
		if (!remote) {
 | 
						|
			dev_warn(dev, "endpoint %s not connected\n",
 | 
						|
				 ep->full_name);
 | 
						|
			of_node_put(ep);
 | 
						|
			return -ENODEV;
 | 
						|
		}
 | 
						|
		of_node_put(ep);
 | 
						|
 | 
						|
		imxpd->panel = of_drm_find_panel(remote);
 | 
						|
		if (imxpd->panel) {
 | 
						|
			dev_dbg(dev, "found panel %s\n", remote->full_name);
 | 
						|
		} else {
 | 
						|
			imxpd->bridge = of_drm_find_bridge(remote);
 | 
						|
			if (imxpd->bridge)
 | 
						|
				dev_dbg(dev, "found bridge %s\n",
 | 
						|
					remote->full_name);
 | 
						|
		}
 | 
						|
		if (!imxpd->panel && !imxpd->bridge) {
 | 
						|
			dev_dbg(dev, "waiting for panel or bridge %s\n",
 | 
						|
				remote->full_name);
 | 
						|
			of_node_put(remote);
 | 
						|
			return -EPROBE_DEFER;
 | 
						|
		}
 | 
						|
		of_node_put(remote);
 | 
						|
	}
 | 
						|
 | 
						|
	imxpd->dev = dev;
 | 
						|
 | 
						|
	ret = imx_pd_register(drm, imxpd);
 | 
						|
	if (ret)
 | 
						|
		return ret;
 | 
						|
 | 
						|
	dev_set_drvdata(dev, imxpd);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void imx_pd_unbind(struct device *dev, struct device *master,
 | 
						|
	void *data)
 | 
						|
{
 | 
						|
	struct imx_parallel_display *imxpd = dev_get_drvdata(dev);
 | 
						|
 | 
						|
	if (imxpd->panel)
 | 
						|
		drm_panel_detach(imxpd->panel);
 | 
						|
 | 
						|
	kfree(imxpd->edid);
 | 
						|
}
 | 
						|
 | 
						|
static const struct component_ops imx_pd_ops = {
 | 
						|
	.bind	= imx_pd_bind,
 | 
						|
	.unbind	= imx_pd_unbind,
 | 
						|
};
 | 
						|
 | 
						|
static int imx_pd_probe(struct platform_device *pdev)
 | 
						|
{
 | 
						|
	return component_add(&pdev->dev, &imx_pd_ops);
 | 
						|
}
 | 
						|
 | 
						|
static int imx_pd_remove(struct platform_device *pdev)
 | 
						|
{
 | 
						|
	component_del(&pdev->dev, &imx_pd_ops);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static const struct of_device_id imx_pd_dt_ids[] = {
 | 
						|
	{ .compatible = "fsl,imx-parallel-display", },
 | 
						|
	{ /* sentinel */ }
 | 
						|
};
 | 
						|
MODULE_DEVICE_TABLE(of, imx_pd_dt_ids);
 | 
						|
 | 
						|
static struct platform_driver imx_pd_driver = {
 | 
						|
	.probe		= imx_pd_probe,
 | 
						|
	.remove		= imx_pd_remove,
 | 
						|
	.driver		= {
 | 
						|
		.of_match_table = imx_pd_dt_ids,
 | 
						|
		.name	= "imx-parallel-display",
 | 
						|
	},
 | 
						|
};
 | 
						|
 | 
						|
module_platform_driver(imx_pd_driver);
 | 
						|
 | 
						|
MODULE_DESCRIPTION("i.MX parallel display driver");
 | 
						|
MODULE_AUTHOR("Sascha Hauer, Pengutronix");
 | 
						|
MODULE_LICENSE("GPL");
 | 
						|
MODULE_ALIAS("platform:imx-parallel-display");
 |