mirror of
				https://github.com/torvalds/linux.git
				synced 2025-11-04 02:30:34 +02:00 
			
		
		
		
	Attempting to get a crash dump out of a debug PREEMPT_RT kernel via an NMI panic() doesn't work. The cause of that lies in the PREEMPT_RT definition of mutex_trylock(): if (IS_ENABLED(CONFIG_DEBUG_RT_MUTEXES) && WARN_ON_ONCE(!in_task())) return 0; This prevents an nmi_panic() from executing the main body of __crash_kexec() which does the actual kexec into the kdump kernel. The warning and return are explained by:6ce47fd961("rtmutex: Warn if trylock is called from hard/softirq context") [...] The reasons for this are: 1) There is a potential deadlock in the slowpath 2) Another cpu which blocks on the rtmutex will boost the task which allegedly locked the rtmutex, but that cannot work because the hard/softirq context borrows the task context. Furthermore, grabbing the lock isn't NMI safe, so do away with kexec_mutex and replace it with an atomic variable. This is somewhat overzealous as *some* callsites could keep using a mutex (e.g. the sysfs-facing ones like crash_shrink_memory()), but this has the benefit of involving a single unified lock and preventing any future NMI-related surprises. Tested by triggering NMI panics via: $ echo 1 > /proc/sys/kernel/panic_on_unrecovered_nmi $ echo 1 > /proc/sys/kernel/unknown_nmi_panic $ echo 1 > /proc/sys/kernel/panic $ ipmitool power diag Link: https://lkml.kernel.org/r/20220630223258.4144112-3-vschneid@redhat.com Fixes:6ce47fd961("rtmutex: Warn if trylock is called from hard/softirq context") Signed-off-by: Valentin Schneider <vschneid@redhat.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Baoquan He <bhe@redhat.com> Cc: "Eric W . Biederman" <ebiederm@xmission.com> Cc: Juri Lelli <jlelli@redhat.com> Cc: Luis Claudio R. Goncalves <lgoncalv@redhat.com> Cc: Miaohe Lin <linmiaohe@huawei.com> Cc: Petr Mladek <pmladek@suse.com> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
		
			
				
	
	
		
			295 lines
		
	
	
	
		
			7.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			295 lines
		
	
	
	
		
			7.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0-only
 | 
						|
/*
 | 
						|
 * kexec.c - kexec_load system call
 | 
						|
 * Copyright (C) 2002-2004 Eric Biederman  <ebiederm@xmission.com>
 | 
						|
 */
 | 
						|
 | 
						|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 | 
						|
 | 
						|
#include <linux/capability.h>
 | 
						|
#include <linux/mm.h>
 | 
						|
#include <linux/file.h>
 | 
						|
#include <linux/security.h>
 | 
						|
#include <linux/kexec.h>
 | 
						|
#include <linux/mutex.h>
 | 
						|
#include <linux/list.h>
 | 
						|
#include <linux/syscalls.h>
 | 
						|
#include <linux/vmalloc.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
 | 
						|
#include "kexec_internal.h"
 | 
						|
 | 
						|
static int kimage_alloc_init(struct kimage **rimage, unsigned long entry,
 | 
						|
			     unsigned long nr_segments,
 | 
						|
			     struct kexec_segment *segments,
 | 
						|
			     unsigned long flags)
 | 
						|
{
 | 
						|
	int ret;
 | 
						|
	struct kimage *image;
 | 
						|
	bool kexec_on_panic = flags & KEXEC_ON_CRASH;
 | 
						|
 | 
						|
	if (kexec_on_panic) {
 | 
						|
		/* Verify we have a valid entry point */
 | 
						|
		if ((entry < phys_to_boot_phys(crashk_res.start)) ||
 | 
						|
		    (entry > phys_to_boot_phys(crashk_res.end)))
 | 
						|
			return -EADDRNOTAVAIL;
 | 
						|
	}
 | 
						|
 | 
						|
	/* Allocate and initialize a controlling structure */
 | 
						|
	image = do_kimage_alloc_init();
 | 
						|
	if (!image)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	image->start = entry;
 | 
						|
	image->nr_segments = nr_segments;
 | 
						|
	memcpy(image->segment, segments, nr_segments * sizeof(*segments));
 | 
						|
 | 
						|
	if (kexec_on_panic) {
 | 
						|
		/* Enable special crash kernel control page alloc policy. */
 | 
						|
		image->control_page = crashk_res.start;
 | 
						|
		image->type = KEXEC_TYPE_CRASH;
 | 
						|
	}
 | 
						|
 | 
						|
	ret = sanity_check_segment_list(image);
 | 
						|
	if (ret)
 | 
						|
		goto out_free_image;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Find a location for the control code buffer, and add it
 | 
						|
	 * the vector of segments so that it's pages will also be
 | 
						|
	 * counted as destination pages.
 | 
						|
	 */
 | 
						|
	ret = -ENOMEM;
 | 
						|
	image->control_code_page = kimage_alloc_control_pages(image,
 | 
						|
					   get_order(KEXEC_CONTROL_PAGE_SIZE));
 | 
						|
	if (!image->control_code_page) {
 | 
						|
		pr_err("Could not allocate control_code_buffer\n");
 | 
						|
		goto out_free_image;
 | 
						|
	}
 | 
						|
 | 
						|
	if (!kexec_on_panic) {
 | 
						|
		image->swap_page = kimage_alloc_control_pages(image, 0);
 | 
						|
		if (!image->swap_page) {
 | 
						|
			pr_err("Could not allocate swap buffer\n");
 | 
						|
			goto out_free_control_pages;
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	*rimage = image;
 | 
						|
	return 0;
 | 
						|
out_free_control_pages:
 | 
						|
	kimage_free_page_list(&image->control_pages);
 | 
						|
out_free_image:
 | 
						|
	kfree(image);
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
 | 
						|
		struct kexec_segment *segments, unsigned long flags)
 | 
						|
{
 | 
						|
	struct kimage **dest_image, *image;
 | 
						|
	unsigned long i;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Because we write directly to the reserved memory region when loading
 | 
						|
	 * crash kernels we need a serialization here to prevent multiple crash
 | 
						|
	 * kernels from attempting to load simultaneously.
 | 
						|
	 */
 | 
						|
	if (!kexec_trylock())
 | 
						|
		return -EBUSY;
 | 
						|
 | 
						|
	if (flags & KEXEC_ON_CRASH) {
 | 
						|
		dest_image = &kexec_crash_image;
 | 
						|
		if (kexec_crash_image)
 | 
						|
			arch_kexec_unprotect_crashkres();
 | 
						|
	} else {
 | 
						|
		dest_image = &kexec_image;
 | 
						|
	}
 | 
						|
 | 
						|
	if (nr_segments == 0) {
 | 
						|
		/* Uninstall image */
 | 
						|
		kimage_free(xchg(dest_image, NULL));
 | 
						|
		ret = 0;
 | 
						|
		goto out_unlock;
 | 
						|
	}
 | 
						|
	if (flags & KEXEC_ON_CRASH) {
 | 
						|
		/*
 | 
						|
		 * Loading another kernel to switch to if this one
 | 
						|
		 * crashes.  Free any current crash dump kernel before
 | 
						|
		 * we corrupt it.
 | 
						|
		 */
 | 
						|
		kimage_free(xchg(&kexec_crash_image, NULL));
 | 
						|
	}
 | 
						|
 | 
						|
	ret = kimage_alloc_init(&image, entry, nr_segments, segments, flags);
 | 
						|
	if (ret)
 | 
						|
		goto out_unlock;
 | 
						|
 | 
						|
	if (flags & KEXEC_PRESERVE_CONTEXT)
 | 
						|
		image->preserve_context = 1;
 | 
						|
 | 
						|
	ret = machine_kexec_prepare(image);
 | 
						|
	if (ret)
 | 
						|
		goto out;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Some architecture(like S390) may touch the crash memory before
 | 
						|
	 * machine_kexec_prepare(), we must copy vmcoreinfo data after it.
 | 
						|
	 */
 | 
						|
	ret = kimage_crash_copy_vmcoreinfo(image);
 | 
						|
	if (ret)
 | 
						|
		goto out;
 | 
						|
 | 
						|
	for (i = 0; i < nr_segments; i++) {
 | 
						|
		ret = kimage_load_segment(image, &image->segment[i]);
 | 
						|
		if (ret)
 | 
						|
			goto out;
 | 
						|
	}
 | 
						|
 | 
						|
	kimage_terminate(image);
 | 
						|
 | 
						|
	ret = machine_kexec_post_load(image);
 | 
						|
	if (ret)
 | 
						|
		goto out;
 | 
						|
 | 
						|
	/* Install the new kernel and uninstall the old */
 | 
						|
	image = xchg(dest_image, image);
 | 
						|
 | 
						|
out:
 | 
						|
	if ((flags & KEXEC_ON_CRASH) && kexec_crash_image)
 | 
						|
		arch_kexec_protect_crashkres();
 | 
						|
 | 
						|
	kimage_free(image);
 | 
						|
out_unlock:
 | 
						|
	kexec_unlock();
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
/*
 | 
						|
 * Exec Kernel system call: for obvious reasons only root may call it.
 | 
						|
 *
 | 
						|
 * This call breaks up into three pieces.
 | 
						|
 * - A generic part which loads the new kernel from the current
 | 
						|
 *   address space, and very carefully places the data in the
 | 
						|
 *   allocated pages.
 | 
						|
 *
 | 
						|
 * - A generic part that interacts with the kernel and tells all of
 | 
						|
 *   the devices to shut down.  Preventing on-going dmas, and placing
 | 
						|
 *   the devices in a consistent state so a later kernel can
 | 
						|
 *   reinitialize them.
 | 
						|
 *
 | 
						|
 * - A machine specific part that includes the syscall number
 | 
						|
 *   and then copies the image to it's final destination.  And
 | 
						|
 *   jumps into the image at entry.
 | 
						|
 *
 | 
						|
 * kexec does not sync, or unmount filesystems so if you need
 | 
						|
 * that to happen you need to do that yourself.
 | 
						|
 */
 | 
						|
 | 
						|
static inline int kexec_load_check(unsigned long nr_segments,
 | 
						|
				   unsigned long flags)
 | 
						|
{
 | 
						|
	int result;
 | 
						|
 | 
						|
	/* We only trust the superuser with rebooting the system. */
 | 
						|
	if (!capable(CAP_SYS_BOOT) || kexec_load_disabled)
 | 
						|
		return -EPERM;
 | 
						|
 | 
						|
	/* Permit LSMs and IMA to fail the kexec */
 | 
						|
	result = security_kernel_load_data(LOADING_KEXEC_IMAGE, false);
 | 
						|
	if (result < 0)
 | 
						|
		return result;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * kexec can be used to circumvent module loading restrictions, so
 | 
						|
	 * prevent loading in that case
 | 
						|
	 */
 | 
						|
	result = security_locked_down(LOCKDOWN_KEXEC);
 | 
						|
	if (result)
 | 
						|
		return result;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Verify we have a legal set of flags
 | 
						|
	 * This leaves us room for future extensions.
 | 
						|
	 */
 | 
						|
	if ((flags & KEXEC_FLAGS) != (flags & ~KEXEC_ARCH_MASK))
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	/* Put an artificial cap on the number
 | 
						|
	 * of segments passed to kexec_load.
 | 
						|
	 */
 | 
						|
	if (nr_segments > KEXEC_SEGMENT_MAX)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments,
 | 
						|
		struct kexec_segment __user *, segments, unsigned long, flags)
 | 
						|
{
 | 
						|
	struct kexec_segment *ksegments;
 | 
						|
	unsigned long result;
 | 
						|
 | 
						|
	result = kexec_load_check(nr_segments, flags);
 | 
						|
	if (result)
 | 
						|
		return result;
 | 
						|
 | 
						|
	/* Verify we are on the appropriate architecture */
 | 
						|
	if (((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH) &&
 | 
						|
		((flags & KEXEC_ARCH_MASK) != KEXEC_ARCH_DEFAULT))
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	ksegments = memdup_user(segments, nr_segments * sizeof(ksegments[0]));
 | 
						|
	if (IS_ERR(ksegments))
 | 
						|
		return PTR_ERR(ksegments);
 | 
						|
 | 
						|
	result = do_kexec_load(entry, nr_segments, ksegments, flags);
 | 
						|
	kfree(ksegments);
 | 
						|
 | 
						|
	return result;
 | 
						|
}
 | 
						|
 | 
						|
#ifdef CONFIG_COMPAT
 | 
						|
COMPAT_SYSCALL_DEFINE4(kexec_load, compat_ulong_t, entry,
 | 
						|
		       compat_ulong_t, nr_segments,
 | 
						|
		       struct compat_kexec_segment __user *, segments,
 | 
						|
		       compat_ulong_t, flags)
 | 
						|
{
 | 
						|
	struct compat_kexec_segment in;
 | 
						|
	struct kexec_segment *ksegments;
 | 
						|
	unsigned long i, result;
 | 
						|
 | 
						|
	result = kexec_load_check(nr_segments, flags);
 | 
						|
	if (result)
 | 
						|
		return result;
 | 
						|
 | 
						|
	/* Don't allow clients that don't understand the native
 | 
						|
	 * architecture to do anything.
 | 
						|
	 */
 | 
						|
	if ((flags & KEXEC_ARCH_MASK) == KEXEC_ARCH_DEFAULT)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	ksegments = kmalloc_array(nr_segments, sizeof(ksegments[0]),
 | 
						|
			GFP_KERNEL);
 | 
						|
	if (!ksegments)
 | 
						|
		return -ENOMEM;
 | 
						|
 | 
						|
	for (i = 0; i < nr_segments; i++) {
 | 
						|
		result = copy_from_user(&in, &segments[i], sizeof(in));
 | 
						|
		if (result)
 | 
						|
			goto fail;
 | 
						|
 | 
						|
		ksegments[i].buf   = compat_ptr(in.buf);
 | 
						|
		ksegments[i].bufsz = in.bufsz;
 | 
						|
		ksegments[i].mem   = in.mem;
 | 
						|
		ksegments[i].memsz = in.memsz;
 | 
						|
	}
 | 
						|
 | 
						|
	result = do_kexec_load(entry, nr_segments, ksegments, flags);
 | 
						|
 | 
						|
fail:
 | 
						|
	kfree(ksegments);
 | 
						|
	return result;
 | 
						|
}
 | 
						|
#endif
 |