mirror of
https://github.com/torvalds/linux.git
synced 2025-11-04 10:40:15 +02:00
b3e3d4c618
Currently we use a mixture of %016llx, %llx, and %16llx when printing a SAS address. Since the most significant nibble of the SAS address is always 5 - as per standard - this formatting is not so important; but some fake SAS addresses for SATA devices may not be. And we have mangled/invalid address to consider also. And it's better to be consistent in the code, so use a fixed format. The SAS address is a fixed size at 64b, so we want to 0 byte extend to 16 nibbles, so use %016llx globally. Also make some prints to be explicitly hex, and tidy some whitespace issue. Link: https://lore.kernel.org/r/1576758957-227350-1-git-send-email-john.garry@huawei.com Signed-off-by: John Garry <john.garry@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
38 lines
1.1 KiB
C
38 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
#include "sas_internal.h"
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/export.h>
|
|
#include <scsi/sas.h>
|
|
#include <scsi/libsas.h>
|
|
|
|
/* fill task_status_struct based on SSP response frame */
|
|
void sas_ssp_task_response(struct device *dev, struct sas_task *task,
|
|
struct ssp_response_iu *iu)
|
|
{
|
|
struct task_status_struct *tstat = &task->task_status;
|
|
|
|
tstat->resp = SAS_TASK_COMPLETE;
|
|
|
|
if (iu->datapres == 0)
|
|
tstat->stat = iu->status;
|
|
else if (iu->datapres == 1)
|
|
tstat->stat = iu->resp_data[3];
|
|
else if (iu->datapres == 2) {
|
|
tstat->stat = SAM_STAT_CHECK_CONDITION;
|
|
tstat->buf_valid_size =
|
|
min_t(int, SAS_STATUS_BUF_SIZE,
|
|
be32_to_cpu(iu->sense_data_len));
|
|
memcpy(tstat->buf, iu->sense_data, tstat->buf_valid_size);
|
|
|
|
if (iu->status != SAM_STAT_CHECK_CONDITION)
|
|
dev_warn(dev, "dev %016llx sent sense data, but stat(0x%x) is not CHECK CONDITION\n",
|
|
SAS_ADDR(task->dev->sas_addr), iu->status);
|
|
}
|
|
else
|
|
/* when datapres contains corrupt/unknown value... */
|
|
tstat->stat = SAM_STAT_CHECK_CONDITION;
|
|
}
|
|
EXPORT_SYMBOL_GPL(sas_ssp_task_response);
|
|
|